Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 185261 - Review Request: gnochm - CHM file viewer
Summary: Review Request: gnochm - CHM file viewer
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: John Mahowald
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On: 185260
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-03-12 22:07 UTC by Patrice Dumas
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-04-09 11:48:53 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)

Description Patrice Dumas 2006-03-12 22:07:25 UTC 
SRPM Name or Url: 
http://www.environnement.ens.fr/perso/dumas/fc-srpms/gnochm-0.9.7-1.src.rpm
Description: 

A CHM file viewer for Gnome. Features are:

  * Full text search
  * Bookmarks
  * Support for external ms-its links
  * Configurable support for http links
  * Internationalisation
  * Displays HTML page source
Comment 1 John Mahowald 2006-03-17 17:15:44 UTC 
Built fine, but when I tried to run it complained "No module named chm" Works
with python-chm installed. rpm isn't picking up that it requires python-chm,
make it explicit in the spec.
Comment 2 Patrice Dumas 2006-03-17 18:22:56 UTC 
Thanks. I also removed python-chm from the BuildRequires, as it doesn't seems to
be required when building. Updated srpm available here:

http://www.environnement.ens.fr/perso/dumas/fc-srpms/gnochm-0.9.7-1.src.rpm
Comment 3 John Mahowald 2006-03-21 21:45:23 UTC 
Builds, but some deps really should be explicit:
* BuildRequires: gettext is missing (required by the %find_lang macro)
* Missing dependancy on update-mime-database for %post (package shared-mime-info)
* Missing dependancy on update-mime-database for %postun (package shared-mime-info)

Otherwise:
- rpmlint checks return:
W: gnochm conffile-without-noreplace-flag /etc/gconf/schemas/gnochm.schemas
can ignore
- package meets naming guidelines
- package meets packaging guidelines
- license (GPL) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86_64)
- no unnecessary BR
- locales handled by %find_lang
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- .desktop file
Comment 4 Patrice Dumas 2006-03-21 21:56:53 UTC 
I didn't add a BR on shared-mime-info, because this is explicitely said here
that such BR shouldn't be added:

http://fedoraproject.org/wiki/ScriptletSnippets#head-ef39068afc1677de2e6b4370ad0fb24dafd4d47b
Comment 5 John Mahowald 2006-04-02 18:38:33 UTC 
(In reply to comment #4)
> I didn't add a BR on shared-mime-info, because this is explicitely said here
> that such BR shouldn't be added:
> 
>
http://fedoraproject.org/wiki/ScriptletSnippets#head-ef39068afc1677de2e6b4370ad0fb24dafd4d47b

OK.

And it did build and runs. APPROVED.
Comment 6 Patrice Dumas 2006-04-09 11:48:53 UTC 
Builds in devel, thanks for the review.
Note You need to log in before you can comment on or make changes to this bug.