Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 185266 - Review Request: perl-Text-CHM Perl extension for handling MS Compiled HtmlHelp Files
Summary: Review Request: perl-Text-CHM Perl extension for handling MS Compiled HtmlHel...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Paul Howarth
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-03-12 23:06 UTC by Patrice Dumas
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-03-31 20:26:48 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)

Description Patrice Dumas 2006-03-12 23:06:54 UTC 
SRPM Name or Url: http://www.environnement.ens.fr/perso/dumas/fc-srpms/perl-Text-CHM-0.01-1.src.rpm
Description:


Perl extension for handling MS Compiled HtmlHelp Files.
Comment 1 Paul Howarth 2006-03-29 14:32:41 UTC 
Review:

- rpmlint clean
- package and spec naming OK
- package meets guidelines
- license is same as perl, matches spec
- spec file written in English and is legible
- sources match upstream
- package builds OK on FC5 (i386) and in mock for rawhide (i386)
- BR's OK
- no locales, libraries, pkgconfigs, or subpackages to worry about
- not relocatable
- no directory ownership or permissions issues
- no duplicate files
- %clean section present and correct
- macro usage is consistent
- code, not content
- no large docs
- docs don't affect runtime
- no desktop file needed
- no scriptlets

Suggestions:

- use the DESCRIPTION section from the manpage for %description

Notes:

- the CPAN test results do not inspire confidence in this module
  (4 testers, 4 FAILs)
  http://cpantesters.perl.org/show/Text-CHM.html#Text-CHM-0.01

Approved.
Comment 2 Patrice Dumas 2006-03-31 20:26:48 UTC 
I changed the description based on the man page, thanks for the idea. The failed
test don't seem to be problematic to me as the build fails because chmlib.h
isn't found. It builds in devel.
Comment 3 Christian Iseli 2006-04-08 20:53:53 UTC 
Please add the package in owners.list
Comment 4 Patrice Dumas 2006-04-08 21:13:03 UTC 
done. Thanks
Note You need to log in before you can comment on or make changes to this bug.