Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 185824 - Review Request: perl-Date-Pcalc - Gregorian calendar date calculations
Summary: Review Request: perl-Date-Pcalc - Gregorian calendar date calculations
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Miloslav Trmač
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks: FE-ACCEPT 180015
TreeView+ depends on / blocked
 
Reported: 2006-03-18 20:54 UTC by Mike McGrath
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-03-20 16:59:06 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)

Description Mike McGrath 2006-03-18 20:54:10 UTC 
Spec: http://mmcgrath.net/~mmcgrath/perl-Date-Pcalc/perl-Date-Pcalc.spec
SRPM: http://mmcgrath.net/~mmcgrath/perl-Date-Pcalc/perl-Date-Pcalc-1.2-1.src.rpm
Description: 
This package consists of a Perl module for all kinds of date calculations based
on the Gregorian calendar (the one used in all western countries today), 
thereby complying with all relevant norms and standards: ISO/R 2015-1971, 
DIN 1355 and, to some extent, ISO 8601 (where applicable).
Comment 1 Miloslav Trmač 2006-03-19 02:57:48 UTC 
Looks good, only a few things:

- The tarball contains licence texts, so they must be packaged
- Please convert the man page from ISO-8859-1 to UTF-8:
W: perl-Date-Pcalc file-not-utf8 /usr/share/man/man3/Date::Pcalc.3pm.gz

- Consider packaging CREDITS.txt; README.txt refers to it and the authors deserve
  the credit.
Comment 2 Mike McGrath 2006-03-19 19:13:15 UTC 
Spec: http://mmcgrath.net/~mmcgrath/perl-Date-Pcalc/perl-Date-Pcalc.spec
SRMP: http://mmcgrath.net/~mmcgrath/perl-Date-Pcalc/perl-Date-Pcalc-1.2-2.src.rpm

%changelog
- Include license and credits
- Convert manpage to utf-8
Comment 3 Miloslav Trmač 2006-03-19 23:18:28 UTC 
Nitpicks:
- This comment is now obsolete:
  # For license text(s), see the perl package.
- It is not necessary to quote : as \: in shell commands

Approved.
Comment 4 Mike McGrath 2006-03-20 16:59:06 UTC 
Built in devel successfuly.
Note You need to log in before you can comment on or make changes to this bug.