Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1858603 (rust-simple_asn1) - Review Request: rust-simple_asn1 - Simple DER/ASN.1 encoding/decoding library
Summary: Review Request: rust-simple_asn1 - Simple DER/ASN.1 encoding/decoding library
Keywords:
Status: CLOSED RAWHIDE
Alias: rust-simple_asn1
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: IoT rust-rsa PARSEC
TreeView+ depends on / blocked
 
Reported: 2020-07-19 12:49 UTC by Peter Robinson
Modified: 2020-07-23 14:35 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-07-21 19:05:22 UTC
Type: Bug
Embargoed:
zebob.m: fedora-review+

Attachments (Terms of Use)

Description Peter Robinson 2020-07-19 12:49:57 UTC 
SPEC: https://pbrobinson.fedorapeople.org/rust-simple_asn1.spec
SRPM: https://pbrobinson.fedorapeople.org/rust-simple_asn1-0.4.1-1.fc32.src.rpm

Description:
Simple DER/ASN.1 encoding/decoding library

FAS: pbrobinson
Comment 1 Peter Robinson 2020-07-19 12:51:56 UTC 
koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=47380102
Comment 2 Robert-André Mauchin 🐧 2020-07-19 13:00:17 UTC 
 - You need to add a comment explaining what you modified in the metadata and refer to an upstream PR including that change:

# Initial patched metadata
# - Bump num-bigint to 0.3.0 + link to PR
# - Bump quickcheck to 0.9.2 + link to PR
Patch0:         simple_asn1-fix-metadata.diff

 - You must include the LICENSE file and should include the README.md:

%files          devel
%license LICENSE
%doc README.md
%{cargo_registry}/%{crate}-%{version_no_tilde}/


 - License ok
 - Latest version packaged
 - Builds in mock
 - No rpmlint errors
Comment 3 Peter Robinson 2020-07-19 13:29:17 UTC 
>  - You must include the LICENSE file and should include the README.md:

Why doesn't rust2rpm deal with this?
Comment 4 Robert-André Mauchin 🐧 2020-07-19 13:51:22 UTC 
(In reply to Peter Robinson from comment #3)
> >  - You must include the LICENSE file and should include the README.md:
> 
> Why doesn't rust2rpm deal with this?

rust2rpm depends on the crate metadata provided by the API: https://crates.io/api/v1/crates/num-bigint-dig
Some crates link to the README.md in their metadata, others not, and there is no metadata for specifying the license files. So it has to be done manually or detection for license files need to be coded in rust2rpm.
Comment 5 Peter Robinson 2020-07-21 10:30:09 UTC 
> and refer to an upstream PR including that change:

I will do upstream PRs when I get time, I have details logged, I don't have the time to do them ATM with other deadlines.
 
>  - You must include the LICENSE file and should include the README.md:

I've added the README but IMO it doesn't actually provide anything useful to a consumer of the package.

SPEC: https://pbrobinson.fedorapeople.org/rust-simple_asn1.spec
SRPM: https://pbrobinson.fedorapeople.org/rust-simple_asn1-0.4.1-2.fc32.src.rpm
Comment 6 Robert-André Mauchin 🐧 2020-07-21 17:28:27 UTC 
 - License ok
 - Latest version packaged
 - Builds in mock
 - No rpmlint errors
 - Conforms to Packaging Guidelines

Package approved.
Comment 7 Gwyn Ciesla 2020-07-21 18:47:37 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-simple_asn1
Note You need to log in before you can comment on or make changes to this bug.