Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at
Bug 1869376 - pkgconfig file uses /usr/local/ for variables.
Summary: pkgconfig file uses /usr/local/ for variables.
Alias: None
Product: Fedora
Classification: Fedora
Component: fish
Version: rawhide
Hardware: Unspecified
OS: Unspecified
Target Milestone: ---
Assignee: Oliver Falk
QA Contact: Fedora Extras Quality Assurance
Depends On:
TreeView+ depends on / blocked
Reported: 2020-08-17 18:23 UTC by Ankur Sinha (FranciscoD)
Modified: 2020-09-25 16:37 UTC (History)
4 users (show)

Fixed In Version: fish-3.1.2-5.fc33
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Last Closed: 2020-09-25 16:37:46 UTC
Type: Bug

Attachments (Terms of Use)

Description Ankur Sinha (FranciscoD) 2020-08-17 18:23:39 UTC
Description of problem:
The packageconfig file for fish uses /usr/local/ for a few variables

Version-Release number of selected component (if applicable):

How reproducible:

Steps to Reproduce:
1. Read the package config file at /usr/share/pkgconfig/fish.pc

Actual results:
Contents are:


Name: fish
Description: fish, the friendly interactive shell
Version: 3.1.2

Expected results:
Should use /usr/share everywhere, not /usr/local/share

Additional info:

Comment 1 Oliver Falk 2020-08-25 14:10:14 UTC

I've just pushed and built a new version to rawhide => fish-3.1.2-5.fc34

Can you please check?


Comment 2 Ankur Sinha (FranciscoD) 2020-08-26 20:42:15 UTC
Hi Oliver,

I'm afraid I don't have a rawhide system, so I cannot install the package to check the package config file. Could you please use one of the test systems to check the package?

(I *think* these are still usable, even with the data centre move ongoing).


Comment 3 Oliver Falk 2020-08-28 08:50:51 UTC

No need to check this explicitly on a Rawhide machine. A local rebuild my some other Fedora machine:

    # for i in prefix datadir completionsdir functionsdir confdir; do echo -n "$i: "; pkg-config --variable $i fish; done
    prefix: /usr
    datadir: /usr/share
    completionsdir: /usr/share/fish/vendor_completions.d
    functionsdir: /usr/share/fish/vendor_functions.d
    confdir: /usr/share/fish/vendor_conf.d

So, from my point of view, this is fixed. The question is if we should also move this fix to f32 and f31. I hope the primary maintainer can chime in on this.

Comment 4 Ankur Sinha (FranciscoD) 2020-08-28 09:19:31 UTC

I don't use fish, but I *think* those variables look correct now. The primary issue was the use of `/usr/local`, which isn't used any more.

I think it's worth pushing the update to F32 and F31 too, since other packages that use the fish package config variables otherwise need to workaround the bug separately in those branches.

Comment 5 Oliver Falk 2020-08-28 10:32:06 UTC
 what do you think. F32 + F31 as well for that?
If you don't have the bandwidth at the moment, let me know and I can handle it.


Comment 6 Oliver Falk 2020-08-28 10:39:17 UTC
Agreed with Igor, I'll take care about F31 + 32!


Comment 7 Oliver Falk 2020-08-28 13:25:24 UTC
Almost missed epel-8. :-\

Anyway. Fixed in:
- Rawhide
- F32
- F33
- EPEL-8

Builds are done or in progress. Therefore putting this on RELEASE_PENDING.

Comment 9 Fedora Update System 2020-08-28 14:36:12 UTC
FEDORA-2020-95b468e8a3 has been submitted as an update to Fedora 33.

Comment 11 Fedora Update System 2020-08-28 17:27:08 UTC
FEDORA-2020-95b468e8a3 has been pushed to the Fedora 33 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-95b468e8a3`
You can provide feedback for this update here:

See also for more information on how to test updates.

Comment 12 Fedora Update System 2020-09-25 16:37:46 UTC
FEDORA-2020-95b468e8a3 has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.

Note You need to log in before you can comment on or make changes to this bug.