COPR builds: https://copr.fedorainfracloud.org/coprs/andymenderunix/metrics2mqtt-and-dependencies/build/1650400/

I see that metrics2mqtt internally requires python3-jsons, but the requirement is not specified. Won't this lead to a non-functional/broken package? Since metrics2mqtt has no tests, there is no safeguard against it.

I think the following should be added to the SPEC file:
BuildRequires:  python3dist(jsons)

The rest of the review:

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- Package installs properly.
  Note: Installation errors (see attachment)
  See: https://docs.fedoraproject.org/en-US/packaging-guidelines/
  Review: builds properly in Koji and COPR, though.


===== MUST items =====

Generic:
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
     Note: Using prebuilt packages
     Review: It's a noarch package.
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Expat License", "Unknown or generated". 12 files have unknown
     license. Detailed output of licensecheck in
     /home/amender/rpmbuild/SPECS/metrics2mqtt/copr-build-1650400/review-
     metrics2mqtt/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[?]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[!]: Requires correct, justified where necessary.
     Review: Possible missing Requires on python-jsons?
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 20480 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[x]: Reviewer should test that the package builds in mock.
     Review: Builds in Koji and COPR.
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
     Review: Possible missing Requires on python-jsons?
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     python3-metrics2mqtt
     Review: Not sure whether it's necessary.
[ ]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
     Review: It's a noarch package.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[!]: Rpmlint is run on all installed packages.
     Note: Mock build failed
     See: https://docs.fedoraproject.org/en-US/packaging-
     guidelines/#_use_rpmlint
[x]: Spec file according to URL is the same as in SRPM.


Installation errors
-------------------
INFO: mock.py version 2.4 starting (python version = 3.8.5)...
Start: init plugins
INFO: selinux enabled
Finish: init plugins
INFO: Signal handler active
Start: run
Start: chroot init
INFO: calling preinit hooks
INFO: enabled root cache
INFO: enabled package manager cache
Start: cleaning package manager metadata
Finish: cleaning package manager metadata
INFO: enabled HW Info plugin
Mock Version: 2.4
INFO: Mock Version: 2.4
Finish: chroot init
INFO: installing package(s): /home/amender/rpmbuild/SPECS/metrics2mqtt/copr-build-1650400/python3-metrics2mqtt-0.1.18-1.fc34.noarch.rpm /home/amender/rpmbuild/SPECS/metrics2mqtt/copr-build-1650400/metrics2mqtt-0.1.18-1.fc34.noarch.rpm
ERROR: Command failed: 
 # /usr/bin/dnf --installroot /var/lib/mock/fedora-rawhide-x86_64/root/ --releasever 34 --setopt=deltarpm=False --allowerasing --disableplugin=local --disableplugin=spacewalk install /home/amender/rpmbuild/SPECS/metrics2mqtt/copr-build-1650400/python3-metrics2mqtt-0.1.18-1.fc34.noarch.rpm /home/amender/rpmbuild/SPECS/metrics2mqtt/copr-build-1650400/metrics2mqtt-0.1.18-1.fc34.noarch.rpm --setopt=tsflags=nocontexts



Rpmlint
-------
Checking: metrics2mqtt-0.1.18-1.fc34.noarch.rpm
          python3-metrics2mqtt-0.1.18-1.fc34.noarch.rpm
          metrics2mqtt-0.1.18-1.fc34.src.rpm
metrics2mqtt.noarch: W: spelling-error %description -l en_US psutil -> pistil
metrics2mqtt.noarch: W: no-documentation
metrics2mqtt.noarch: W: no-manual-page-for-binary metrics2mqtt
python3-metrics2mqtt.noarch: W: spelling-error %description -l en_US psutil -> pistil
metrics2mqtt.src: W: spelling-error %description -l en_US psutil -> pistil
3 packages and 0 specfiles checked; 0 errors, 5 warnings.




Source checksums
----------------
https://github.com/jamiebegin/metrics2mqtt/archive/v0.1.18/metrics2mqtt-0.1.18.tar.gz :
  CHECKSUM(SHA256) this package     : 321f6d9885996b817be9d11d72dd04b36d352308457669261f4ff6bb437a6641
  CHECKSUM(SHA256) upstream package : 321f6d9885996b817be9d11d72dd04b36d352308457669261f4ff6bb437a6641


Requires
--------
metrics2mqtt (rpmlib, GLIBC filtered):
    /usr/bin/python3
    python3-metrics2mqtt

python3-metrics2mqtt (rpmlib, GLIBC filtered):
    python(abi)
    python3.9dist(jsons)
    python3.9dist(numpy)
    python3.9dist(paho-mqtt)
    python3.9dist(psutil)
    python3.9dist(setuptools)



Provides
--------
metrics2mqtt:
    metrics2mqtt

python3-metrics2mqtt:
    python-metrics2mqtt
    python3-metrics2mqtt
    python3.9-metrics2mqtt
    python3.9dist(metrics2mqtt)
    python3dist(metrics2mqtt)

(In reply to Andy Mender from comment #1)
> COPR builds:
> https://copr.fedorainfracloud.org/coprs/andymenderunix/metrics2mqtt-and-
> dependencies/build/1650400/
> 
> I see that metrics2mqtt internally requires python3-jsons, but the
> requirement is not specified. Won't this lead to a non-functional/broken
> package? Since metrics2mqtt has no tests, there is no safeguard against it.
> 
> I think the following should be added to the SPEC file:
> BuildRequires:  python3dist(jsons)

It's a run-time dependency and not a a requirement for the build (as there are no tests). The dependency generator is picking-up jsons and the other modules which are required to run:

> python3-metrics2mqtt (rpmlib, GLIBC filtered):
>     python(abi)
>     python3.9dist(jsons)
>     python3.9dist(numpy)
>     python3.9dist(paho-mqtt)
>     python3.9dist(psutil)
>     python3.9dist(setuptools)
>

> It's a run-time dependency and not a a requirement for the build (as there are no tests). The dependency generator is picking-up jsons and the other modules which are required to run:
> 
> > python3-metrics2mqtt (rpmlib, GLIBC filtered):
> >     python(abi)
> >     python3.9dist(jsons)
> >     python3.9dist(numpy)
> >     python3.9dist(paho-mqtt)
> >     python3.9dist(psutil)
> >     python3.9dist(setuptools)
> >

Yes, you are completely right, apologies!

Package approved!

(In reply to Andy Mender from comment #3)
> Yes, you are completely right, apologies!

No apologies needed for being thorough.

Thanks for the review and your support.

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/metrics2mqtt

FEDORA-2020-7f210246bc has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-7f210246bc

FEDORA-2020-7f210246bc has been pushed to the Fedora 33 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-7f210246bc \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-7f210246bc

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2020-7f210246bc has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.