Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1877882 - Review Request: python-xiaomi-gateway - Python library to communicate with the Xiaomi Gateway
Summary: Review Request: python-xiaomi-gateway - Python library to communicate with th...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: IoT
TreeView+ depends on / blocked
 
Reported: 2020-09-10 16:22 UTC by Fabian Affolter
Modified: 2020-09-25 16:58 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-09-25 16:58:08 UTC
Type: ---
Embargoed:
zebob.m: fedora-review+

Attachments (Terms of Use)

Description Fabian Affolter 2020-09-10 16:22:37 UTC 
Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-xiaomi-gateway.spec
SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/python-xiaomi-gateway-0.13.2-1.fc32.src.rpm

Project URL: https://github.com/Danielhiversen/PyXiaomiGateway/

Description:
A Python library to communicate with the Xiaomi Gateway.

Koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=51150370

rpmlint output:
$ rpmlint python-xiaomi-gateway-0.13.2-1.fc32.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

$ rpmlint python3-xiaomi-gateway-0.13.2-1.fc32.noarch.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

Fedora Account System Username: fab
Comment 1 Robert-André Mauchin 🐧 2020-09-10 22:04:47 UTC 
 - No network %bcond_with and a device one not used? Are you sure this isn't a mistake?

%bcond_with device

%if %{with network}

 - Latest version packaged
 - License ok
 - Builds in mock
 - No rpmlint errors
 - Conforms to Packaging Guidelines

Package approved.
Comment 2 Fabian Affolter 2020-09-11 07:48:58 UTC 
(In reply to Robert-André Mauchin 🐧 from comment #1)
>  - No network %bcond_with and a device one not used? Are you sure this isn't
> a mistake?
> 
> %bcond_with device
> 
> %if %{with network}

That's a mistake. I will fix it. Thanks for the review.
Comment 3 Gwyn Ciesla 2020-09-11 14:34:01 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-xiaomi-gateway
Comment 4 Fedora Update System 2020-09-14 18:30:34 UTC 
FEDORA-2020-16f7a11578 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-16f7a11578
Comment 5 Fedora Update System 2020-09-15 14:53:30 UTC 
FEDORA-2020-16f7a11578 has been pushed to the Fedora 33 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-16f7a11578 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-16f7a11578

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
Comment 6 Fedora Update System 2020-09-25 16:58:08 UTC 
FEDORA-2020-16f7a11578 has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.
Note You need to log in before you can comment on or make changes to this bug.