Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1880701 - Review Request: python-hangups - Python instant messaging client for Hangouts
Summary: Review Request: python-hangups - Python instant messaging client for Hangouts
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Andy Mender
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1880694 1880695 1880697
Blocks: FE-DEADREVIEW IoT
TreeView+ depends on / blocked
 
Reported: 2020-09-19 04:18 UTC by Fabian Affolter
Modified: 2021-03-17 00:45 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-03-17 00:45:49 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Fabian Affolter 2020-09-19 04:18:29 UTC
Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-hangups.spec
SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/python-hangups-0.4.11-1.fc32.src.rpm

Project URL: https://github.com/tdryer/hangups

Description:
hangups is a instant messaging client for Hangouts. It includes both a Python
library and a reference client with a text-based user interface.

Koji scratch build:
later when the deps are available and the release pinning is sorted out with upstream

rpmlint output:
$ rpmlint python-hangups-0.4.11-1.fc32.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

$ rpmlint python3-hangups-0.4.11-1.fc32.noarch.rpm 
python3-hangups.noarch: W: no-manual-page-for-binary hangups
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

Fedora Account System Username: fab

Comment 1 Andy Mender 2020-09-19 21:01:05 UTC
I'm going to review this one and the dependencies, and add them to the python IoT COPR project: https://copr.fedorainfracloud.org/coprs/andymenderunix/python-iot/packages/

Comment 2 Andy Mender 2020-09-20 10:22:45 UTC
All of the dependencies have been reviewed.

> BuildRequires:  (python3dist(protobuf) >= 3.1 with python3dist(protobuf) < 3.12)

This fails on Fedora 33 and 34 (Rawhide), because the version in both is already 3.12.6. Also, Fedora 32 ships python-protobuf 3.11.2:
Available Packages
Name         : python3-protobuf
Version      : 3.11.2
Release      : 2.fc32
Architecture : noarch
Size         : 590 k
Source       : protobuf-3.11.2-2.fc32.src.rpm
Repository   : fedora
Summary      : Python 3 bindings for Google Protocol Buffers
URL          : https://github.com/protocolbuffers/protobuf
License      : BSD
Description  : This package contains Python 3 libraries for Google Protocol Buffers

I would recommend the following if possible:
> BuildRequires:  python3dist(protobuf)

Then, the build succeeds: https://copr.fedorainfracloud.org/coprs/andymenderunix/python-iot/build/1678713/

However, this output from fedora-review worries me a bit (see the protobuf version restrictions):
> Requires
> --------
> python3-hangups (rpmlib, GLIBC filtered):
>     (python3.9dist(aiohttp) < 4 with python3.9dist(aiohttp) >= 3.3)
>     (python3.9dist(appdirs) < 1.5 with python3.9dist(appdirs) >= 1.4)
>     (python3.9dist(async-timeout) < 4 with python3.9dist(async-timeout) >= 2)
>     (python3.9dist(protobuf) < 3.12 with python3.9dist(protobuf) >= 3.1)
>     (python3.9dist(requests) < 3 with python3.9dist(requests) >= 2.6)
>     /usr/bin/python3
>     python(abi)
>     python3.9dist(configargparse)
>     python3.9dist(mechanicalsoup)
>     python3.9dist(readlike)
>     python3.9dist(reparser)
>     python3.9dist(setuptools)
>     python3.9dist(urwid)


I reviewed the fixed version. Everything looks okay. However, before I approve this, please have a look at the situation with protobuf to make sure that python-hangups really is compatible with python-protobuf >= 3.12.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- Package installs properly.
  Note: Installation errors (see attachment)
  See: https://docs.fedoraproject.org/en-US/packaging-guidelines/
- Package must not depend on deprecated() packages.
  Note: python3-pytest4 is deprecated, you must not depend on it.
  See: https://docs.fedoraproject.org/en-US/packaging-
  guidelines/deprecating-packages/


===== MUST items =====

Generic:
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
     Note: Using prebuilt packages
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Expat License", "Unknown or generated". 34 files have unknown
     license. Detailed output of licensecheck in
     /home/amender/rpmbuild/SPECS/python-hangups/copr-build-1678713/review-
     python-hangups/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[x]: Reviewer should test that the package builds in mock.
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: Mock build failed
     See: https://docs.fedoraproject.org/en-US/packaging-
     guidelines/#_use_rpmlint
[x]: Spec file according to URL is the same as in SRPM.


Installation errors
-------------------
INFO: mock.py version 2.6 starting (python version = 3.8.5)...
Start: init plugins
INFO: selinux enabled
Finish: init plugins
INFO: Signal handler active
Start: run
Start: chroot init
INFO: calling preinit hooks
INFO: enabled root cache
INFO: enabled package manager cache
Start: cleaning package manager metadata
Finish: cleaning package manager metadata
INFO: enabled HW Info plugin
Mock Version: 2.6
INFO: Mock Version: 2.6
Finish: chroot init
INFO: installing package(s): /home/amender/rpmbuild/SPECS/python-hangups/copr-build-1678713/python3-hangups-0.4.11-1.fc34.noarch.rpm
ERROR: Command failed: 
 # /usr/bin/dnf --installroot /var/lib/mock/fedora-rawhide-x86_64/root/ --releasever 34 --setopt=deltarpm=False --allowerasing --disableplugin=local --disableplugin=spacewalk install /home/amender/rpmbuild/SPECS/python-hangups/copr-build-1678713/python3-hangups-0.4.11-1.fc34.noarch.rpm --setopt=tsflags=nocontexts



Rpmlint
-------
Checking: python3-hangups-0.4.11-1.fc34.noarch.rpm
          python-hangups-0.4.11-1.fc34.src.rpm
python3-hangups.noarch: W: no-manual-page-for-binary hangups
2 packages and 0 specfiles checked; 0 errors, 1 warnings.




Source checksums
----------------
https://files.pythonhosted.org/packages/source/h/hangups/hangups-0.4.11.tar.gz :
  CHECKSUM(SHA256) this package     : db530cd7352c3fef4513bce38f07d19b79180b3aefed71afd9f369bab7cab498
  CHECKSUM(SHA256) upstream package : db530cd7352c3fef4513bce38f07d19b79180b3aefed71afd9f369bab7cab498


Requires
--------
python3-hangups (rpmlib, GLIBC filtered):
    (python3.9dist(aiohttp) < 4 with python3.9dist(aiohttp) >= 3.3)
    (python3.9dist(appdirs) < 1.5 with python3.9dist(appdirs) >= 1.4)
    (python3.9dist(async-timeout) < 4 with python3.9dist(async-timeout) >= 2)
    (python3.9dist(protobuf) < 3.12 with python3.9dist(protobuf) >= 3.1)
    (python3.9dist(requests) < 3 with python3.9dist(requests) >= 2.6)
    /usr/bin/python3
    python(abi)
    python3.9dist(configargparse)
    python3.9dist(mechanicalsoup)
    python3.9dist(readlike)
    python3.9dist(reparser)
    python3.9dist(setuptools)
    python3.9dist(urwid)



Provides
--------
python3-hangups:
    python-hangups
    python3-hangups
    python3.9-hangups
    python3.9dist(hangups)
    python3dist(hangups)

Comment 3 Andy Mender 2021-02-14 09:07:28 UTC
Any updates on this ticket perhaps? :)

Comment 4 Package Review 2021-03-17 00:45:49 UTC
This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.


Note You need to log in before you can comment on or make changes to this bug.