Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 188204 - Review Request: crystal-stacker - Falling blocks, match 3 or more of the same color crystals
Summary: Review Request: crystal-stacker - Falling blocks, match 3 or more of the same...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Wart
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-04-06 22:29 UTC by Hans de Goede
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-04-09 07:44:21 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)

Description Hans de Goede 2006-04-06 22:29:43 UTC 
Spec Name or Url: http://home.zonnet.nl/jwrdegoede/crystal-stacker.spec
SRPM Name or Url: http://home.zonnet.nl/jwrdegoede/crystal-stacker-1.5-0.pre.1.src.rpm
Description:
If you've played Columns then you know what Crystal Stacker is all about. Match
3 or more of the same color crystals either horizontally, vertically, or dia-
gonally to destroy them. For every 45 crystals you destroy, the level increases
and the crystals fall faster. The higher the level, the more points you are
awarded for destroying crystals.
Comment 1 Hans de Goede 2006-04-07 09:36:41 UTC 
New version which doesn't pause the music when selecting a new theme (not needed
under Unix because we use threads):
Spec Name or Url: http://home.zonnet.nl/jwrdegoede/crystal-stacker.spec
SRPM Name or Url:
http://home.zonnet.nl/jwrdegoede/crystal-stacker-1.5-0.pre.2.src.rpm
Comment 2 Wart 2006-04-07 21:33:57 UTC 
The theme editor fails to run.  It opens up a dialog that says "Editor not
installed correctly"
Comment 3 Hans de Goede 2006-04-08 06:18:02 UTC 
Thats strange it works fine over here, can you do a strace on it for me?
Comment 4 Hans de Goede 2006-04-08 06:25:34 UTC 
Hmm, I really can't find anything that explains this, can you see if:
/usr/share/crystal-stacker/ce.dat is in place? It is in the specfile so it
should be.
Comment 5 Wart 2006-04-08 15:49:37 UTC 
This file is in place, but it's not the file that the theme editor is looking
for.  strace shows that it's looking for this file in the original
RPM_BUILD_ROOT location:

stat64("/var/tmp/crystal-stacker-1.5-0.pre.2-root-wart/usr/share/crystal-stacker/ce.dat",
0xbfe08650) = -1 ENOENT (No such file or directory)
Comment 6 Hans de Goede 2006-04-08 17:34:38 UTC 
Hmm,

That is most likely because the C-file involved got compiled (again) during make
install where PREFIX is set to $RPM_BUILD_ROOT%{_prefix} so I smell a time skew
problem here, are you using a network filesystem or maybe a filesystem with low
res timestamps or running some kinda time sync software?

Anyways try a rebuild that should fix it.
Comment 7 Wart 2006-04-08 21:51:20 UTC 
Yep, the clock in my build machine was behind by several days.  Once I reset it
then the packages were fine.  Here's the full review:

MUST
====

* rpmlint output clean
* spec file named appropriately
* source matches upstream
  d961dfdc859267b2763f4b585a732f3e  cs15src.zip
* License (freeware) ok, license file included, license change discussion
  (to remove non-commercial use clause) included and ok.
* No excessive BR:
* Compiles, builds, and runs on FC-5 i386
* No locales
* No shared libraries
* No -devel package
* No libtool archives
* .desktop file included and installed correctly
* Scriptlets are sane
* Owns directories that it creates
* Contains code and acceptable content

APPROVED
Comment 8 Hans de Goede 2006-04-09 07:44:21 UTC 
Thanks, imported and build.
Note You need to log in before you can comment on or make changes to this bug.