Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 188946 - Review Request: contacts
Summary: Review Request: contacts
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: David Cantrell
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-04-13 20:27 UTC by David Nielsen
Modified: 2013-01-10 01:23 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-04-27 03:10:25 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
SPEC file (deleted)
2006-04-13 21:36 UTC, David Nielsen
no flags Details

Description David Nielsen 2006-04-13 20:27:47 UTC
Spec URL: http://www.lovesunix.net/contacts.spec
SRPM URL: http://www.lovesunix.net/contact-0.1-1.src.rpm
Description: Contacts is a tiny standalone application to view contact data available via evolution-data-server

Be gentle, this is my first venture into SPEC authoring

Comment 1 Jesse Keating 2006-04-13 21:17:03 UTC
So, a few things going on here in the spec that should be looked at:

- Source url should not use macros
- PreReq seems a bit odd, why the Pre and the regular Req?
- Use of defines at the top seems a bit much.  Why define it to use it in only
one place? (one place if you don't hard specify Requires)
- Hard specified Requires, rpm should be able to figure this out on its own
- Graphical app but no .desktop file
- Files section is referencing directories rather than files within directories.

Other than that its a good start (;

Comment 2 Jesse Keating 2006-04-13 21:23:47 UTC
Whoops, macro in Source url is fine.

Comment 3 David Nielsen 2006-04-13 21:33:59 UTC
I fixed the obvious stuff, thank you for the review.

Comment 4 David Nielsen 2006-04-13 21:36:13 UTC
Created attachment 127729 [details]
SPEC file

Comment 5 Brian Pepple 2006-04-13 22:59:38 UTC
The desktop file needs to have some bits changed specific for Fedora.  You need
to add this to the %install section:

desktop-file-install --vendor fedora --delete-original	\
  --dir $RPM_BUILD_ROOT%{_datadir}/applications   	\
  --add-category X-Fedora			        \
  $RPM_BUILD_ROOT%{_datadir}/applications/%{name}.desktop

And in the %files section the desktop file needs to be:
%{_datadir}/applications/fedora-%{name}.desktop

Comment 6 Brian Pepple 2006-04-13 23:06:27 UTC
David, is the link to your spec file valid?

Comment 7 Brian Pepple 2006-04-13 23:14:46 UTC
Whoops, forgot to mention in comment #5, that you can drop the BuildRequires for
glib2-devel and gtk2-devel,since the libglade2-devel package will pull these in.

Comment 8 David Nielsen 2006-04-13 23:31:46 UTC
Thank you for the review Brian.. yes the link is valid.

I updated the spec file to include the changes you suggested and uploaded new
versions.

Comment 9 Jesse Keating 2006-04-14 03:46:22 UTC
Now you need desktop-file-utils as a BuildRequires since you'll be using it in
the %install section.  I added that in a local copy of your spec and used that
to build packages.  Rpmlint output coming up.



Comment 10 Jesse Keating 2006-04-14 04:46:44 UTC
rpmlint is silent, no problems.  So fix the BuildRequires and I think we're in
business.  I just have to lookup how to sponsor you.

Comment 11 Josh Boyer 2006-04-14 10:55:26 UTC
(In reply to comment #10)
> rpmlint is silent, no problems.  So fix the BuildRequires and I think we're in
> business.  I just have to lookup how to sponsor you.

You don't have sponsor permissions.  The list of sponsors is here:

https://admin.fedora.redhat.com/accounts/dump-group.cgi?group=cvsextras&role_type=sponsor&format=html

I'm willing to sponsor this though.

Comment 12 David Nielsen 2006-04-14 15:15:06 UTC
Updated.. hopefully this is the final go at this untill Chris releases 0.2 :)

Comment 13 Jesse Keating 2006-04-17 20:40:49 UTC
I have the fu to sponsor now, so David you'll need to go through the steps at
http://fedoraproject.org/wiki/Extras/Contributors to create your account so I
can sponsor it.

Also, the srpm you list isn't reachable, I did tests by using the upstream
tarball w/ your spec.  For prosperity you might want to resolve that.

Comment 14 David Nielsen 2006-04-17 20:59:23 UTC
My webhost seems to have been down for a brief period. sorry about that.

I'm having an issue with the user system, it has gotten in a state where on one
hand it doesn't know a user registered to david, yet claims that
one is already registered to that addy when I try to register again. 

Could someone please look at that?

Comment 15 Jesse Keating 2006-04-27 03:10:25 UTC
David isn't as interested in maintaining this anymore, so I've gone ahead and
pushed it through.  It should wind up in extras-development soon.

Comment 16 Paul Howarth 2006-04-27 11:42:29 UTC
(In reply to comment #15)
> David isn't as interested in maintaining this anymore, so I've gone ahead and
> pushed it through.  It should wind up in extras-development soon.

I see from owners.list that you've taken over ownership of this package yourself
(which is good). Reading the above, it could be interpreted as pushing through
an already-orphaned package (which wouldn't have been good).


Note You need to log in before you can comment on or make changes to this bug.