Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 189250 - Review Request: python-lxml - ElementTree-like python bindings for libxml2
Summary: Review Request: python-lxml - ElementTree-like python bindings for libxml2
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Paul Nasrat
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-04-18 15:45 UTC by Shahms E. King
Modified: 2007-11-30 22:11 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-04-28 16:47:59 UTC
Type: ---
Embargoed:
kevin: fedora-cvs+

Attachments (Terms of Use)

Description Shahms E. King 2006-04-18 15:45:32 UTC 
Spec URL: http://shahms.mesd.k12.or.us/packages/python-lxml.spec
SRPM URL: http://shahms.mesd.k12.or.us/packages/python-lxml-0.9.1-1.src.rpm
Description: 
lxml provides a Python binding to the libxslt and libxml2 libraries.  It follows
the ElementTree API as much as possible in order to provide a more Pythonic
interface to libxml2 and libxslt than the default bindings.  In particular,
lxml deals with Python Unicode strings rather than encoded UTF-8 and handles
memory management, unlike the default bindings.
Comment 1 Paul Nasrat 2006-04-25 22:16:22 UTC 
rpmlint fails (warning and error):

rpmlint python-lxml-0.9.1-1.src.rpm
W: python-lxml summary-ended-with-dot ElementTree-like Python bindings for
libxml2 and libxslt.
E: python-lxml description-line-too-long lxml provides a Python binding to the
libxslt and libxml2 libraries.  It follows

Can you fix those up and we'll start again.
Comment 2 Shahms E. King 2006-04-26 14:20:01 UTC 
Fixed. The new files are at:
http://shahms.mesd.k12.or.us/packages/python-lxml.spec
http://shahms.mesd.k12.or.us/packages/python-lxml-0.9.1-2.src.rpm
Comment 3 Paul Nasrat 2006-04-26 17:25:50 UTC 
Thanks for that.  Two suggestions but otherwise looking good to me.

Please add a BuildRequires python-setuptools as mock build fails without this.
Suggest use of dist tag - but not necessary for acceptance

Review:
* built on fc5 - tested in v
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written, uses macros consistently and
conforms to the python template.
* license field matches the actual license.
* license is open source-compatible and included
* source files match upstream:
25e18d86050907f3a088550fe650f841  lxml-0.9.1.tgz
25e18d86050907f3a088550fe650f841  /home/pauln/tmp/lxml-0.9.1.tgz
* rpmlint is silent.
* BuildRequires sane, although not sufficient for mock.
* final provides and requires are sane.
* no shared libraries are present.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* %clean is present.
* %check is not present
* package contains code, not content.
* documentation is relatively small , so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no pkgconfig files.
* no libtool .la files
* not a GUI app so no .desktop
Comment 4 Shahms E. King 2006-04-26 17:46:26 UTC 
Thanks for reviewing the package.  I could have sworn I'd added both the dist
tag and BuildRequires, but that's why we have reviewers ;-).

I've made the suggested changes and put up new files at:
http://shahms.mesd.k12.or.us/packages/python-lxml.spec
http://shahms.mesd.k12.or.us/packages/python-lxml-0.9.1-3.src.rpm
Comment 5 Paul Nasrat 2006-04-26 18:30:55 UTC 
Thanks - builds and runs. Meets review criteria, moving to FE-ACCEPT

>>> import lxml.etree
>>> doc = lxml.etree.parse('example-tutorial-en.xml')
>>> e = doc.xpath('//article[@id="example-tutorial"]')
>>> e
[<Element article at -480fd9e4>

Review as above:
* built on fc5 - tested working
* package meets naming and packaging guidelines. Uses dist tag.
* specfile is properly named, is cleanly written, uses macros consistently and
conforms to the python template.
* license field matches the actual license.
* license is open source-compatible and included
* source files match upstream:
25e18d86050907f3a088550fe650f841  lxml-0.9.1.tgz
25e18d86050907f3a088550fe650f841  /home/pauln/tmp/lxml-0.9.1.tgz
* BuildRequires are proper.
* builds in mock
* rpmlint is silent.
* final provides and requires are sane.
* no shared libraries are present.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* %clean is present.
* %check is not present
* package contains code, not content.
* documentation is relatively small , so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no pkgconfig files.
* no libtool .la files
* not a GUI app so no .desktop
Comment 6 Shahms E. King 2007-07-30 19:45:36 UTC 
Package Change Request
======================
Package Name: python-lxml
Updated Fedora Owners: shahms,jeff
Comment 7 Jason Tibbitts 2007-07-30 20:05:06 UTC 
ACK is in bug 245690.

CVS done.
Comment 8 Jeffrey C. Ollie 2007-07-31 11:27:41 UTC 
Package Change Request
======================
Package Name: python-lxml
New Branches: EL-4 EL-5
Updated EPEL Owners: jeff
Comment 9 Jeffrey C. Ollie 2007-08-01 18:51:35 UTC 
Oops, forget to set the CVS flag...

Package Change Request
======================
Package Name: python-lxml
New Branches: EL-4 EL-5
Updated EPEL Owners: jeff
Comment 10 Kevin Fenzi 2007-08-01 19:07:43 UTC 
cvs done.
Note You need to log in before you can comment on or make changes to this bug.