Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1897277 - Rename Review Request: deepin-qt5platform-plugins - Qt platform integration plugins for Deepin Desktop Environment
Summary: Rename Review Request: deepin-qt5platform-plugins - Qt platform integration p...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Qiyu Yan
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: DeepinDEPackageReview
TreeView+ depends on / blocked
 
Reported: 2020-11-12 16:59 UTC by Robin Lee
Modified: 2020-12-01 10:43 UTC (History)
2 users (show)

Fixed In Version: deepin-qt5platform-plugins-5.0.21-3.fc34
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-12-01 10:43:32 UTC
Type: ---
Embargoed:
yanqiyu01: fedora-review+

Attachments (Terms of Use)

Description Robin Lee 2020-11-12 16:59:29 UTC 
Spec URL: https://download.copr.fedorainfracloud.org/results/cheeselee/deepin-packit-testing/fedora-rawhide-x86_64/01767107-deepin-qt5platform-plugins/deepin-qt5platform-plugins.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/cheeselee/deepin-packit-testing/fedora-rawhide-x86_64/01767107-deepin-qt5platform-plugins/deepin-qt5platform-plugins-5.0.21-1.fc34.src.rpm
Description: qt5platform-plugins is the Qt platform integration plugin for Deepin Desktop Environment.
Fedora Account System Username: cheeselee

This review is for renaming of the package deepin-qt5platform-plugins.
Comment 1 Qiyu Yan 2020-11-13 11:01:00 UTC 
- consider exclude /usr/lib64/qt5/plugins/platforms/libdxcb.so from auto provides?

===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[-]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "GNU General Public License v3.0 or
     later", "GNU Lesser General Public License, Version 3 GNU General
     Public License, Version 2", "NTP License (legal disclaimer)", "*No
     copyright* GNU General Public License v3.0 or later". 47 files have
     unknown license. Detailed output of licensecheck in
     2 files licensed with MIT, whole program is GPL, no matter
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 40960 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: deepin-qt5platform-plugins-5.0.21-1.fc34.x86_64.rpm
          deepin-qt5platform-plugins-debuginfo-5.0.21-1.fc34.x86_64.rpm
          deepin-qt5platform-plugins-debugsource-5.0.21-1.fc34.x86_64.rpm
          deepin-qt5platform-plugins-5.0.21-1.fc34.src.rpm
4 packages and 0 specfiles checked; 0 errors, 0 warnings.




Rpmlint (debuginfo)
-------------------
Checking: deepin-qt5platform-plugins-debuginfo-5.0.21-1.fc34.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.





Rpmlint (installed packages)
----------------------------
deepin-qt5platform-plugins-debuginfo.x86_64: W: invalid-url URL: https://github.com/linuxdeepin/qt5platform-plugins <urlopen error [Errno -3] Temporary failure in name resolution>
deepin-qt5platform-plugins-debugsource.x86_64: W: invalid-url URL: https://github.com/linuxdeepin/qt5platform-plugins <urlopen error [Errno -3] Temporary failure in name resolution>
deepin-qt5platform-plugins.x86_64: W: invalid-url URL: https://github.com/linuxdeepin/qt5platform-plugins <urlopen error [Errno -3] Temporary failure in name resolution>
3 packages and 0 specfiles checked; 0 errors, 3 warnings.



Unversioned so-files
--------------------
deepin-qt5platform-plugins: /usr/lib64/qt5/plugins/platforms/libdxcb.so

Source checksums
----------------
https://github.com/linuxdeepin/qt5platform-plugins/archive/5.0.21/qt5platform-plugins-5.0.21.tar.gz :
  CHECKSUM(SHA256) this package     : 86e32cc660f12fc93d8fe7aa9af6466fe93a943959f60dacce70ca876348aa39
  CHECKSUM(SHA256) upstream package : 86e32cc660f12fc93d8fe7aa9af6466fe93a943959f60dacce70ca876348aa39


Requires
--------
deepin-qt5platform-plugins (rpmlib, GLIBC filtered):
    ld-linux-x86-64.so.2()(64bit)
    libQt5Core.so.5()(64bit)
    libQt5Core.so.5(Qt_5)(64bit)
    libQt5Core.so.5(Qt_5.15)(64bit)
    libQt5Core.so.5(Qt_5.15.1_PRIVATE_API)(64bit)
    libQt5Gui.so.5()(64bit)
    libQt5Gui.so.5(Qt_5)(64bit)
    libQt5Gui.so.5(Qt_5.15.1_PRIVATE_API)(64bit)
    libQt5Widgets.so.5()(64bit)
    libQt5Widgets.so.5(Qt_5)(64bit)
    libQt5X11Extras.so.5()(64bit)
    libQt5X11Extras.so.5(Qt_5)(64bit)
    libQt5XcbQpa.so.5()(64bit)
    libQt5XcbQpa.so.5(Qt_5.15.1_PRIVATE_API)(64bit)
    libX11.so.6()(64bit)
    libXi.so.6()(64bit)
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgcc_s.so.1(GCC_3.3.1)(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.7)(64bit)
    libstdc++.so.6(CXXABI_1.3.8)(64bit)
    libxcb-composite.so.0()(64bit)
    libxcb-damage.so.0()(64bit)
    libxcb-icccm.so.4()(64bit)
    libxcb-image.so.0()(64bit)
    libxcb-render-util.so.0()(64bit)
    libxcb-render.so.0()(64bit)
    libxcb-shape.so.0()(64bit)
    libxcb-xfixes.so.0()(64bit)
    libxcb.so.1()(64bit)
    qt5-qtbase(x86-64)
    rtld(GNU_HASH)

deepin-qt5platform-plugins-debuginfo (rpmlib, GLIBC filtered):

deepin-qt5platform-plugins-debugsource (rpmlib, GLIBC filtered):



Provides
--------
deepin-qt5platform-plugins:
    deepin-qt5dxcb-plugin
    deepin-qt5platform-plugins
    deepin-qt5platform-plugins(x86-64)
    libdxcb.so()(64bit)

deepin-qt5platform-plugins-debuginfo:
    debuginfo(build-id)
    deepin-qt5platform-plugins-debuginfo
    deepin-qt5platform-plugins-debuginfo(x86-64)

deepin-qt5platform-plugins-debugsource:
    deepin-qt5platform-plugins-debugsource
    deepin-qt5platform-plugins-debugsource(x86-64)



Generated by fedora-review 0.7.5 (5fa5b7e) last change: 2020-02-16
Command line :/usr/bin/fedora-review -b 1897277
Buildroot used: fedora-rawhide-x86_64
Active plugins: C/C++, Shell-api, Generic
Disabled plugins: Java, SugarActivity, Ocaml, PHP, Haskell, fonts, Python, R, Perl
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Comment 2 Robin Lee 2020-11-14 02:38:52 UTC 
Change:
- Filter private so from Provides

Spec URL: https://download.copr.fedorainfracloud.org/results/cheeselee/deepin-packit-testing/fedora-rawhide-x86_64/01768857-deepin-qt5platform-plugins/deepin-qt5platform-plugins.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/cheeselee/deepin-packit-testing/fedora-rawhide-x86_64/01768857-deepin-qt5platform-plugins/deepin-qt5platform-plugins-5.0.21-2.fc34.src.rpm

(In reply to Qiyu Yan from comment #1)
> - consider exclude /usr/lib64/qt5/plugins/platforms/libdxcb.so from auto
> provides?
Done
Comment 3 Qiyu Yan 2020-11-14 13:49:12 UTC 
I think this package is ready.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
     Verified and excluded from provides
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "GNU General Public License v3.0 or
     later", "GNU Lesser General Public License, Version 3 GNU General
     Public License, Version 2", "NTP License (legal disclaimer)", "*No
     copyright* GNU General Public License v3.0 or later". 47 files have
     unknown license. Detailed output of licensecheck in
     /home/yan/review/1897277-deepin-qt5platform-plugins/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 40960 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: Reviewer should test that the package builds in mock.
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: No rpmlint messages.
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: deepin-qt5platform-plugins-5.0.21-2.fc34.x86_64.rpm
          deepin-qt5platform-plugins-debuginfo-5.0.21-2.fc34.x86_64.rpm
          deepin-qt5platform-plugins-debugsource-5.0.21-2.fc34.x86_64.rpm
          deepin-qt5platform-plugins-5.0.21-2.fc34.src.rpm
4 packages and 0 specfiles checked; 0 errors, 0 warnings.




Rpmlint (debuginfo)
-------------------
Checking: deepin-qt5platform-plugins-debuginfo-5.0.21-2.fc34.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.





Rpmlint (installed packages)
----------------------------
3 packages and 0 specfiles checked; 0 errors, 0 warnings.



Unversioned so-files
--------------------
deepin-qt5platform-plugins: /usr/lib64/qt5/plugins/platforms/libdxcb.so

Source checksums
----------------
https://github.com/linuxdeepin/qt5platform-plugins/archive/5.0.21/qt5platform-plugins-5.0.21.tar.gz :
  CHECKSUM(SHA256) this package     : 86e32cc660f12fc93d8fe7aa9af6466fe93a943959f60dacce70ca876348aa39
  CHECKSUM(SHA256) upstream package : 86e32cc660f12fc93d8fe7aa9af6466fe93a943959f60dacce70ca876348aa39


Requires
--------
deepin-qt5platform-plugins (rpmlib, GLIBC filtered):
    ld-linux-x86-64.so.2()(64bit)
    libQt5Core.so.5()(64bit)
    libQt5Core.so.5(Qt_5)(64bit)
    libQt5Core.so.5(Qt_5.15)(64bit)
    libQt5Core.so.5(Qt_5.15.1_PRIVATE_API)(64bit)
    libQt5Gui.so.5()(64bit)
    libQt5Gui.so.5(Qt_5)(64bit)
    libQt5Gui.so.5(Qt_5.15.1_PRIVATE_API)(64bit)
    libQt5Widgets.so.5()(64bit)
    libQt5Widgets.so.5(Qt_5)(64bit)
    libQt5X11Extras.so.5()(64bit)
    libQt5X11Extras.so.5(Qt_5)(64bit)
    libQt5XcbQpa.so.5()(64bit)
    libQt5XcbQpa.so.5(Qt_5.15.1_PRIVATE_API)(64bit)
    libX11.so.6()(64bit)
    libXi.so.6()(64bit)
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgcc_s.so.1(GCC_3.3.1)(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.7)(64bit)
    libstdc++.so.6(CXXABI_1.3.8)(64bit)
    libxcb-composite.so.0()(64bit)
    libxcb-damage.so.0()(64bit)
    libxcb-icccm.so.4()(64bit)
    libxcb-image.so.0()(64bit)
    libxcb-render-util.so.0()(64bit)
    libxcb-render.so.0()(64bit)
    libxcb-shape.so.0()(64bit)
    libxcb-xfixes.so.0()(64bit)
    libxcb.so.1()(64bit)
    qt5-qtbase(x86-64)
    rtld(GNU_HASH)

deepin-qt5platform-plugins-debuginfo (rpmlib, GLIBC filtered):

deepin-qt5platform-plugins-debugsource (rpmlib, GLIBC filtered):



Provides
--------
deepin-qt5platform-plugins:
    deepin-qt5dxcb-plugin
    deepin-qt5platform-plugins
    deepin-qt5platform-plugins(x86-64)

deepin-qt5platform-plugins-debuginfo:
    debuginfo(build-id)
    deepin-qt5platform-plugins-debuginfo
    deepin-qt5platform-plugins-debuginfo(x86-64)

deepin-qt5platform-plugins-debugsource:
    deepin-qt5platform-plugins-debugsource
    deepin-qt5platform-plugins-debugsource(x86-64)



Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10
Command line :/usr/bin/fedora-review -b 1897277 --no-build
Buildroot used: fedora-rawhide-x86_64
Active plugins: Shell-api, Generic, C/C++
Disabled plugins: SugarActivity, Ocaml, Perl, Java, PHP, Haskell, fonts, R, Python
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Comment 4 Gwyn Ciesla 2020-11-16 14:31:11 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/deepin-qt5platform-plugins
Note You need to log in before you can comment on or make changes to this bug.