I will take this review.

This package is APPROVED.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

Issues:
=======
- Package installs properly.
  Note: Installation errors (see attachment)
  See: https://docs.fedoraproject.org/en-US/packaging-guidelines/


===== MUST items =====

Generic:
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
     must be documented in the spec.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: Reviewer should test that the package builds in mock.
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[!]: Rpmlint is run on all installed packages.
     Note: Mock build failed
     See: https://docs.fedoraproject.org/en-US/packaging-
     guidelines/#_use_rpmlint
[x]: Spec file according to URL is the same as in SRPM.


Installation errors
-------------------
INFO: mock.py version 2.6 starting (python version = 3.9.0)...
Start: init plugins
INFO: selinux enabled
Finish: init plugins
INFO: Signal handler active
Start: run
Start: chroot init
INFO: calling preinit hooks
INFO: enabled root cache
INFO: enabled package manager cache
Start: cleaning package manager metadata
Finish: cleaning package manager metadata
INFO: enabled HW Info plugin
Mock Version: 2.6
INFO: Mock Version: 2.6
Finish: chroot init
INFO: installing package(s): /home/jamesjer/copr-build-1769086/rust-aes-gcm-devel-0.8.0-1.fc34.noarch.rpm /home/jamesjer/copr-build-1769086/rust-aes-gcm+zeroize-devel-0.8.0-1.fc34.noarch.rpm /home/jamesjer/copr-build-1769086/rust-aes-gcm+aes-devel-0.8.0-1.fc34.noarch.rpm /home/jamesjer/copr-build-1769086/rust-aes-gcm+alloc-devel-0.8.0-1.fc34.noarch.rpm /home/jamesjer/copr-build-1769086/rust-aes-gcm+default-devel-0.8.0-1.fc34.noarch.rpm /home/jamesjer/copr-build-1769086/rust-aes-gcm+std-devel-0.8.0-1.fc34.noarch.rpm
ERROR: Command failed: 
 # /usr/bin/dnf --installroot /var/lib/mock/fedora-rawhide-x86_64/root/ --releasever 34 --setopt=deltarpm=False --allowerasing --disableplugin=local --disableplugin=spacewalk install /home/jamesjer/copr-build-1769086/rust-aes-gcm-devel-0.8.0-1.fc34.noarch.rpm /home/jamesjer/copr-build-1769086/rust-aes-gcm+zeroize-devel-0.8.0-1.fc34.noarch.rpm /home/jamesjer/copr-build-1769086/rust-aes-gcm+aes-devel-0.8.0-1.fc34.noarch.rpm /home/jamesjer/copr-build-1769086/rust-aes-gcm+alloc-devel-0.8.0-1.fc34.noarch.rpm /home/jamesjer/copr-build-1769086/rust-aes-gcm+default-devel-0.8.0-1.fc34.noarch.rpm /home/jamesjer/copr-build-1769086/rust-aes-gcm+std-devel-0.8.0-1.fc34.noarch.rpm --setopt=tsflags=nocontexts



Rpmlint
-------
Checking: rust-aes-gcm-devel-0.8.0-1.fc34.noarch.rpm
          rust-aes-gcm+default-devel-0.8.0-1.fc34.noarch.rpm
          rust-aes-gcm+aes-devel-0.8.0-1.fc34.noarch.rpm
          rust-aes-gcm+alloc-devel-0.8.0-1.fc34.noarch.rpm
          rust-aes-gcm+std-devel-0.8.0-1.fc34.noarch.rpm
          rust-aes-gcm+zeroize-devel-0.8.0-1.fc34.noarch.rpm
          rust-aes-gcm-0.8.0-1.fc34.src.rpm
rust-aes-gcm-devel.noarch: W: invalid-url URL: https://crates.io/crates/aes-gcm HTTP Error 404: Not Found
rust-aes-gcm-devel.noarch: W: hidden-file-or-dir /usr/share/cargo/registry/aes-gcm-0.8.0/.cargo-checksum.json
rust-aes-gcm+default-devel.noarch: W: spelling-error %description -l en_US gcm -> gm, cm, gem
rust-aes-gcm+default-devel.noarch: W: invalid-url URL: https://crates.io/crates/aes-gcm HTTP Error 404: Not Found
rust-aes-gcm+default-devel.noarch: W: no-documentation
rust-aes-gcm+aes-devel.noarch: W: spelling-error %description -l en_US gcm -> gm, cm, gem
rust-aes-gcm+aes-devel.noarch: W: invalid-url URL: https://crates.io/crates/aes-gcm HTTP Error 404: Not Found
rust-aes-gcm+aes-devel.noarch: W: no-documentation
rust-aes-gcm+alloc-devel.noarch: W: spelling-error %description -l en_US alloc -> allot, alloy, allow
rust-aes-gcm+alloc-devel.noarch: W: spelling-error %description -l en_US gcm -> gm, cm, gem
rust-aes-gcm+alloc-devel.noarch: W: invalid-url URL: https://crates.io/crates/aes-gcm HTTP Error 404: Not Found
rust-aes-gcm+alloc-devel.noarch: W: no-documentation
rust-aes-gcm+std-devel.noarch: W: spelling-error %description -l en_US gcm -> gm, cm, gem
rust-aes-gcm+std-devel.noarch: W: invalid-url URL: https://crates.io/crates/aes-gcm HTTP Error 404: Not Found
rust-aes-gcm+std-devel.noarch: W: no-documentation
rust-aes-gcm+zeroize-devel.noarch: W: spelling-error %description -l en_US zeroize -> terrorize, zero
rust-aes-gcm+zeroize-devel.noarch: W: spelling-error %description -l en_US gcm -> gm, cm, gem
rust-aes-gcm+zeroize-devel.noarch: W: invalid-url URL: https://crates.io/crates/aes-gcm HTTP Error 404: Not Found
rust-aes-gcm+zeroize-devel.noarch: W: no-documentation
rust-aes-gcm.src: W: invalid-url URL: https://crates.io/crates/aes-gcm HTTP Error 404: Not Found
7 packages and 0 specfiles checked; 0 errors, 20 warnings.




Source checksums
----------------
https://crates.io/api/v1/crates/aes-gcm/0.8.0/download#/aes-gcm-0.8.0.crate :
  CHECKSUM(SHA256) this package     : 5278b5fabbb9bd46e24aa69b2fdea62c99088e0a950a9be40e3e0101298f88da
  CHECKSUM(SHA256) upstream package : 5278b5fabbb9bd46e24aa69b2fdea62c99088e0a950a9be40e3e0101298f88da


Requires
--------
rust-aes-gcm-devel (rpmlib, GLIBC filtered):
    (crate(aead) >= 0.3.0 with crate(aead) < 0.4.0)
    (crate(cipher/default) >= 0.2.0 with crate(cipher/default) < 0.3.0)
    (crate(ctr/default) >= 0.6.0 with crate(ctr/default) < 0.7.0)
    (crate(ghash) >= 0.3.0 with crate(ghash) < 0.4.0)
    (crate(subtle) >= 2.0.0 with crate(subtle) < 3.0.0)
    cargo

rust-aes-gcm+default-devel (rpmlib, GLIBC filtered):
    (crate(aes/default) >= 0.6.0 with crate(aes/default) < 0.7.0)
    cargo
    crate(aes-gcm)
    crate(aes-gcm/alloc)

rust-aes-gcm+aes-devel (rpmlib, GLIBC filtered):
    (crate(aes/default) >= 0.6.0 with crate(aes/default) < 0.7.0)
    cargo
    crate(aes-gcm)

rust-aes-gcm+alloc-devel (rpmlib, GLIBC filtered):
    (crate(aead/alloc) >= 0.3.0 with crate(aead/alloc) < 0.4.0)
    cargo
    crate(aes-gcm)

rust-aes-gcm+std-devel (rpmlib, GLIBC filtered):
    (crate(aead/std) >= 0.3.0 with crate(aead/std) < 0.4.0)
    cargo
    crate(aes-gcm)
    crate(aes-gcm/alloc)

rust-aes-gcm+zeroize-devel (rpmlib, GLIBC filtered):
    (crate(zeroize) >= 1.0.0 with crate(zeroize) < 2.0.0)
    cargo
    crate(aes-gcm)



Provides
--------
rust-aes-gcm-devel:
    crate(aes-gcm)
    rust-aes-gcm-devel

rust-aes-gcm+default-devel:
    crate(aes-gcm/default)
    rust-aes-gcm+default-devel

rust-aes-gcm+aes-devel:
    crate(aes-gcm/aes)
    rust-aes-gcm+aes-devel

rust-aes-gcm+alloc-devel:
    crate(aes-gcm/alloc)
    rust-aes-gcm+alloc-devel

rust-aes-gcm+std-devel:
    crate(aes-gcm/std)
    rust-aes-gcm+std-devel

rust-aes-gcm+zeroize-devel:
    crate(aes-gcm/zeroize)
    rust-aes-gcm+zeroize-devel



Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10
Command line :/usr/bin/fedora-review --copr-build https://copr.fedorainfracloud.org/coprs/decathorpe/RustCrypto-updates/build/1769086/ -m fedora-rawhide-x86_64
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api
Disabled plugins: Perl, Java, Ocaml, Ruby, SugarActivity, R, C/C++, PHP, Python, Haskell, fonts
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH

Thanks for the two reviews! Once the repos are created I'll build the 14 necessary packages in a side tag and will also make sure they're all installable :-)

https://pagure.io/releng/fedora-scm-requests/issue/31070

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-aes-gcm

FEDORA-2020-0fe6c978c5 has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.