Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1902166 - bashrc sets hardcoded umask
Summary: bashrc sets hardcoded umask
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: setup
Version: 36
Hardware: Unspecified
OS: Unspecified
unspecified
low
Target Milestone: ---
Assignee: Martin Osvald 🛹
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 1940375 (view as bug list)
Depends On:
Blocks: 2062601
TreeView+ depends on / blocked
 
Reported: 2020-11-27 07:45 UTC by Pavel Zhukov
Modified: 2022-11-24 10:30 UTC (History)
11 users (show)

Fixed In Version: setup-2.14.1-1.fc36 setup-2.14.1-1.fc35
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-07-26 16:13:33 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)

Description Pavel Zhukov 2020-11-27 07:45:01 UTC 
Description of problem:
Hardcoded umask has been removed from /etc/profile in 102b349c39e196cc1e34e645c9310acdab7afeef but bashrc sets same values for non-login shells. 
Opening this bug to check if it's still OK or should be changed to use login.defs too to avoid possible regressions
Comment 1 Ben Cotton 2021-02-09 16:20:53 UTC 
This bug appears to have been reported against 'rawhide' during the Fedora 34 development cycle.
Changing version to 34.
Comment 2 Matthew Miller 2021-11-25 20:26:07 UTC 
There's a related conversation here https://ask.fedoraproject.org/t/default-umask-value/18648



The current configuration does seem pretty arbitrary to me, especially the distinction between login and non-login shells.


I note that there's a lot of back-and-forth history in the changelog (see for example #217523). Personal opinion: that shared-login-server filesystem-permissions-based-collaboration use case is a pretty rare one these days, and systems where that's still important can explicitly configure for that if needed. 


And I also note that the check there for UID > 199 is ... maybe a decade obsolete?


Let's just take this out? Less code is better, right? :)
Comment 3 Pavel Zhukov 2022-01-18 11:22:33 UTC 
*** Bug 1940375 has been marked as a duplicate of this bug. ***
Comment 4 Zbigniew Jędrzejewski-Szmek 2022-01-18 11:32:32 UTC 
I'm copying over a comment from the other bug so this doesn't get lost:
> please change /etc/bashrc to only touch umask if it is 000, and leave the existing setting otherwise.
Comment 5 Ben Cotton 2022-02-08 21:07:03 UTC 
This bug appears to have been reported against 'rawhide' during the Fedora 36 development cycle.
Changing version to 36.
Comment 6 Etienne URBAH 2022-05-13 14:01:43 UTC 
This bug is still present in package setup 2.13.10-1.fc36

Workarounds :

If you are sudoer, inside '/etc/bashrc', you can replace  'umask 002'  by  'true   # umask 002 now managed by pam_umask'

If you are not sudoer, you can add following lines at the end of ~/.bashrc :
UMASK="$(grep  -o  "^$USER:.*,umask=0[0-7]*"  /etc/passwd)"
if  [ "$UMASK" ];  then
  umask  "${UMASK#$USER:*,umask=}"
fi
Comment 7 Martin Osvald 🛹 2022-06-12 15:22:27 UTC 
Would this be an acceptable solution for the parties involved?

https://pagure.io/setup/pull-request/36
https://pagure.io/fork/mosvald/setup/c/206d4afccaec7b20caafa79d6b005ec681e2551b
Comment 8 Kamil Dudka 2022-06-13 07:33:39 UTC 
Works for me.  Thanks!
Comment 9 Fedora Update System 2022-07-20 08:32:32 UTC 
FEDORA-2022-984296572a has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-984296572a
Comment 10 Fedora Update System 2022-07-21 22:45:28 UTC 
FEDORA-2022-4b663b23a9 has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-4b663b23a9`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-4b663b23a9

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
Comment 11 Fedora Update System 2022-07-21 23:05:02 UTC 
FEDORA-2022-984296572a has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-984296572a`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-984296572a

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
Comment 12 Fedora Update System 2022-07-26 16:13:33 UTC 
FEDORA-2022-984296572a has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.
Comment 13 Fedora Update System 2022-08-05 02:35:39 UTC 
FEDORA-2022-4b663b23a9 has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.
Note You need to log in before you can comment on or make changes to this bug.