Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1902397 - Review Request: rust-dummy - Macros implementation of #[derive(Dummy)]
Summary: Review Request: rust-dummy - Macros implementation of #[derive(Dummy)]
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Olivier Lemasle
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1892930
TreeView+ depends on / blocked
 
Reported: 2020-11-28 13:22 UTC by Fabio Valentini
Modified: 2021-01-12 18:21 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-01-12 18:21:31 UTC
Type: ---
Embargoed:
o.lemasle: fedora-review+

Attachments (Terms of Use)

Description Fabio Valentini 2020-11-28 13:22:09 UTC 
Spec URL: https://decathorpe.fedorapeople.org/packages/rust-dummy.spec
SRPM URL: https://decathorpe.fedorapeople.org/packages/rust-dummy-0.3.3-1.fc33.src.rpm

Description:
Macros implementation of #[derive(Dummy)].

Fedora Account System Username: decathorpe

koji scratch build for rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=56360393
Comment 1 Olivier Lemasle 2021-01-11 22:20:46 UTC 
It does not build in mock:

     Running `/usr/bin/rustc --crate-name dummy --edition=2018 src/lib.rs --error-format=json --json=diagnostic-rendered-ansi --crate-type proc-macro --emit=dep-info,link -C prefer-dynamic -C opt-level=3 -C embed-bitcode=no -C metadata=34e7f9c5fb098e3e -C extra-filename=-34e7f9c5fb098e3e --out-dir /builddir/build/BUILD/dummy-0.3.3/target/release/deps -L dependency=/builddir/build/BUILD/dummy-0.3.3/target/release/deps --extern darling=/builddir/build/BUILD/dummy-0.3.3/target/release/deps/libdarling-991f04f44011cefa.rlib --extern quote=/builddir/build/BUILD/dummy-0.3.3/target/release/deps/libquote-9b517b766eaaf53c.rlib --extern syn=/builddir/build/BUILD/dummy-0.3.3/target/release/deps/libsyn-6eb5363a317fe24a.rlib --extern proc_macro -Copt-level=3 -Cdebuginfo=2 -Clink-arg=-Wl,-z,relro,-z,now -Ccodegen-units=1 --cap-lints=warn`
error: pattern requires `..` due to inaccessible fields
  --> src/lib.rs:51:36
   |
51 |           darling::ast::Data::Struct(darling::ast::Fields {
   |  ____________________________________^
52 | |             ref fields,
53 | |             ref style,
54 | |         }) => match style {
   | |_________^
   |
help: ignore the inaccessible and unused fields
   |
53 |             ref style, ..,
   |                      ^^^^
error: aborting due to previous error
error: could not compile `dummy`


However, it seems it work with latest upstream release (0.4.0).
Comment 2 Fabio Valentini 2021-01-12 10:16:58 UTC 
Oh ... I think this might be caused by having a version of darling in fedora that was pulled by upstream :(
I'll look into updating to 0.4.0.
Comment 3 Fabio Valentini 2021-01-12 10:23:53 UTC 
Spec URL: https://decathorpe.fedorapeople.org/packages/rust-dummy.spec
SRPM URL: https://decathorpe.fedorapeople.org/packages/rust-dummy-0.4.0-1.fc33.src.rpm

You were right. 0.4.0 compiles successfully.
Comment 4 Olivier Lemasle 2021-01-12 10:55:55 UTC 
Package accepted.

- License ok
- Spec generated by rust2rpm; only variation is related to additional %license.
- Latest upstream is packaged
- Guidelines and naming conventions ok
- Builds in mock

Rpmlint
-------
Checking: rust-dummy-devel-0.4.0-1.fc34.noarch.rpm
          rust-dummy+default-devel-0.4.0-1.fc34.noarch.rpm
          rust-dummy-0.4.0-1.fc34.src.rpm
rust-dummy-devel.noarch: W: invalid-url URL: https://crates.io/crates/dummy HTTP Error 404: Not Found
rust-dummy-devel.noarch: W: hidden-file-or-dir /usr/share/cargo/registry/dummy-0.4.0/.cargo-checksum.json
rust-dummy+default-devel.noarch: W: invalid-url URL: https://crates.io/crates/dummy HTTP Error 404: Not Found
rust-dummy+default-devel.noarch: W: no-documentation
rust-dummy.src: W: invalid-url URL: https://crates.io/crates/dummy HTTP Error 404: Not Found
3 packages and 0 specfiles checked; 0 errors, 5 warnings.
Comment 5 Fabio Valentini 2021-01-12 11:30:52 UTC 
Thank you for the review! :)
https://pagure.io/releng/fedora-scm-requests/issue/31714

I'll look at one or two of your pending Rust packages in turn.
Comment 6 Gwyn Ciesla 2021-01-12 14:17:36 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-dummy
Comment 7 Fabio Valentini 2021-01-12 18:21:31 UTC 
Built for rawhide:
https://koji.fedoraproject.org/koji/buildinfo?buildID=1668461
Note You need to log in before you can comment on or make changes to this bug.