Spec sanity:

> %{?python_provide:%python_provide python3-%{pypi_name}}

If you only target F33+, you can drop it. If you also target F32, please use https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_the_py_provides_macro instead.



> %description -n python3-%{pypi_name}
> ${summary}

That seems like a typo (note the $).



> %{python3_sitelib}/%{pypi_name}
> %{python3_sitelib}/%{pypi_name}-%{version}-py%{python3_version}.egg-info

I recommend adding training slashes to indicate and assert those are directories.


Running Fedora Review.

Doesn't build, needs to BR python3-pytest-runner:

+ /usr/bin/python3 setup.py build '--executable=/usr/bin/python3 -s'
...
Traceback (most recent call last):
  File "/builddir/build/BUILD/stone-3.2.1/setup.py", line 39, in <module>
    dist = setup(
  File "/usr/lib/python3.9/site-packages/setuptools/__init__.py", line 152, in setup
    _install_setup_requires(attrs)
  File "/usr/lib/python3.9/site-packages/setuptools/__init__.py", line 147, in _install_setup_requires
    dist.fetch_build_eggs(dist.setup_requires)
  File "/usr/lib/python3.9/site-packages/setuptools/dist.py", line 673, in fetch_build_eggs
    resolved_dists = pkg_resources.working_set.resolve(
  File "/usr/lib/python3.9/site-packages/pkg_resources/__init__.py", line 764, in resolve
    dist = best[req.key] = env.best_match(
  File "/usr/lib/python3.9/site-packages/pkg_resources/__init__.py", line 1049, in best_match
    return self.obtain(req, installer)
  File "/usr/lib/python3.9/site-packages/pkg_resources/__init__.py", line 1061, in obtain
    return installer(requirement)
  File "/usr/lib/python3.9/site-packages/setuptools/dist.py", line 732, in fetch_build_egg
    return fetch_build_egg(self, req)
  File "/usr/lib/python3.9/site-packages/setuptools/installer.py", line 68, in fetch_build_egg
    return _legacy_fetch_build_egg(dist, req)
  File "/usr/lib/python3.9/site-packages/setuptools/installer.py", line 51, in _legacy_fetch_build_egg
    return cmd.easy_install(req)
  File "/usr/lib/python3.9/site-packages/setuptools/command/easy_install.py", line 663, in easy_install
    raise DistutilsError(msg)
distutils.errors.DistutilsError: Could not find suitable distribution for Requirement.parse('pytest-runner')

Thanks. Addressed the above.

SRPM: https://fedorapeople.org/~limb/review/python-stone/python-stone-3.2.1-2.fc33.src.rpm
SPEC: https://fedorapeople.org/~limb/review/python-stone/python-stone.spec

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


Package APPROVED.

Since you are already pulling in pytest-runner, consider running the tests in %check.
However, it seems the tests require pytest < 5, so maybe this is not a good idea?



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Expat License", "Unknown or generated", "*No copyright* Expat
     License".
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[-]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[?]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[?]: Package should compile and build into binary rpms on all supported
     architectures.
[!]: %check is present and all tests pass.
[?]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: python3-stone-3.2.1-2.fc34.noarch.rpm
          python-stone-3.2.1-2.fc34.src.rpm
python3-stone.noarch: E: zero-length /usr/lib/python3.9/site-packages/stone/py.typed

That is OK.

python3-stone.noarch: W: no-manual-page-for-binary stone

That is OK.

2 packages and 0 specfiles checked; 1 errors, 1 warnings.




Rpmlint (installed packages)
----------------------------
python3-stone.noarch: E: zero-length /usr/lib/python3.9/site-packages/stone/py.typed
python3-stone.noarch: W: no-manual-page-for-binary stone
1 packages and 0 specfiles checked; 1 errors, 1 warnings.



Source checksums
----------------
https://files.pythonhosted.org/packages/source/s/stone/stone-3.2.1.tar.gz :
  CHECKSUM(SHA256) this package     : 9bc78b40143b4ef33bf569e515408c2996ffebefbb1a897616ebe8aa6f2d7e75
  CHECKSUM(SHA256) upstream package : 9bc78b40143b4ef33bf569e515408c2996ffebefbb1a897616ebe8aa6f2d7e75


Requires
--------
python3-stone (rpmlib, GLIBC filtered):
    /usr/bin/python3
    python(abi)
    python3.9dist(ply)
    python3.9dist(setuptools)
    python3.9dist(six)



Provides
--------
python3-stone:
    python-stone
    python3-stone
    python3.9-stone
    python3.9dist(stone)
    python3dist(stone)

I agree WRT the tests. Thanks!

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-stone