Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1907238 - Review Request: openexr - Provides the specification and reference implementation of the EXR file format
Summary: Review Request: openexr - Provides the specification and reference implementa...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Zbigniew Jędrzejewski-Szmek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-12-13 21:38 UTC by Richard Shaw
Modified: 2021-07-04 14:50 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-01-02 18:04:05 UTC
Type: ---
Embargoed:
zbyszek: fedora-review+


Attachments (Terms of Use)

Description Richard Shaw 2020-12-13 21:38:35 UTC
Spec URL: https://hobbes1069.fedorapeople.org/openexr.spec
SRPM URL: https://hobbes1069.fedorapeople.org/openexr-2.5.3-1.fc33.src.rpm

Description:
OpenEXR is a project of the [Academy Software Foundation](https://www.aswf.io).
The format and library were originally developed by Industrial Light & Magic
and first released in 2003.  Weta Digital, Walt Disney Animation Studios, Sony
Pictures Imageworks, Pixar Animation Studios, DreamWorks, and other studios,
companies, and individuals have made contributions to the code base.

This package containes the binaries for OpenEXR.

Fedora Account System Username: hobbes1069

Comment 1 Richard Shaw 2020-12-13 21:38:37 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=57378822

Comment 2 Richard Shaw 2020-12-13 21:44:57 UTC
NOTE: Obsoletes will be updated to meet packaging guidelines prior to building based on current NEVR of OpenEXR and ilmbase.

Comment 3 Zbigniew Jędrzejewski-Szmek 2020-12-14 09:16:03 UTC
> Description:
> OpenEXR is a project of the [Academy Software
> Foundation](https://www.aswf.io).
> The format and library were originally developed by Industrial Light & Magic
> and first released in 2003.  Weta Digital, Walt Disney Animation Studios,
> Sony
> Pictures Imageworks, Pixar Animation Studios, DreamWorks, and other studios,
> companies, and individuals have made contributions to the code base.

Description + Summary don't actually say what this package and the format are *for*
(images, video, something else?). Not everybody knows what "EXR" means. Also,
I think the blurb about authors is not interesting for users.

Comment 4 Zbigniew Jędrzejewski-Szmek 2020-12-14 10:04:57 UTC
> BuildRequires:  cmake gcc gcc-c++
One-per-line is preferred nowadays.

> %{_bindir}/*
Maybe '%{_bindir}/exr*' ? This will make it less likely to something unintended to slip in on upgrades.

rpmlint:
openexr.src: W: spelling-error %description -l en_US containes -> contained, contains, containers

> # Is it OK to dump the libraries in site-packages?
It means that the modules 'iex' and 'imath' will be importable in the global namespace.
It's certainly allowed in general. I think the name is a bit generic in this case, but
it's not something we have influence over.

+ license is acceptable for Fedora (BSD 3 clause)
+ license is specified correctly
+ builds and installs OK
+ BR and Requires look correct
+ Provides and Obsoletes look correct took

Package is APPROVED.

Comment 5 Richard Shaw 2020-12-14 13:11:14 UTC
(In reply to Zbigniew Jędrzejewski-Szmek from comment #3)
> > Description:
> > OpenEXR is a project of the [Academy Software
> > Foundation](https://www.aswf.io).
> > The format and library were originally developed by Industrial Light & Magic
> > and first released in 2003.  Weta Digital, Walt Disney Animation Studios,
> > Sony
> > Pictures Imageworks, Pixar Animation Studios, DreamWorks, and other studios,
> > companies, and individuals have made contributions to the code base.
> 
> Description + Summary don't actually say what this package and the format
> are *for*
> (images, video, something else?). Not everybody knows what "EXR" means. Also,
> I think the blurb about authors is not interesting for users.

Yeah, I copied that and a lot more from the README. I may borrow from the current OpenEXR package.


> > %{_bindir}/*
> Maybe '%{_bindir}/exr*' ? This will make it less likely to something
> unintended to slip in on upgrades.
> 
> rpmlint:
> openexr.src: W: spelling-error %description -l en_US containes -> contained,
> contains, containers

Since I copied it straight from their readme I guess I should let them know :)


> > # Is it OK to dump the libraries in site-packages?
> It means that the modules 'iex' and 'imath' will be importable in the global
> namespace.
> It's certainly allowed in general. I think the name is a bit generic in this
> case, but
> it's not something we have influence over.

Most dedicated python packages that I maintain put them in a named subdirectory but yeah, I looked in my system and there's lots of packages that dump them right in site-packages.


> + license is acceptable for Fedora (BSD 3 clause)
> + license is specified correctly
> + builds and installs OK
> + BR and Requires look correct
> + Provides and Obsoletes look correct took
> 
> Package is APPROVED.

Thanks!

Comment 6 Gwyn Ciesla 2020-12-14 14:20:36 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/openexr

Comment 7 Fedora Update System 2021-01-02 18:04:05 UTC
FEDORA-2021-6229d3d205 has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 8 Josef Ridky 2021-01-04 08:17:52 UTC
Is there any difference between your package and https://src.fedoraproject.org/rpms/OpenEXR, which is in Fedora for 3+ years? (and not counting, this version has newer NVR)

Comment 9 Josef Ridky 2021-01-04 08:31:27 UTC
Please, ignore my previous comment, I've just hit the origin message on fedora devel list. All good now.

Comment 10 Tom Hughes 2021-07-04 10:34:07 UTC
I'm not sure why Josef retracted his comment because it this does indeed appear to be a duplicate of the existing OpenEXR package and even if it wasn't the same software packages whose names differ only in case are not allowed:

https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names

If the intention was to retire OpenEXR in favour of this then that does not appear to have happened as both are still live currently:

https://src.fedoraproject.org/rpms/OpenEXR
https://src.fedoraproject.org/rpms/openexr

Comment 11 Richard Shaw 2021-07-04 11:31:31 UTC
Yes, OpenEXR should be retired.

Comment 12 Josef Ridky 2021-07-04 11:40:14 UTC
Well, it's true, that OpenEXR package for Fedora Rawhide (maybe even Fedora 34) should follow this guideline https://fedoraproject.org/wiki/How_to_remove_a_package_at_end_of_life so it's clear, such package is removed from distribution. But otherwise, the update from OpenEXR to openexr is clear and all provides/obsolete and other references are correctly set.


Note You need to log in before you can comment on or make changes to this bug.