Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1907435 - python-holidays fails to build with Python 3.10: TypeError: cannot unpack non-iterable float object
Summary: python-holidays fails to build with Python 3.10: TypeError: cannot unpack non...
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: python-holidays
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Orphan Owner
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: PYTHON3.10
TreeView+ depends on / blocked
 
Reported: 2020-12-14 14:05 UTC by Tomáš Hrnčiar
Modified: 2021-06-17 23:05 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-06-17 23:05:56 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Tomáš Hrnčiar 2020-12-14 14:05:48 UTC
python-holidays fails to build with Python 3.10.0a3.

=================================== FAILURES ===================================
_______________________ TestIsrael.test_independence_day _______________________

self = <tests.TestIsrael testMethod=test_independence_day>

    def test_independence_day(self):
>       self._test_observed_holidays('Independence Day')

tests.py:6119: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
tests.py:6125: in _test_observed_holidays
    il_holidays = holidays.IL(years=[2017], observed=True)
holidays/countries/israel.py:25: in __init__
    HolidayBase.__init__(self, **kwargs)
holidays/holiday_base.py:34: in __init__
    self._populate(year)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = {}, year = 2017

    def _populate(self, year):
        is_leap_year = hebrew.leap(year + hebrew.HEBREW_YEAR_OFFSET)
    
        # Passover
        name = "Passover I"
>       year, month, day = hebrew.to_jd_gregorianyear(year, hebrew.NISAN, 14)
E       TypeError: cannot unpack non-iterable float object

holidays/countries/israel.py:32: TypeError
_________________________ TestIsrael.test_memorial_day _________________________

self = <tests.TestIsrael testMethod=test_memorial_day>

    def test_memorial_day(self):
>       self._test_observed_holidays('Memorial Day')

tests.py:6116: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
tests.py:6125: in _test_observed_holidays
    il_holidays = holidays.IL(years=[2017], observed=True)
holidays/countries/israel.py:25: in __init__
    HolidayBase.__init__(self, **kwargs)
holidays/holiday_base.py:34: in __init__
    self._populate(year)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = {}, year = 2017

    def _populate(self, year):
        is_leap_year = hebrew.leap(year + hebrew.HEBREW_YEAR_OFFSET)
    
        # Passover
        name = "Passover I"
>       year, month, day = hebrew.to_jd_gregorianyear(year, hebrew.NISAN, 14)
E       TypeError: cannot unpack non-iterable float object

holidays/countries/israel.py:32: TypeError
=============================== warnings summary ===============================
tests.py: 24 warnings
  /builddir/build/BUILD/python-holidays-0.10.4/holidays/utils.py: Islamic Holidays estimated using 'convertdate' package.

tests.py: 24 warnings
  /builddir/build/BUILD/python-holidays-0.10.4/holidays/utils.py: For higher precision, install 'hijri-converter' package: pip install -U hijri-converter

tests.py: 24 warnings
  /builddir/build/BUILD/python-holidays-0.10.4/holidays/utils.py: (see https://hijri-converter.readthedocs.io/ )

-- Docs: https://docs.pytest.org/en/stable/warnings.html
=========================== short test summary info ============================
FAILED tests.py::TestIsrael::test_independence_day - TypeError: cannot unpack...
FAILED tests.py::TestIsrael::test_memorial_day - TypeError: cannot unpack non...
================= 2 failed, 572 passed, 72 warnings in 36.68s ==================

For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.10/fedora-rawhide-x86_64/01826883-python-holidays/

For all our attempts to build python-holidays with Python 3.10, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.10/package/python-holidays/

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.10:
https://copr.fedorainfracloud.org/coprs/g/python/python3.10/

Let us know here if you have any questions.

Python 3.10 will be included in Fedora 35. To make that update smoother, we're building Fedora packages with early pre-releases of Python 3.10.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires), so if this package is required a lot, it's important for us to get it fixed soon.
We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Ben Cotton 2021-02-09 15:34:12 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 34 development cycle.
Changing version to 34.

Comment 2 Fedora Admin user for bugzilla script actions 2021-05-07 01:55:54 UTC
This package has changed maintainer in Fedora. Reassigning to the new maintainer of this component.

Comment 3 Miro Hrončok 2021-06-04 20:15:08 UTC
This is a mass-posted update. Sorry if it is not 100% accurate to this bugzilla.


The Python 3.10 rebuild is in progress in a Koji side tag. If you manage to fix the problem, please commit the fix in the rawhide branch, but don't build the package in regular rawhide.

You can either build the package in the side tag, with:

    $ fedpkg build --target=f35-python

Or you can the build and we will eventually build it for you.

Note that the rebuild is still in progress, so not all (build) dependencies of this package might be available right away.

Thanks.

See also https://fedoraproject.org/wiki/Changes/Python3.10

If you have general questions about the rebuild, please use this mailing list thread: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/G47SGOYIQLRDTWGOSLSWERZSSHXDEDH5/

Comment 4 Miro Hrončok 2021-06-07 22:59:38 UTC
The f35-python side tag has been merged to Rawhide. From now on, build as you would normally build.

Comment 5 Miro Hrončok 2021-06-17 23:05:56 UTC
Automation has figured out the package is retired in rawhide.

If you like it to be unretired, please open a ticket at https://pagure.io/releng/new_issue?template=package_unretirement


Note You need to log in before you can comment on or make changes to this bug.