Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1909558 - radeontop doesn't use Fedora CFLAGS and gets built again in %install
Summary: radeontop doesn't use Fedora CFLAGS and gets built again in %install
Keywords:
Status: NEW
Alias: None
Product: Fedora
Classification: Fedora
Component: radeontop
Version: 33
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Luya Tshimbalanga
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-12-20 23:18 UTC by Dominik 'Rathann' Mierzejewski
Modified: 2020-12-20 23:18 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: ---
Doc Text:
Clone Of:
Environment:
Last Closed:
Type: Bug
Embargoed:

Attachments (Terms of Use)

Description Dominik 'Rathann' Mierzejewski 2020-12-20 23:18:27 UTC 
Description of problem:
radeontop doesn't get built with Fedora-mandated CFLAGS and the code gets compiled again in %install section.

Version-Release number of selected component (if applicable):
1.3-1.fc33

How reproducible:
Always

Steps to Reproduce:
1. Rebuild package.

Actual results:
...
Executing(%build): /bin/sh -e /var/tmp/rpm-tmp.eYEf8R
+ umask 022
+ cd /builddir/build/BUILD
+ cd radeontop-1.3
+ /usr/bin/make -O -j6 V=1 VERBOSE=1
./getver.sh
cc -Os -Wall -Wextra -pthread -Iinclude -ffunction-sections -fdata-sections  -I/usr/include/libdrm   -DENABLE_XCB=1 -D_DEFAULT_SOURCE -D_XOPEN_SOURCE=600  -DENABLE_NLS=1 -DHAS_DRMGETDEVICE=1 -DENABLE_AMDGPU=1 -DHAS_AMDGPU_QUERY_SENSOR_INFO=1 -s   -c -o auth.o auth.c
...
Executing(%install): /bin/sh -e /var/tmp/rpm-tmp.80uf0Q
+ umask 022
+ cd /builddir/build/BUILD
+ '[' /builddir/build/BUILDROOT/radeontop-1.3-1.fc33.x86_64 '!=' / ']'
+ rm -rf /builddir/build/BUILDROOT/radeontop-1.3-1.fc33.x86_64
++ dirname /builddir/build/BUILDROOT/radeontop-1.3-1.fc33.x86_64
+ mkdir -p /builddir/build/BUILDROOT
+ mkdir /builddir/build/BUILDROOT/radeontop-1.3-1.fc33.x86_64
+ cd radeontop-1.3
+ /usr/bin/make install DESTDIR=/builddir/build/BUILDROOT/radeontop-1.3-1.fc33.x86_64 'INSTALL=/usr/bin/install -p' LIBDIR=lib64
./getver.sh
cc -Os -Wall -Wextra -pthread -Iinclude -ffunction-sections -fdata-sections  -I/usr/include/libdrm   -DENABLE_XCB=1 -D_DEFAULT_SOURCE -D_XOPEN_SOURCE=600  -DENABLE_NLS=1 -DHAS_DRMGETDEVICE=1 -DENABLE_AMDGPU=1 -DHAS_AMDGPU_QUERY_SENSOR_INFO=1 -s   -c -o auth.o auth.c
...

Expected results:
Binaries built with Fedora CFLAGS (https://docs.fedoraproject.org/en-US/packaging-guidelines/#_compiler_flags) and not built again in %install.

Additional info:
See the build.log in koji: https://koji.fedoraproject.org/koji/buildinfo?buildID=1657373 -> https://kojipkgs.fedoraproject.org//packages/radeontop/1.3/1.fc33/data/logs/x86_64/build.log
Note You need to log in before you can comment on or make changes to this bug.