Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 191040 - Review Request: fedora-package-config-apt - Configuration files for the apt package manager
Summary: Review Request: fedora-package-config-apt - Configuration files for the apt p...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Ville Skyttä
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-05-08 12:10 UTC by Axel Thimm
Modified: 2007-11-30 22:11 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-05-13 10:10:13 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)
Fix some whitespace issues (980 bytes, patch)
2006-05-09 14:24 UTC, Panu Matilainen 		no flags Details | Diff
View All

Description Axel Thimm 2006-05-08 12:10:28 UTC 
Spec URL: http://people.atrpms.net/~athimm/fedorasubmit/fedora-package-config-apt.spec
SRPM URL: http://people.atrpms.net/~athimm/fedorasubmit/fedora-package-config-apt-5.89-1.src.rpm
Description:
This package contains configuration files for apt.
Comment 1 Panu Matilainen 2006-05-09 14:24:40 UTC 
Created attachment 128787 [details]
Fix some whitespace issues

Some sort of whitespace-eating monster appears to have struck the spec, doesn't
build without this + one missing mkdir added.
Comment 2 Axel Thimm 2006-05-09 18:25:20 UTC 
Eeck. Fixed in

Spec URL:
http://people.atrpms.net/~athimm/fedorasubmit/fedora-package-config-apt.spec
SRPM URL:
http://people.atrpms.net/~athimm/fedorasubmit/fedora-package-config-apt-5.89-2.src.rpm

* Tue May  9 2006 Axel Thimm <Axel.Thimm> - 5.89-2
- Fix whitespace (by Panu in bug #191040c1).
Comment 3 Ville Skyttä 2006-05-11 19:56:21 UTC 
Issues:

- Shouldn't the package be noarch?
- Missing dependency on apt (similar issue seems to exist in the corresponding
  smart package too, by the way)

Cosmetics:

- Summary and %description could mention Fedora even though it's in %{name},
  and %description could be expanded a bit.
- Upstream spelling is APT-RPM, that could be used in summary and description too
Comment 4 Axel Thimm 2006-05-11 21:01:53 UTC 
Fixed in

Spec URL:
http://people.atrpms.net/~athimm/fedorasubmit/fedora-package-config-apt.spec

* Thu May 11 2006 Axel Thimm <Axel.Thimm> - 5.89-3
- Apply comments from review #191040c3 (by Ville).
  - Fix summary and description
  - Config files are arch-independent, so we should become noarch
  - Create versioned dependency on apt (make sure it's repo-md capable)
    This creates a circular dependency which should not impose any
    issues.
Comment 5 Ville Skyttä 2006-05-12 20:51:53 UTC 
No SRPM seems to be available for 5.89-3, but if it's the same as -2 apart from
the specfile changes, approved.
Comment 6 Axel Thimm 2006-05-13 10:10:13 UTC 
Thanks for reviewing & approving. The package for devel has been queued in and I
also tagged & built the matching apt package for devel.

(apt will still need some cleansing and an upgrade to the next upstream release,
which is estimated to happen soon, I'm building apt just to have something to
use fedora-package-conf-apt with and not punch dependency holes in devel)

Branches for FC-5 and FC-4 have been requested.
Note You need to log in before you can comment on or make changes to this bug.