Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1914291 - Review Request: radeon-profile-daemon - Daemon for radeon-profile GUI
Summary: Review Request: radeon-profile-daemon - Daemon for radeon-profile GUI
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Vitaly Zaitsev
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1914280
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-01-08 14:37 UTC by Artem
Modified: 2021-01-09 01:12 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-01-09 01:12:34 UTC
Type: ---
Embargoed:
vitaly: fedora-review+


Attachments (Terms of Use)

Description Artem 2021-01-08 14:37:13 UTC
Spec URL: https://atim.fedorapeople.org/radeon-profile-daemon.spec
SRPM URL: https://atim.fedorapeople.org/radeon-profile-daemon-20190603-1.fc33.src.rpm

Description:
System daemon for reading info about Radeon GPU clocks and volts as well as
control card power profiles so the GUI radeon-profile application can be run
as normal user.

Supports opensource xf86-video-ati and xf86-video-amdgpu drivers.

Fedora Account System Username: atim

Comment 1 Artem 2021-01-08 14:37:17 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=59193822

Comment 2 Vitaly Zaitsev 2021-01-08 15:02:59 UTC
I will review this package.

Comment 3 Vitaly Zaitsev 2021-01-08 15:15:06 UTC
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

C/C++:
[x]: Provides: bundled(gnulib) in place as required.
     Note: Sources not installed
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
     Note: There is no build directory. Running licensecheck on vanilla
     upstream sources. No licenses found. Please check the source files for
     licenses manually.
[x]: License file installed when any subpackage combination is installed.
[!]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/lib/systemd/system,
     /usr/lib/systemd
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: systemd_post is invoked in %post, systemd_preun in %preun, and
     systemd_postun in %postun for Systemd service files.
     Note: Systemd service file(s) in radeon-profile-daemon
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: radeon-profile-daemon-20190603-1.fc34.x86_64.rpm
          radeon-profile-daemon-debuginfo-20190603-1.fc34.x86_64.rpm
          radeon-profile-daemon-debugsource-20190603-1.fc34.x86_64.rpm
          radeon-profile-daemon-20190603-1.fc34.src.rpm
radeon-profile-daemon.x86_64: W: spelling-error %description -l en_US opensource -> open source, open-source, outsource
radeon-profile-daemon.x86_64: W: spelling-error %description -l en_US ati -> as, at, ti
radeon-profile-daemon.x86_64: W: spelling-error %description -l en_US amdgpu -> ampule
radeon-profile-daemon.x86_64: W: no-documentation
radeon-profile-daemon.x86_64: W: no-manual-page-for-binary radeon-profile-daemon
radeon-profile-daemon.x86_64: W: percent-in-%postun
radeon-profile-daemon.src: W: spelling-error %description -l en_US opensource -> open source, open-source, outsource
radeon-profile-daemon.src: W: spelling-error %description -l en_US ati -> as, at, ti
radeon-profile-daemon.src: W: spelling-error %description -l en_US amdgpu -> ampule
4 packages and 0 specfiles checked; 0 errors, 9 warnings.




Rpmlint (debuginfo)
-------------------
Checking: radeon-profile-daemon-debuginfo-20190603-1.fc34.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.





Rpmlint (installed packages)
----------------------------
radeon-profile-daemon.x86_64: W: spelling-error %description -l en_US opensource -> open source, open-source, outsource
radeon-profile-daemon.x86_64: W: spelling-error %description -l en_US ati -> as, at, ti
radeon-profile-daemon.x86_64: W: spelling-error %description -l en_US amdgpu -> ampule
radeon-profile-daemon.x86_64: W: no-documentation
radeon-profile-daemon.x86_64: W: no-manual-page-for-binary radeon-profile-daemon
radeon-profile-daemon.x86_64: W: percent-in-%postun
3 packages and 0 specfiles checked; 0 errors, 6 warnings.



Source checksums
----------------
https://github.com/marazmista/radeon-profile-daemon/archive/20190603/radeon-profile-daemon-20190603.tar.gz :
  CHECKSUM(SHA256) this package     : bb0145c3dcbced094e28fe993d8f7e77defcfa5dcef3146badcd82d9fb627700
  CHECKSUM(SHA256) upstream package : bb0145c3dcbced094e28fe993d8f7e77defcfa5dcef3146badcd82d9fb627700


Requires
--------
radeon-profile-daemon (rpmlib, GLIBC filtered):
    /bin/sh
    libQt5Core.so.5()(64bit)
    libQt5Core.so.5(Qt_5)(64bit)
    libQt5Core.so.5(Qt_5.15)(64bit)
    libQt5Network.so.5()(64bit)
    libQt5Network.so.5(Qt_5)(64bit)
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgcc_s.so.1(GCC_3.3.1)(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    radeon-profile(x86-64)
    rtld(GNU_HASH)

radeon-profile-daemon-debuginfo (rpmlib, GLIBC filtered):

radeon-profile-daemon-debugsource (rpmlib, GLIBC filtered):



Provides
--------
radeon-profile-daemon:
    radeon-profile-daemon
    radeon-profile-daemon(x86-64)

radeon-profile-daemon-debuginfo:
    debuginfo(build-id)
    radeon-profile-daemon-debuginfo
    radeon-profile-daemon-debuginfo(x86-64)

radeon-profile-daemon-debugsource:
    radeon-profile-daemon-debugsource
    radeon-profile-daemon-debugsource(x86-64)



Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10
Command line :/usr/bin/fedora-review -b 1914291 -L 1914280-radeon-profile/results
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: Python, PHP, R, fonts, Haskell, Java, Ocaml, Perl, SugarActivity
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH

Built with local dependencies:
    /media/virt/workbench/1914280-radeon-profile/results/radeon-profile-20200824-1.fc34.x86_64.rpm

Comment 4 Vitaly Zaitsev 2021-01-08 15:16:56 UTC
> Directories without known owners: /usr/lib/systemd/system

Please add Requires: systemd.

All other looks good to me. Package approved.

Comment 5 Artem 2021-01-08 15:30:08 UTC
> Please add Requires: systemd.

Based on previous discussion https://bugzilla.redhat.com/show_bug.cgi?id=1885699#c7

Not necessary nowadays to add it explicitly.

Comment 6 Gwyn Ciesla 2021-01-08 16:01:01 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/radeon-profile-daemon

Comment 7 Fedora Update System 2021-01-08 16:21:40 UTC
FEDORA-2021-eba7681ea2 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-eba7681ea2

Comment 8 Fedora Update System 2021-01-08 16:21:42 UTC
FEDORA-2021-eba7681ea2 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-eba7681ea2

Comment 9 Fedora Update System 2021-01-09 01:12:34 UTC
FEDORA-2021-eba7681ea2 has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.