Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1917461 - etckeeper dnf plugin doesn't halt dnf on unclean /etc
Summary: etckeeper dnf plugin doesn't halt dnf on unclean /etc
Keywords:
Status: NEW
Alias: None
Product: Fedora EPEL
Classification: Fedora
Component: etckeeper
Version: epel8
Hardware: x86_64
OS: Linux
unspecified
high
Target Milestone: ---
Assignee: Thomas Moschny
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-01-18 14:28 UTC by David Allsopp
Modified: 2021-01-18 14:28 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: ---
Doc Text:
Clone Of:
Environment:
Last Closed:
Type: Bug
Embargoed:

Attachments (Terms of Use)

Description David Allsopp 2021-01-18 14:28:19 UTC 
Description of problem:

When configured to avoid committing changes to /etc before installation, the etckeeper dnf plugin warns that /etc is not clean but allows dnf to proceed anyway. It should abort the dnf install, as the EPEL 7 (yum) version does.

Version-Release number of selected component (if applicable): 1.18.14-1

How reproducible: Every time.

Steps to Reproduce:
1. Ensure AVOID_COMMIT_BEFORE_INSTALL=1 uncommented in /etc/etckeeper/etckeeper.conf
2. Touch a new file or edit something in /etc - etckeeper unclean should exit with code 0
3. Run dnf install for a package

Actual results:

Last metadata expiration check: 0:27:06 ago on Mon 18 Jan 2021 13:59:04 GMT.
"etckeeper pre-install" failed (exit code 1)

and dnf proceeds as normal with the installation.

Expected results:

Equivalent behaviour of the yum plugin in EPEL 7:

etckeeper: pre transaction commit

** etckeeper detected uncommitted changes in /etc prior to yum run
** Aborting yum run. Manually commit and restart.

Additional info:

Looks like something's wrong with the python3 translation of the plugin?
Note You need to log in before you can comment on or make changes to this bug.