Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1923434 - workrave: FTBFS in Fedora rawhide/f34
Summary: workrave: FTBFS in Fedora rawhide/f34
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: workrave
Version: 34
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Lukas Zapletal
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: F34FTBFS
TreeView+ depends on / blocked
 
Reported: 2021-02-01 16:50 UTC by Fedora Release Engineering
Modified: 2021-03-03 16:54 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-02-15 17:16:56 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)
build.log (1.20 KB, text/plain)
2021-02-01 16:50 UTC, Fedora Release Engineering 		no flags Details
root.log (32.00 KB, text/plain)
2021-02-01 16:50 UTC, Fedora Release Engineering 		no flags Details
state.log (832 bytes, text/plain)
2021-02-01 16:50 UTC, Fedora Release Engineering 		no flags Details
View All

Description Fedora Release Engineering 2021-02-01 16:50:41 UTC 
workrave failed to build from source in Fedora rawhide/f34

https://koji.fedoraproject.org/koji/taskinfo?taskID=60910413


For details on the mass rebuild see:

https://fedoraproject.org/wiki/Fedora_34_Mass_Rebuild
Please fix workrave at your earliest convenience and set the bug's status to
ASSIGNED when you start fixing it. If the bug remains in NEW state for 8 weeks,
workrave will be orphaned. Before branching of Fedora 35,
workrave will be retired, if it still fails to build.

For more details on the FTBFS policy, please visit:
https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/
Comment 1 Fedora Release Engineering 2021-02-01 16:50:43 UTC 
Created attachment 1753316 [details]
build.log
Comment 2 Fedora Release Engineering 2021-02-01 16:50:44 UTC 
Created attachment 1753317 [details]
root.log

file root.log too big, will only attach last 32768 bytes
Comment 3 Fedora Release Engineering 2021-02-01 16:50:45 UTC 
Created attachment 1753318 [details]
state.log
Comment 4 Lukas Zapletal 2021-02-08 11:39:22 UTC 
Mukundan,

can I ask you how should we modify this package to get it building again? It's currently failing due to the latest change in xfce4-panel (version 4.16 update):

    No matching package to install: 'pkgconfig(libxfce4panel-1.0) >= 4.4'

I noticed this was renamed to pkgconfig(Libxfce4panel-1.0) but dnf is not resolving this:

    No matching package to install: 'pkgconfig(Libxfce4panel-1.0) >= 4.4'

Any hint? Thanks!
Comment 5 Mukundan Ragavan 2021-02-08 23:15:19 UTC 
Looking at the configure.ac file, workrave *should* build against libxfce4panel-2.0

configure.ac:   PKG_CHECK_MODULES([LIBXFCE4PANEL],
configure.ac:                    [libxfce4panel-2.0 >= 4.12],


Patch would be something like this - 

diff --git a/workrave.spec b/workrave.spec
index 677d4a4..b76d738 100644
--- a/workrave.spec
+++ b/workrave.spec
@@ -4,7 +4,7 @@
 
 Name: workrave
 Version: 1.10.44
-Release: 2%{?dist}
+Release: 3%{?dist}
 Summary: Program that assists in the recovery and prevention of RSI
 # Based on older packages by Dag Wieers <dag> and Steve Ratcliffe
 License: GPLv3+
@@ -50,7 +50,7 @@ BuildRequires: pkgconfig(libpanel-applet)
 BuildRequires: pkgconfig(gtk+-2.0) >= 2.6.0
 %endif
 %if 0%{?xfce}
-BuildRequires: pkgconfig(Libxfce4panel-1.0) >= 4.4
+BuildRequires: pkgconfig(libxfce4panel-2.0) >= 4.4
 %endif
 %if 0%{?mate}
 BuildRequires: pkgconfig(libmatepanelapplet-4.0)
@@ -207,6 +207,9 @@ desktop-file-install \
 %endif
 
 %changelog
+* Mon Feb 08 2021 Mukundan Ragavan <nonamedotc> - 1.10.44-3
+- Build against libxfce4panel-2.0
+
 * Wed Jan 27 2021 Fedora Release Engineering <releng> - 1.10.44-2
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_34_Mass_Rebuild
 
--
Comment 6 Mukundan Ragavan 2021-02-08 23:24:35 UTC 
This does not build. I am working on a patch.
Comment 7 Mukundan Ragavan 2021-02-08 23:36:31 UTC 
please see here - https://src.fedoraproject.org/rpms/workrave/pull-request/2
Comment 8 Lukas Zapletal 2021-02-09 12:28:46 UTC 
Thank you so much for the patch, I don't do any desktop development I was just using this software some time ago. Tomas also no longer use it, a pair of extra hands would be really helpful if you would not mind joining us maintaining it.
Comment 9 Ben Cotton 2021-02-09 15:51:22 UTC 
This bug appears to have been reported against 'rawhide' during the Fedora 34 development cycle.
Changing version to 34.
Comment 10 Mukundan Ragavan 2021-02-09 23:23:00 UTC 
(In reply to Lukas Zapletal from comment #8)
> Thank you so much for the patch, I don't do any desktop development I was
> just using this software some time ago. Tomas also no longer use it, a pair
> of extra hands would be really helpful if you would not mind joining us
> maintaining it.

Sure. I can be a co-maintainer. Please add me. My FAS is nonamedotc.
Comment 11 Fedora Release Engineering 2021-02-14 04:24:54 UTC 
Dear Maintainer,

your package has an open Fails To Build From Source bug for Fedora 34.
Action is required from you.

If you can fix your package to build, perform a build in koji, and either create
an update in bodhi, or close this bug without creating an update, if updating is
not appropriate [1]. If you are working on a fix, set the status to ASSIGNED to
acknowledge this. If you have already fixed this issue, please close this Bugzilla report.

Following the policy for such packages [2], your package will be orphaned if
this bug remains in NEW state more than 8 weeks (not sooner than 2021-03-29).

A week before the mass branching of Fedora 35 according to the schedule [3],
any packages not successfully rebuilt at least on Fedora 33 will be
retired regardless of the status of this bug.

[1] https://docs.fedoraproject.org/en-US/fesco/Updates_Policy/
[2] https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/
[3] https://fedorapeople.org/groups/schedule/f-35/f-35-key-tasks.html
Comment 12 Fedora Release Engineering 2021-02-14 04:24:55 UTC 
Dear Maintainer,

your package has an open Fails To Build From Source bug for Fedora 34.
Action is required from you.

If you can fix your package to build, perform a build in koji, and either create
an update in bodhi, or close this bug without creating an update, if updating is
not appropriate [1]. If you are working on a fix, set the status to ASSIGNED to
acknowledge this. If you have already fixed this issue, please close this Bugzilla report.

Following the policy for such packages [2], your package will be orphaned if
this bug remains in NEW state more than 8 weeks (not sooner than 2021-03-29).

A week before the mass branching of Fedora 35 according to the schedule [3],
any packages not successfully rebuilt at least on Fedora 33 will be
retired regardless of the status of this bug.

[1] https://docs.fedoraproject.org/en-US/fesco/Updates_Policy/
[2] https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/
[3] https://fedorapeople.org/groups/schedule/f-35/f-35-key-tasks.html
Comment 13 Tomáš Mráz 2021-02-15 17:16:56 UTC 
I've run the builds on Fedora rawhide and 34 branches where the fix from Mukundan was merged and they passed.
Comment 14 Tomáš Mráz 2021-02-15 17:18:24 UTC 
Lukas, can you please add Mukundan as comaintainer?
Comment 15 Lukas Zapletal 2021-03-03 16:54:37 UTC 
Apologies for the delay, done. Thank you!
Note You need to log in before you can comment on or make changes to this bug.