Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 192583 (php-pear-XML-Parser) - Review Request: php-pear-XML-Parser - XML parsing class based on PHP's bundled expat
Summary: Review Request: php-pear-XML-Parser - XML parsing class based on PHP's bundle...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: php-pear-XML-Parser
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Christopher Stone
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks: FE-ACCEPT pear-Payment-Process
TreeView+ depends on / blocked
 
Reported: 2006-05-21 07:56 UTC by Remi Collet
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-09-04 16:53:20 UTC
Type: ---
Embargoed:
petersen: fedora-cvs+

Attachments (Terms of Use)

Description Remi Collet 2006-05-21 07:56:41 UTC 
Spec URL: http://remi.collet.free.fr/rpms/extras/php-pear-XML-Parser.spec
SRPM URL: http://remi.collet.free.fr/rpms/extras/php-pear-XML-Parser-1.2.7-1.fc5.src.rpm
Description: http://remi.collet.free.fr/rpms/extras/php-pear-XML-Parser-build.log

This is an XML parser based on PHPs built-in xml extension.
It supports two basic modes of operation: "func" and "event".
In "func" mode, it will look for a function named after each element
(xmltag_ELEMENT for start tags and xmltag_ELEMENT_ for end tags),
and in "event" mode it uses a set of generic callbacks.

Since version 1.2.0 there's a new XML_Parser_Simple class that makes
parsing of most XML documents easier, by automatically providing a stack
for the elements. Furthermore its now possible to split the parser from
the handler object, so you do not have to extend XML_Parser anymore in
order to parse a document with it.
--------------------
With DB, HTTP (Bug #190156), Mail (Bug #190066), Net_Socket (Bug #190957), Net_SMTP (Bug #190958), extras will provides all the extensions which was provides by php until version 5.0.4 (in FC4).
Comment 1 Parag AN(पराग) 2006-06-01 09:28:00 UTC 
Not a Review but some hints on improving SPEC:-
1) Remove Provides tag RPM will generate an appropriate Provides: entry itself.
2) rpmlint gives error on using License: PHP License
3) Add some Documnetation Files like README, INSTALL
Comment 2 Parag AN(पराग) 2006-06-01 09:29:22 UTC 
Also when i built repm from SPEC i got
warning: pear/XML_Parser requires package "pear/PEAR"
Comment 3 Remi Collet 2006-06-03 12:08:24 UTC 
1/ Provides follow php guidelines
http://fedoraproject.org/wiki/Packaging/PHP

2/ it's a rpmlint bug, see Bug #191078

3/ none provided upstream (only examples), i've also add the Licence.

4/ this warning is "normal". Useful to check the "Requires" in spec file.
Comment 4 Christopher Stone 2006-06-27 09:59:29 UTC 
I will do a formal review on this package but you will not be able to check it
in until you are sponsered with bug #190007
Comment 5 Christopher Stone 2006-06-27 23:14:04 UTC 
MUST ITEM CHECKLIST:
- rpmlint output:
W: php-pear-XML-Parser invalid-license PHP License
W: php-pear-XML-Parser dangerous-command-in-%post install
W: php-pear-XML-Parser invalid-license PHP License

Warnings can be ignored

- package is named according to php packaging naming guidelines
- spec file name matches %{name}
- package meets packaging guidelines
- package is licensed with open source compatible license
- license field matches actual license
- source contains license file in %doc
- spec file is in American English (and french)
- spec file is legible
- sources match upstream
f4a491b49843f8257df8ded088854db3  XML_Parser-1.2.7.tgz
- package successfully compiles and builds on FC-5 x86_64
O This package is missing:
Requires(post):   php-pear >= 1.4.9
Requires(postun): php-pear >= 1.4.9
- package does not use locales
- package does not contain shared libraries in default paths (no need to run
ldconfig)
- package is not relocatable
- package owns all directories it creates
- package does not contain any duplicate %files
- permissions are set properly
- package contains proper %clean section
- macro usage is consistant
- package contains permissible content
- package does not have large documentation
- package does not include header files or static libraries
- package does not use pkgconfig files
- package does not contain library with suffix
- package does not require a devel subpackage
- package does not contain any .la files
- package is not a gui and does not need a .desktop file
- package does not own files or directories owned by other packages

MUST
- Must Add:
Requires(post):   php-pear >= 1.4.9
Requires(postun): php-pear >= 1.4.9
- Explain why adding  || : in %post and %postun sections was added, should we
not fail if this step fails?
- Change %defattr to (-,root,root,-)
- Remove dist tages in changelog version numbers
Comment 6 Christopher Stone 2006-06-28 09:46:18 UTC 
Also, add php >= 4.2.0 to the Requires to meet PHP packaging guidelines
Comment 7 Remi Collet 2006-09-02 08:10:28 UTC 
Spec: http://remi.collet.free.fr/rpms/extras/php-pear-XML-Parser.spec
SRPM: http://remi.collet.free.fr/rpms/extras/php-pear-XML-Parser-1.2.7-2.fc5.src.rpm
Mock: http://remi.collet.free.fr/rpms/extras/php-pear-XML-Parser-build.log

Changes:
- use new macros from /etc/rpm/macros.pear
- own /usr/share/pear/XML
- require php >= 4.2.0
Comment 8 Christopher Stone 2006-09-03 04:39:22 UTC 
Hi Remi, can you update the %setup and %install sections to the new cleaner way
shown here:

https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=135449

More info at bug #198706
Comment 9 Remi Collet 2006-09-03 16:19:46 UTC 
Spec: http://remi.collet.free.fr/rpms/extras/php-pear-XML-Parser.spec
SRPM: http://remi.collet.free.fr/rpms/extras/php-pear-XML-Parser-1.2.7-3.fc5.src.rpm
Mock: http://remi.collet.free.fr/rpms/extras/php-pear-XML-Parser-build.log

Changes:
- new and simpler %%prep and %%install
Comment 10 Christopher Stone 2006-09-03 23:53:03 UTC 
Looks good, approved.
Comment 11 Christopher Stone 2006-09-04 00:01:21 UTC 
please change %defattr(-,root,root) to defattr(-,root,root,-) after importing
into cvs.
Comment 12 Remi Collet 2007-03-31 08:30:31 UTC 
Package Change Request
======================
Package Name: php-pear-XML-Parser
New Branches: EL-5
Comment 13 Jens Petersen 2007-04-02 13:08:08 UTC 
done
Note You need to log in before you can comment on or make changes to this bug.