Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1926613 - python-losant-rest fails to build with Python 3.10: AttributeError: module 'collections' has no attribute 'Mapping'
Summary: python-losant-rest fails to build with Python 3.10: AttributeError: module 'c...
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: python-losant-rest
Version: 35
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Orphan Owner
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 1969019 (view as bug list)
Depends On:
Blocks: PYTHON3.10 F35FTBFS F35FailsToInstall F36FTBFS F36FailsToInstall
TreeView+ depends on / blocked
 
Reported: 2021-02-09 08:19 UTC by Tomáš Hrnčiar
Modified: 2022-09-27 06:32 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-08-18 08:23:40 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Tomáš Hrnčiar 2021-02-09 08:19:32 UTC
python-losant-rest fails to build with Python 3.10.0a5.

tests/losantrest_tests.py::TestClient::test_basic_call_no_auth FAILED    [ 20%]
tests/losantrest_tests.py::TestClient::test_basic_call_with_auth FAILED  [ 40%]
tests/losantrest_tests.py::TestClient::test_failure_call FAILED          [ 60%]
tests/losantrest_tests.py::TestClient::test_json_query_param_call FAILED [ 80%]
tests/losantrest_tests.py::TestClient::test_nested_query_param_call FAILED [100%]

=================================== FAILURES ===================================
______________________ TestClient.test_basic_call_no_auth ______________________

self = <tests.losantrest_tests.TestClient testMethod=test_basic_call_no_auth>
mock = <requests_mock.mocker.Mocker object at 0x7faa1ce56d60>

    @requests_mock.Mocker()
    def test_basic_call_no_auth(self, mock):
        expected_body = {"token": "a token", "userId": "theUserId"}
        expected_qs = {"_links": ["true"], "_actions": ["false"], "_embedded": ["true"]}
        creds = {"email": "example", "password": "qwerqwer"}
        mock.post("https://api.losant.com/auth/user", json=expected_body)
    
>       resp = Client().auth.authenticate_user(credentials=creds)

tests/losantrest_tests.py:22: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
losantrest/auth.py:119: in authenticate_user
    return self.client.request("POST", path, params=query_params, headers=headers, body=body)
losantrest/client.py:182: in request
    params = self.flatten_params(params)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <losantrest.client.Client object at 0x7faa1ce56eb0>
data = {'_actions': 'false', '_embedded': 'true', '_links': 'true'}
base_key = None

    def flatten_params(self, data, base_key=None):
        """ Flatten out nested arrays and dicts in query params into correct format """
        result = {}
    
        if data is None:
            return result
    
        map_data = None
>       if not isinstance(data, collections.Mapping):
E       AttributeError: module 'collections' has no attribute 'Mapping'

losantrest/client.py:204: AttributeError
_____________________ TestClient.test_basic_call_with_auth _____________________

self = <tests.losantrest_tests.TestClient testMethod=test_basic_call_with_auth>
mock = <requests_mock.mocker.Mocker object at 0x7faa1ce51400>

    @requests_mock.Mocker()
    def test_basic_call_with_auth(self, mock):
        expected_body = {"name": "Python Client Testing", "_type": "device", "applicationId": "anapp", "id": "adevice"}
        expected_qs = {"_links": ["true"], "_actions": ["false"], "_embedded": ["true"]}
        mock.get("https://api.losant.com/applications/anapp/devices/adevice", json=expected_body)
    
>       resp = Client("a token").device.get(applicationId="anapp", deviceId="adevice")

tests/losantrest_tests.py:41: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
losantrest/device.py:197: in get
    return self.client.request("GET", path, params=query_params, headers=headers, body=body)
losantrest/client.py:182: in request
    params = self.flatten_params(params)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <losantrest.client.Client object at 0x7faa1ce517c0>
data = {'_actions': 'false', '_embedded': 'true', '_links': 'true'}
base_key = None

    def flatten_params(self, data, base_key=None):
        """ Flatten out nested arrays and dicts in query params into correct format """
        result = {}
    
        if data is None:
            return result
    
        map_data = None
>       if not isinstance(data, collections.Mapping):
E       AttributeError: module 'collections' has no attribute 'Mapping'

losantrest/client.py:204: AttributeError
_________________________ TestClient.test_failure_call _________________________

self = <tests.losantrest_tests.TestClient testMethod=test_failure_call>
mock = <requests_mock.mocker.Mocker object at 0x7faa1ce646a0>

    @requests_mock.Mocker()
    def test_failure_call(self, mock):
        expected_body = {"message": "Unauthorized", "type": "Unauthorized"}
        expected_qs = {"_links": ["true"], "_actions": ["false"], "_embedded": ["true"]}
        mock.post("https://api.losant.com/auth/user", json=expected_body, status_code=401)
        creds = {"email": "example", "password": "qwerqwer"}
    
        with self.assertRaises(LosantError) as cm:
>           Client().auth.authenticate_user(credentials=creds)

tests/losantrest_tests.py:60: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
losantrest/auth.py:119: in authenticate_user
    return self.client.request("POST", path, params=query_params, headers=headers, body=body)
losantrest/client.py:182: in request
    params = self.flatten_params(params)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

    def flatten_params(self, data, base_key=None):
        """ Flatten out nested arrays and dicts in query params into correct format """
        result = {}
    
        if data is None:
            return result
    
        map_data = None
>       if not isinstance(data, collections.Mapping):
E       AttributeError: module 'collections' has no attribute 'Mapping'

losantrest/client.py:204: AttributeError
____________________ TestClient.test_json_query_param_call _____________________

self = <tests.losantrest_tests.TestClient testMethod=test_json_query_param_call>
mock = <requests_mock.mocker.Mocker object at 0x7faa1cebdb20>

    @requests_mock.Mocker()
    def test_json_query_param_call(self, mock):
        expected_body = {"count": 0, "items": []}
        expected_qs = {
            "_links": ["true"],
            "_actions": ["false"],
            "_embedded": ["true"],
            "query": ['{"$and": [{"level": "info"}, {"state": "new"}]}']
        }
        mock.get("https://api.losant.com/applications/anapp/events", json=expected_body)
    
>       resp = Client("a token").events.get(applicationId="anapp", query={
            "$and": [{ "level": "info" }, { "state": "new" }]
        })

tests/losantrest_tests.py:112: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
losantrest/events.py:200: in get
    return self.client.request("GET", path, params=query_params, headers=headers, body=body)
losantrest/client.py:182: in request
    params = self.flatten_params(params)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <losantrest.client.Client object at 0x7faa1cebdd60>
data = {'_actions': 'false', '_embedded': 'true', '_links': 'true', 'query': '{"$and": [{"level": "info"}, {"state": "new"}]}'}
base_key = None

    def flatten_params(self, data, base_key=None):
        """ Flatten out nested arrays and dicts in query params into correct format """
        result = {}
    
        if data is None:
            return result
    
        map_data = None
>       if not isinstance(data, collections.Mapping):
E       AttributeError: module 'collections' has no attribute 'Mapping'

losantrest/client.py:204: AttributeError
___________________ TestClient.test_nested_query_param_call ____________________

self = <tests.losantrest_tests.TestClient testMethod=test_nested_query_param_call>
mock = <requests_mock.mocker.Mocker object at 0x7faa1ce49760>

    @requests_mock.Mocker()
    def test_nested_query_param_call(self, mock):
        expected_body = {"count": 0, "items": []}
        expected_qs = {
            "_links": ["true"],
            "_actions": ["false"],
            "_embedded": ["true"],
            "tagFilter[0][key]": ["key2"],
            "tagFilter[1][value]": ["value1"],
            "tagFilter[1][key]": ["key1"],
            "tagFilter[2][value]": ["value2"]
        }
        mock.get("https://api.losant.com/applications/anapp/devices", json=expected_body)
    
>       resp = Client("a token").devices.get(applicationId="anapp", tagFilter=[
            {"key": "key2"},
            {"key": "key1", "value": "value1"},
            {"value": "value2"},
        ])

tests/losantrest_tests.py:87: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
losantrest/devices.py:216: in get
    return self.client.request("GET", path, params=query_params, headers=headers, body=body)
losantrest/client.py:182: in request
    params = self.flatten_params(params)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <losantrest.client.Client object at 0x7faa1ce49df0>
data = {'_actions': 'false', '_embedded': 'true', '_links': 'true', 'tagFilter': [{'key': 'key2'}, {'key': 'key1', 'value': 'value1'}, {'value': 'value2'}]}
base_key = None

    def flatten_params(self, data, base_key=None):
        """ Flatten out nested arrays and dicts in query params into correct format """
        result = {}
    
        if data is None:
            return result
    
        map_data = None
>       if not isinstance(data, collections.Mapping):
E       AttributeError: module 'collections' has no attribute 'Mapping'

losantrest/client.py:204: AttributeError
=========================== short test summary info ============================
FAILED tests/losantrest_tests.py::TestClient::test_basic_call_no_auth - Attri...
FAILED tests/losantrest_tests.py::TestClient::test_basic_call_with_auth - Att...
FAILED tests/losantrest_tests.py::TestClient::test_failure_call - AttributeEr...
FAILED tests/losantrest_tests.py::TestClient::test_json_query_param_call - At...
FAILED tests/losantrest_tests.py::TestClient::test_nested_query_param_call - ...
============================== 5 failed in 0.20s ===============================

The deprecated aliases to Collections Abstract Base Classes were removed from the collections module.
https://docs.python.org/3.10/whatsnew/changelog.html#python-3-10-0-alpha-5
https://bugs.python.org/issue37324

For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.10/fedora-rawhide-x86_64/01952293-python-losant-rest/

For all our attempts to build python-losant-rest with Python 3.10, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.10/package/python-losant-rest/

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.10:
https://copr.fedorainfracloud.org/coprs/g/python/python3.10/

Let us know here if you have any questions.

Python 3.10 will be included in Fedora 35. To make that update smoother, we're building Fedora packages with early pre-releases of Python 3.10.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires), so if this package is required a lot, it's important for us to get it fixed soon.
We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Ben Cotton 2021-02-09 16:08:39 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 34 development cycle.
Changing version to 34.

Comment 2 Miro Hrončok 2021-06-04 20:13:27 UTC
This is a mass-posted update. Sorry if it is not 100% accurate to this bugzilla.


The Python 3.10 rebuild is in progress in a Koji side tag. If you manage to fix the problem, please commit the fix in the rawhide branch, but don't build the package in regular rawhide.

You can either build the package in the side tag, with:

    $ fedpkg build --target=f35-python

Or you can the build and we will eventually build it for you.

Note that the rebuild is still in progress, so not all (build) dependencies of this package might be available right away.

Thanks.

See also https://fedoraproject.org/wiki/Changes/Python3.10

If you have general questions about the rebuild, please use this mailing list thread: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/G47SGOYIQLRDTWGOSLSWERZSSHXDEDH5/

Comment 3 Miro Hrončok 2021-06-07 22:58:15 UTC
The f35-python side tag has been merged to Rawhide. From now on, build as you would normally build.

Comment 4 Miro Hrončok 2021-06-08 11:27:12 UTC
*** Bug 1969019 has been marked as a duplicate of this bug. ***

Comment 5 Miro Hrončok 2021-06-15 20:25:26 UTC
Hello,

This is the first reminder (step 3 from https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/#_package_removal_for_long_standing_ftbfs_and_fti_bugs).

If you know about this problem and are planning on fixing it, please acknowledge so by setting the bug status to ASSIGNED. If you don't have time to maintain this package, consider orphaning it, so maintainers of dependent packages realize the problem.

Comment 6 Miro Hrončok 2021-07-07 11:22:18 UTC
Hello,

This is the second reminder (step 4 from https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/#_package_removal_for_long_standing_ftbfs_and_fti_bugs).

If you know about this problem and are planning on fixing it, please acknowledge so by setting the bug status to ASSIGNED. If you don't have time to maintain this package, consider orphaning it, so maintainers of dependent packages realize the problem.

Comment 7 Fedora Release Engineering 2021-07-11 04:22:32 UTC
Dear Maintainer,

your package has an open Fails To Build From Source bug for Fedora 35.
Action is required from you.

If you can fix your package to build, perform a build in koji, and either create
an update in bodhi, or close this bug without creating an update, if updating is
not appropriate [1]. If you are working on a fix, set the status to ASSIGNED to
acknowledge this. If you have already fixed this issue, please close this Bugzilla report.

Following the policy for such packages [2], your package will be orphaned if
this bug remains in NEW state more than 8 weeks (not sooner than 2021-04-06).

A week before the mass branching of Fedora 36 according to the schedule [3],
any packages not successfully rebuilt at least on Fedora 34 will be
retired regardless of the status of this bug.

[1] https://docs.fedoraproject.org/en-US/fesco/Updates_Policy/
[2] https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/
[3] https://fedorapeople.org/groups/schedule/f-36/f-36-key-tasks.html

Comment 8 Fedora Release Engineering 2021-08-01 04:22:40 UTC
Dear Maintainer,

your package has an open Fails To Build From Source bug for Fedora 35.
Action is required from you.

If you can fix your package to build, perform a build in koji, and either create
an update in bodhi, or close this bug without creating an update, if updating is
not appropriate [1]. If you are working on a fix, set the status to ASSIGNED to
acknowledge this. If you have already fixed this issue, please close this Bugzilla report.

Following the policy for such packages [2], your package will be orphaned if
this bug remains in NEW state more than 8 weeks (not sooner than 2021-04-06).

A week before the mass branching of Fedora 36 according to the schedule [3],
any packages not successfully rebuilt at least on Fedora 34 will be
retired regardless of the status of this bug.

[1] https://docs.fedoraproject.org/en-US/fesco/Updates_Policy/
[2] https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/
[3] https://fedorapeople.org/groups/schedule/f-36/f-36-key-tasks.html

Comment 9 Miro Hrončok 2021-08-05 16:44:35 UTC
This package has been orphaned.

You can pick it up at https://src.fedoraproject.org/rpms/python-losant-rest by clicking button "Take". If nobody picks it up, it will be retired and removed from a distribution.

Comment 10 Ben Cotton 2021-08-10 12:50:56 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 35 development cycle.
Changing version to 35.

Comment 11 Miro Hrončok 2021-08-18 08:23:40 UTC
Automation has figured out the package is retired in Fedora 35.

If you like it to be unretired, please open a ticket at https://pagure.io/releng/new_issue?template=package_unretirement


Note You need to log in before you can comment on or make changes to this bug.