Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1927312 - python-eyed3 fails to build with Python 3.10: NameError: name 'DisplayPatternParser' is not defined
Summary: python-eyed3 fails to build with Python 3.10: NameError: name 'DisplayPattern...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: python-eyed3
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: David King
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 1968969 (view as bug list)
Depends On: 1926212
Blocks: PYTHON3.10 F35FTBFS F35FailsToInstall
TreeView+ depends on / blocked
 
Reported: 2021-02-10 13:57 UTC by Tomáš Hrnčiar
Modified: 2021-07-08 09:30 UTC (History)
6 users (show)

Fixed In Version: python-eyed3-0.9.6-3.fc35
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-07-08 09:30:47 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Tomáš Hrnčiar 2021-02-10 13:57:21 UTC
python-eyed3 fails to build with Python 3.10.0a5.

=================================== FAILURES ===================================
______________________ TestDisplayPlugin.testCommentsTag _______________________

self = <tests.test_display_plugin.TestDisplayPlugin testMethod=testCommentsTag>

    def testCommentsTag(self):
        self.file.tag.comments.set("TEXT", description="", lang=b"DE")
        self.file.tag.comments.set("#d-tag", description="#l-tag", lang=b"#t-tag")
        # Langs are chopped to 3 bytes (are are codes), so #t- is expected.
>       self.__checkOutput("%comments,output=#d #l #t,separation=|%", " DE TEXT|#l-tag #t- #d-tag")

tests/test_display_plugin.py:26: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
tests/test_display_plugin.py:45: in __checkOutput
    output = Pattern(pattern).output_for(self.file)
eyed3/plugins/display.py:25: in output_for
    for sub_pattern in self.sub_patterns or []:
eyed3/plugins/display.py:31: in __get_sub_patterns
    self.__compile()
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = None

    def __compile(self):
        # TODO: add support for comments in pattern
>       parser = DisplayPatternParser(whitespace='')
E       NameError: name 'DisplayPatternParser' is not defined

eyed3/plugins/display.py:41: NameError
________________________ TestDisplayPlugin.testComposer ________________________

self = <tests.test_display_plugin.TestDisplayPlugin testMethod=testComposer>

    def testComposer(self):
        self.file.tag.composer = "Bad Brains"
>       self.__checkOutput("%C% - %composer%", "Bad Brains - Bad Brains")

tests/test_display_plugin.py:20: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
tests/test_display_plugin.py:45: in __checkOutput
    output = Pattern(pattern).output_for(self.file)
eyed3/plugins/display.py:25: in output_for
    for sub_pattern in self.sub_patterns or []:
eyed3/plugins/display.py:31: in __get_sub_patterns
    self.__compile()
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = None

    def __compile(self):
        # TODO: add support for comments in pattern
>       parser = DisplayPatternParser(whitespace='')
E       NameError: name 'DisplayPatternParser' is not defined

eyed3/plugins/display.py:41: NameError
____________________ TestDisplayPlugin.testNotEmptyFunction ____________________

self = <tests.test_display_plugin.TestDisplayPlugin testMethod=testNotEmptyFunction>

    def testNotEmptyFunction(self):
>       self.__checkOutput("$not-empty(foo,hello #t,nothing)", "hello foo")

tests/test_display_plugin.py:33: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
tests/test_display_plugin.py:45: in __checkOutput
    output = Pattern(pattern).output_for(self.file)
eyed3/plugins/display.py:25: in output_for
    for sub_pattern in self.sub_patterns or []:
eyed3/plugins/display.py:31: in __get_sub_patterns
    self.__compile()
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = None

    def __compile(self):
        # TODO: add support for comments in pattern
>       parser = DisplayPatternParser(whitespace='')
E       NameError: name 'DisplayPatternParser' is not defined

eyed3/plugins/display.py:41: NameError
__________________ TestDisplayPlugin.testNumberFormatFunction __________________

self = <tests.test_display_plugin.TestDisplayPlugin testMethod=testNumberFormatFunction>

    def testNumberFormatFunction(self):
>       self.__checkOutput("$num(123,5)", "00123")

tests/test_display_plugin.py:37: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
tests/test_display_plugin.py:45: in __checkOutput
    output = Pattern(pattern).output_for(self.file)
eyed3/plugins/display.py:25: in output_for
    for sub_pattern in self.sub_patterns or []:
eyed3/plugins/display.py:31: in __get_sub_patterns
    self.__compile()
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = None

    def __compile(self):
        # TODO: add support for comments in pattern
>       parser = DisplayPatternParser(whitespace='')
E       NameError: name 'DisplayPatternParser' is not defined

eyed3/plugins/display.py:41: NameError
_____________________ TestDisplayPlugin.testRepeatFunction _____________________

self = <tests.test_display_plugin.TestDisplayPlugin testMethod=testRepeatFunction>

    def testRepeatFunction(self):
>       self.__checkOutput("$repeat(*,3)", "***")

tests/test_display_plugin.py:29: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
tests/test_display_plugin.py:45: in __checkOutput
    output = Pattern(pattern).output_for(self.file)
eyed3/plugins/display.py:25: in output_for
    for sub_pattern in self.sub_patterns or []:
eyed3/plugins/display.py:31: in __get_sub_patterns
    self.__compile()
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = None

    def __compile(self):
        # TODO: add support for comments in pattern
>       parser = DisplayPatternParser(whitespace='')
E       NameError: name 'DisplayPatternParser' is not defined

eyed3/plugins/display.py:41: NameError
_______________________ TestDisplayPlugin.testSimpleTags _______________________

self = <tests.test_display_plugin.TestDisplayPlugin testMethod=testSimpleTags>

    def testSimpleTags(self):
        self.file.tag.artist = "The Artist"
        self.file.tag.title = "Some Song"
        self.file.tag.composer = "Some Composer"
>       self.__checkOutput("%a% - %t% - %C%", "The Artist - Some Song - Some Composer")

tests/test_display_plugin.py:16: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
tests/test_display_plugin.py:45: in __checkOutput
    output = Pattern(pattern).output_for(self.file)
eyed3/plugins/display.py:25: in output_for
    for sub_pattern in self.sub_patterns or []:
eyed3/plugins/display.py:31: in __get_sub_patterns
    self.__compile()
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = None

    def __compile(self):
        # TODO: add support for comments in pattern
>       parser = DisplayPatternParser(whitespace='')
E       NameError: name 'DisplayPatternParser' is not defined

eyed3/plugins/display.py:41: NameError
____________________ TestDisplayParser.testCompileException ____________________

self = <tests.test_display_plugin.TestDisplayParser testMethod=testCompileException>

    def testCompileException(self):
        with pytest.raises(PatternCompileException):
>           Pattern("$bad-pattern").output_for(None)

tests/test_display_plugin.py:97: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
eyed3/plugins/display.py:25: in output_for
    for sub_pattern in self.sub_patterns or []:
eyed3/plugins/display.py:31: in __get_sub_patterns
    self.__compile()
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = None

    def __compile(self):
        # TODO: add support for comments in pattern
>       parser = DisplayPatternParser(whitespace='')
E       NameError: name 'DisplayPatternParser' is not defined

eyed3/plugins/display.py:41: NameError
_____________________ TestDisplayParser.testComplexPattern _____________________

self = <tests.test_display_plugin.TestDisplayParser testMethod=testComplexPattern>

    def testComplexPattern(self):
        pattern = Pattern("Output: $format(Artist: $not-empty(%artist%,#t,none),bold=y)")
>       assert len(pattern.sub_patterns) == 2

tests/test_display_plugin.py:87: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
eyed3/plugins/display.py:31: in __get_sub_patterns
    self.__compile()
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = None

    def __compile(self):
        # TODO: add support for comments in pattern
>       parser = DisplayPatternParser(whitespace='')
E       NameError: name 'DisplayPatternParser' is not defined

eyed3/plugins/display.py:41: NameError
_______________________ TestDisplayParser.testTagPattern _______________________

self = <tests.test_display_plugin.TestDisplayParser testMethod=testTagPattern>

    def testTagPattern(self):
        pattern = Pattern("%comments,desc,lang,separation=|%")
>       assert len(pattern.sub_patterns) == 1

tests/test_display_plugin.py:75: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
eyed3/plugins/display.py:31: in __get_sub_patterns
    self.__compile()
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = None

    def __compile(self):
        # TODO: add support for comments in pattern
>       parser = DisplayPatternParser(whitespace='')
E       NameError: name 'DisplayPatternParser' is not defined

eyed3/plugins/display.py:41: NameError
______________________ TestDisplayParser.testTextPattern _______________________

self = <tests.test_display_plugin.TestDisplayParser testMethod=testTextPattern>

    def testTextPattern(self):
        pattern = Pattern("hello")
>       assert isinstance(pattern.sub_patterns[0], TextPattern)

tests/test_display_plugin.py:70: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
eyed3/plugins/display.py:31: in __get_sub_patterns
    self.__compile()
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = None

    def __compile(self):
        # TODO: add support for comments in pattern
>       parser = DisplayPatternParser(whitespace='')
E       NameError: name 'DisplayPatternParser' is not defined

eyed3/plugins/display.py:41: NameError
=========================== short test summary info ============================
FAILED tests/test_display_plugin.py::TestDisplayPlugin::testCommentsTag - Nam...
FAILED tests/test_display_plugin.py::TestDisplayPlugin::testComposer - NameEr...
FAILED tests/test_display_plugin.py::TestDisplayPlugin::testNotEmptyFunction
FAILED tests/test_display_plugin.py::TestDisplayPlugin::testNumberFormatFunction
FAILED tests/test_display_plugin.py::TestDisplayPlugin::testRepeatFunction - ...
FAILED tests/test_display_plugin.py::TestDisplayPlugin::testSimpleTags - Name...
FAILED tests/test_display_plugin.py::TestDisplayParser::testCompileException
FAILED tests/test_display_plugin.py::TestDisplayParser::testComplexPattern - ...
FAILED tests/test_display_plugin.py::TestDisplayParser::testTagPattern - Name...
FAILED tests/test_display_plugin.py::TestDisplayParser::testTextPattern - Nam...
================== 10 failed, 91 passed, 14 skipped in 1.48s ===================

For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.10/fedora-rawhide-x86_64/01955385-python-eyed3/

For all our attempts to build python-eyed3 with Python 3.10, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.10/package/python-eyed3/

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.10:
https://copr.fedorainfracloud.org/coprs/g/python/python3.10/

Let us know here if you have any questions.

Python 3.10 will be included in Fedora 35. To make that update smoother, we're building Fedora packages with early pre-releases of Python 3.10.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires), so if this package is required a lot, it's important for us to get it fixed soon.
We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Miro Hrončok 2021-06-04 20:13:15 UTC
This is a mass-posted update. Sorry if it is not 100% accurate to this bugzilla.


The Python 3.10 rebuild is in progress in a Koji side tag. If you manage to fix the problem, please commit the fix in the rawhide branch, but don't build the package in regular rawhide.

You can either build the package in the side tag, with:

    $ fedpkg build --target=f35-python

Or you can the build and we will eventually build it for you.

Note that the rebuild is still in progress, so not all (build) dependencies of this package might be available right away.

Thanks.

See also https://fedoraproject.org/wiki/Changes/Python3.10

If you have general questions about the rebuild, please use this mailing list thread: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/G47SGOYIQLRDTWGOSLSWERZSSHXDEDH5/

Comment 2 Miro Hrončok 2021-06-07 22:58:06 UTC
The f35-python side tag has been merged to Rawhide. From now on, build as you would normally build.

Comment 3 Miro Hrončok 2021-06-08 11:25:16 UTC
*** Bug 1968969 has been marked as a duplicate of this bug. ***

Comment 4 Miro Hrončok 2021-06-15 20:25:40 UTC
Hello,

This is the first reminder (step 3 from https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/#_package_removal_for_long_standing_ftbfs_and_fti_bugs).

If you know about this problem and are planning on fixing it, please acknowledge so by setting the bug status to ASSIGNED. If you don't have time to maintain this package, consider orphaning it, so maintainers of dependent packages realize the problem.

Comment 5 Miro Hrončok 2021-07-07 11:22:48 UTC
Hello,

This is the second reminder (step 4 from https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/#_package_removal_for_long_standing_ftbfs_and_fti_bugs).

If you know about this problem and are planning on fixing it, please acknowledge so by setting the bug status to ASSIGNED. If you don't have time to maintain this package, consider orphaning it, so maintainers of dependent packages realize the problem.


Note You need to log in before you can comment on or make changes to this bug.