Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1931055 - Review Request: elementary-settings-daemon - Settings Daemon for Pantheon
Summary: Review Request: elementary-settings-daemon - Settings Daemon for Pantheon
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: PantheonDesktopPackageReviews
TreeView+ depends on / blocked
 
Reported: 2021-02-20 10:42 UTC by Fabio Valentini
Modified: 2021-03-19 20:11 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-03-19 20:11:52 UTC
Type: ---
Embargoed:
zebob.m: fedora-review+


Attachments (Terms of Use)

Description Fabio Valentini 2021-02-20 10:42:08 UTC
Spec URL: https://decathorpe.fedorapeople.org/packages/elementary-settings-daemon.spec
SRPM URL: https://decathorpe.fedorapeople.org/packages/elementary-settings-daemon-1.0.0-0.1.20210219git7c8d748.fc33.src.rpm

Description:
Settings Daemon for Pantheon

Fedora Account System Username: decathorpe

koji scratch build for rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=62345256

Note: There have not been stable releases of this project yet, which is why a git snapshot is used for the package.

Comment 1 Robert-André Mauchin 🐧 2021-03-10 11:49:27 UTC
 - This should be the date you took the snapshot, not the date of the commit:

%global commitdate  20210219


Package approved.



Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "GNU General Public License v3.0 or
     later". 13 files have unknown license. Detailed output of licensecheck
     in /home/bob/packaging/review/elementary-settings-daemon/review-
     elementary-settings-daemon/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
     desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: elementary-settings-daemon-1.0.0-0.1.20210219git7c8d748.fc35.x86_64.rpm
          elementary-settings-daemon-debuginfo-1.0.0-0.1.20210219git7c8d748.fc35.x86_64.rpm
          elementary-settings-daemon-debugsource-1.0.0-0.1.20210219git7c8d748.fc35.x86_64.rpm
          elementary-settings-daemon-1.0.0-0.1.20210219git7c8d748.fc35.src.rpm
elementary-settings-daemon.x86_64: W: no-manual-page-for-binary io.elementary.settings-daemon
4 packages and 0 specfiles checked; 0 errors, 1 warnings.

Comment 2 Fabio Valentini 2021-03-10 13:33:34 UTC
(In reply to Robert-André Mauchin 🐧 from comment #1)

Thanks for the review!

>  - This should be the date you took the snapshot, not the date of the commit:
> 
> %global commitdate  20210219

I can't actually find anything about this in the Packaging Guidelines (neither general, nor Versioning, nor SourceURL guidelines).

I'm unsure whether specifying the snapshot date is meaningful at all, since we always assume that commit *hashes* are unique and can't be mutated (in contrast to git tags, which can be deleted, created to point at a different commit, and then force-pushed).

Comment 3 Tomas Hrcka 2021-03-10 22:52:54 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/elementary-settings-daemon

Comment 4 Fedora Update System 2021-03-11 14:51:27 UTC
FEDORA-2021-567a46af3d has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-567a46af3d

Comment 5 Fedora Update System 2021-03-11 19:52:05 UTC
FEDORA-2021-567a46af3d has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-567a46af3d`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-567a46af3d

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 6 Fedora Update System 2021-03-19 20:11:52 UTC
FEDORA-2021-567a46af3d has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.