Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 193240 - Review Request: XaraLX - Vector/general purpose graphics utility
Summary: Review Request: XaraLX - Vector/general purpose graphics utility
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Michael J Knox
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-05-26 14:53 UTC by Tom "spot" Callaway
Modified: 2007-11-30 22:11 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-08-01 22:02:48 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)

Description Tom "spot" Callaway 2006-05-26 14:53:21 UTC 
Spec URL: http://www.auroralinux.org/people/spot/review/XaraLX.spec
SRPM URL: http://www.auroralinux.org/people/spot/review/XaraLX-0.5-1.src.rpm
Description:
General purpose and vector graphics program, supports photo, graphics, and
illustration creation and editing.
Comment 1 Gérard Milmeister 2006-05-27 15:34:53 UTC 
Does not build in mock:
  "autoreconf: failed to run autopoint: No such file or directory"
Needs BuildReq: gettext-devel
Comment 2 Ralf Corsepius 2006-05-28 04:38:58 UTC 
(In reply to comment #1)
> Does not build in mock:
>   "autoreconf: failed to run autopoint: No such file or directory"
> Needs BuildReq: gettext-devel
You should not run autoreconf in specs - You should use patches.
Comment 3 Gérard Milmeister 2006-07-26 15:41:26 UTC 
The latest version 0.7 rev 1537 builds fine here.
Comment 4 Paul F. Johnson 2006-07-26 21:42:43 UTC 
#3 - have you got a spec file you can upload somewhere?
Comment 5 Gérard Milmeister 2006-07-26 22:17:30 UTC 
(In reply to comment #4)
> #3 - have you got a spec file you can upload somewhere?
I simply used the one from comment #1.
I suspect that spot is not very interesting in this package anymore or
is to busy with other things currently. Maybe someone else can step in?
Comment 6 Paul F. Johnson 2006-07-27 06:23:25 UTC 
#5 - someone has. me.
Comment 7 Paul F. Johnson 2006-07-27 12:56:33 UTC 
Spec URL: http://www.knox.net.nz/~nodoid/XaraLX.spec
SRPM URL: http://www.knox.net.nz/~nodoid/XaraLX-0.7-1.r1564.src.rpm

- bump to new version
- includes 64 bit fixes
- Additional docs
- fixed EOL for xaralx.htm
- fixed multiple mode errors for header and source files
- removed mixed use of spaces and tabs

The package builds cleanly on x86_64 with rpmlint not giving a single complaint!
I've not built it in mock yet (my testrig is not working happily today from a
remote login).
Comment 8 Michael J Knox 2006-07-27 21:45:55 UTC 
I will review this one. 

----------------------------------------

Review for release 1.r1564:
* RPM name is OK
* Source XaraLX-0.7r1564.tar.bz2 is the same as upstream


Needs work:
* BuildRequires: perl should not be included
  (wiki: PackagingGuidelines#Exceptions)

* Build failed in mock
autoreconf: failed to run autopoint: No such file or directory

Minor:
* Duplicate BuildRequires: automake (by libtool), autoconf (by libtool), perl
(by automake), gtk2-devel (by wxGTK-devel)
Comment 9 Paul F. Johnson 2006-07-27 23:31:54 UTC 
Spec URL: http://www.knox.net.nz/~nodoid/XaraLX.spec

(I've not uploaded a new src.rpm by agreement with the reviewer)

- changed group to Applications/Publishing
- fixed autoreconf problem (BR gettext-devel)
- removed dupes in BR
- removed BR perl
- added mime-info
- added examples
Comment 10 Paul F. Johnson 2006-07-30 23:48:06 UTC 
Spec URL: http://www.knox.net.nz/~nodoid/XaraLX.spec
SRPM URL: http://www.knox.net.nz/~nodoid/XaraLX-0.7-1.r1614.src.rpm

- bump to newer tarball
- Removed the examples from the main package
- Created examples subpackage
Comment 11 Paul F. Johnson 2006-07-31 20:14:12 UTC 
Spec URL: http://www.knox.net.nz/~nodoid/XaraLX.spec
Patch URL : Spec URL: http://www.knox.net.nz/~nodoid/xaralx.desktop.patch

- updated spec
- fixed desktop file
- removed unused (and empty) directory
Comment 12 Michael J Knox 2006-08-01 21:35:40 UTC 
Looks good Paul. Menu entry shows up now too. APPROVED. 

Please remember to close this review request once imported and built.
Comment 13 Paul F. Johnson 2006-08-01 22:02:48 UTC 
Thanks for that and such an easy review process!
Note You need to log in before you can comment on or make changes to this bug.