Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 193804 - Review Request: glitz
Summary: Review Request: glitz
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Ralf Corsepius
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks: FE-ACCEPT 192436
TreeView+ depends on / blocked
 
Reported: 2006-06-01 18:42 UTC by Eric Work
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-06-08 22:11:18 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 192436 0 medium CLOSED Review Request: xorg-x11-server-Xgl 2022-05-16 11:32:56 UTC

Description Eric Work 2006-06-01 18:42:00 UTC 
Spec URL: http://www.ece.ucdavis.edu/~ewwork/repo/5/SPECS/glitz.spec
SRPM URL: http://www.ece.ucdavis.edu/~ewwork/repo/5/SRPMS/glitz-0.5.6-1.src.rpm

Description:
Glitz is an OpenGL image compositing library. Glitz provides Porter/Duff
compositing of images and implicit mask generation for geometric primitives
including trapezoids, triangles, and rectangles.

This had been tested with mock and rpmlint.  This package is required to build Xgl.
Comment 1 Ralf Corsepius 2006-06-02 02:44:55 UTC 
Some comments:
* IMO, it should be considered to split this package into 2 subpackages: glitz
and glitz-glx, because the package internally consists of libglitz and several
backends, with libglitz-glx being one them.

Splitting it would allow more fine-grained deps, and thereby would help avoid
unnecessary deps of apps/libs based on glitz.

* The deps of the devel package don't seem to be correct:
- libglitz doesn't seem to depend on any X or GL library.
- libglitz-glx seems to depend libX11-devel and libGL-devel, but not on further
libX*-devel, in particular it doesn't not depend on libXt-devel.

* The package ships manpages, but doesn't install them. May-be it's worth
considering to install them.

* The configure script carries several options defaulting to true:
  --disable-glx           Disable glitz's GLX backend
  --disable-agl           Disable glitz's AGL backend
  --enable-egl            Enable glitz's EGL backend
  --disable-wgl           Disable glitz's WGL backend
This will render building this package outside of a chroot-environment
non-deterministic, should one of these GL backends land in Fedora.
I.e. I recommend to add 
--enable-glx --disable-agl --disable-egl --disable-wgl to %configure
Comment 2 Eric Work 2006-06-02 04:53:35 UTC 
I will be gone this weekend, but I will work on these issues in the near future
and update the packages for re-evaluation.  Thanks for the feedback.
Comment 3 Eric Work 2006-06-05 19:37:41 UTC 
Updated the SPEC with your recommendations.

SPEC file: http://www.ece.ucdavis.edu/~ewwork/repo/testing/SPECS/glitz.spec
SRPM file:
http://www.ece.ucdavis.edu/~ewwork/repo/testing/SRPMS/glitz-0.5.6-2.src.rpm
Comment 4 Ralf Corsepius 2006-06-07 09:55:11 UTC 
Some issues:
- glitz-devel contains pkg-config files, it therefore should
Requires: pkgconfig

- glitz-glx-devel contains pkg-config files, it therefore should
Requires: pkgconfig

- glitz-glx-devel depends on glitz-devel, it therefore must
Requires: glitz-devel
or
Requires: glitz-devel = %{version}-%{release}

- man3 manpages are programming manuals.
They should be part of the *-devel packages.
Comment 5 Eric Work 2006-06-07 15:26:21 UTC 
Updated package.

SPEC files: http://www.ece.ucdavis.edu/~ewwork/repo/testing/SPECS/glitz.spec
SRPM file:
http://www.ece.ucdavis.edu/~ewwork/repo/testing/SRPMS/glitz-0.5.6-3.src.rpm
Comment 6 Ralf Corsepius 2006-06-07 15:53:02 UTC 
APPROVED.
Note You need to log in before you can comment on or make changes to this bug.