Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1948092 - dasbus.error.DBusError: 'NoneType' object has no attribute 'upper'
Summary: dasbus.error.DBusError: 'NoneType' object has no attribute 'upper'
Keywords:
Status: CLOSED DUPLICATE of bug 1945914
Alias: None
Product: Fedora
Classification: Fedora
Component: python-blivet
Version: 34
Hardware: x86_64
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Vojtech Trefny
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard: abrt_hash:9d01d56085581d5f049c2c19a5e...
Depends On:
Blocks: F34FinalBlocker
TreeView+ depends on / blocked
 
Reported: 2021-04-10 01:46 UTC by Chris Murphy
Modified: 2021-04-12 17:18 UTC (History)
16 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-04-12 17:18:22 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)
File: anaconda-tb (665.01 KB, text/plain)
2021-04-10 01:46 UTC, Chris Murphy 		no flags Details
File: anaconda.log (13.43 KB, text/plain)
2021-04-10 01:46 UTC, Chris Murphy 		no flags Details
File: dbus.log (3.17 KB, text/plain)
2021-04-10 01:46 UTC, Chris Murphy 		no flags Details
File: environ (658 bytes, text/plain)
2021-04-10 01:46 UTC, Chris Murphy 		no flags Details
File: journalctl (487.09 KB, text/plain)
2021-04-10 01:47 UTC, Chris Murphy 		no flags Details
File: lsblk_output (1.54 KB, text/plain)
2021-04-10 01:47 UTC, Chris Murphy 		no flags Details
File: lvm.log (22.31 KB, text/plain)
2021-04-10 01:47 UTC, Chris Murphy 		no flags Details
File: nmcli_dev_list (1.62 KB, text/plain)
2021-04-10 01:47 UTC, Chris Murphy 		no flags Details
File: os_info (796 bytes, text/plain)
2021-04-10 01:47 UTC, Chris Murphy 		no flags Details
File: program.log (15.65 KB, text/plain)
2021-04-10 01:47 UTC, Chris Murphy 		no flags Details
File: storage.log (71.21 KB, text/plain)
2021-04-10 01:47 UTC, Chris Murphy 		no flags Details
View All

Description Chris Murphy 2021-04-10 01:46:53 UTC 
Description of problem:
qemu-kvm, uefi, raw backing file (truncate -s 100g file)
1. Boot Fedora-Workstation-Live-x86_64-34-20210409.n.0.iso
2. Custom partitioning, select Standard partitioning scheme
3. curiously there is an Unknown item in the list which is strange because this should be an empty volume, so I clicked on Unknown and get a crash.

Version-Release number of selected component:
anaconda-core-34.24.8-1.fc34.x86_64

The following was filed automatically by anaconda:
anaconda 34.24.8 exception report
Traceback (most recent call first):
  File "/usr/lib/python3.9/site-packages/dasbus/client/handler.py", line 497, in _handle_method_error
    raise exception from None
  File "/usr/lib/python3.9/site-packages/dasbus/client/handler.py", line 477, in _get_method_reply
    return self._handle_method_error(error)
  File "/usr/lib/python3.9/site-packages/dasbus/client/handler.py", line 444, in _call_method
    return self._get_method_reply(
  File "/usr/lib64/python3.9/site-packages/pyanaconda/ui/gui/spokes/custom_storage.py", line 696, in _setup_fstype_combo
    self._device_tree.GetFormatTypeData(fs_type)
  File "/usr/lib64/python3.9/site-packages/pyanaconda/ui/gui/spokes/custom_storage.py", line 813, in _populate_right_side
    self._setup_fstype_combo(self._request.device_type, self._request.format_type, format_types)
  File "/usr/lib64/python3.9/site-packages/pyanaconda/ui/gui/spokes/custom_storage.py", line 1422, in on_selector_clicked
    self._populate_right_side(self._accordion.current_selector)
  File "/usr/lib64/python3.9/site-packages/pyanaconda/ui/gui/spokes/custom_storage.py", line 1041, in _show_mountpoint
    self.on_selector_clicked(None, page.members[0])
  File "/usr/lib64/python3.9/site-packages/pyanaconda/ui/gui/spokes/custom_storage.py", line 1433, in on_page_clicked
    self._show_mountpoint(page=page, mountpoint=mountpoint_to_show)
  File "/usr/lib64/python3.9/site-packages/pyanaconda/ui/gui/spokes/lib/accordion.py", line 99, in _on_expanded
    cb(child)
dasbus.error.DBusError: 'NoneType' object has no attribute 'upper'

Additional info:
addons:         com_redhat_kdump
cmdline:        /usr/bin/python3  /sbin/anaconda --liveinst --graphical
cmdline_file:   BOOT_IMAGE=/images/pxeboot/vmlinuz root=live:CDLABEL=Fedora-WS-Live-34-20210409-n-0 rd.live.image quiet
dnf.librepo.log: 
executable:     /sbin/anaconda
hashmarkername: anaconda
kernel:         5.11.11-300.fc34.x86_64
other involved packages: python3-dasbus-1.4-3.fc34.noarch, anaconda-gui-34.24.8-1.fc34.x86_64
product:        Fedora
release:        Fedora release 34 (Thirty Four)
release_type:   pre-release
type:           anaconda
version:        34
Comment 1 Chris Murphy 2021-04-10 01:46:56 UTC 
Created attachment 1770811 [details]
File: anaconda-tb
Comment 2 Chris Murphy 2021-04-10 01:46:57 UTC 
Created attachment 1770812 [details]
File: anaconda.log
Comment 3 Chris Murphy 2021-04-10 01:46:58 UTC 
Created attachment 1770813 [details]
File: dbus.log
Comment 4 Chris Murphy 2021-04-10 01:46:59 UTC 
Created attachment 1770814 [details]
File: environ
Comment 5 Chris Murphy 2021-04-10 01:47:00 UTC 
Created attachment 1770815 [details]
File: journalctl
Comment 6 Chris Murphy 2021-04-10 01:47:01 UTC 
Created attachment 1770816 [details]
File: lsblk_output
Comment 7 Chris Murphy 2021-04-10 01:47:02 UTC 
Created attachment 1770817 [details]
File: lvm.log
Comment 8 Chris Murphy 2021-04-10 01:47:03 UTC 
Created attachment 1770818 [details]
File: nmcli_dev_list
Comment 9 Chris Murphy 2021-04-10 01:47:04 UTC 
Created attachment 1770819 [details]
File: os_info
Comment 10 Chris Murphy 2021-04-10 01:47:04 UTC 
Created attachment 1770820 [details]
File: program.log
Comment 11 Chris Murphy 2021-04-10 01:47:05 UTC 
Created attachment 1770821 [details]
File: storage.log
Comment 12 Chris Murphy 2021-04-10 01:51:04 UTC 
Ahh OK the /dev/vda device is 512 bytes in the VM! I skipped the g in the actual truncate command.

truncate -s 100 f34w-ext4.raw

Oops.
Comment 13 Fedora Blocker Bugs Application 2021-04-10 01:51:37 UTC 
Proposed as a Blocker for 34-final by Fedora user chrismurphy using the blocker tracking app because:

 Beta:
When using both the installer-native and the blivet-gui-based custom partitioning flow, the installer must be able to: 
- Reject or disallow invalid disk and volume configurations without crashing.
Comment 14 Kamil Páral 2021-04-12 07:22:10 UTC 
Chris, does this also happen if you create 1M, 10M, 100M disk? Or does it happen just for extremely small (<1kB) disks?
Comment 15 Vendula Poncova 2021-04-12 08:54:27 UTC 
From storage.log:

INFO:blivet:DiskLabel.parted_device returning None
DEBUG:blivet:get_format('disklabel') returning DiskLabel instance with object id 151
INFO:blivet:DiskLabel.parted_device returning None
INFO:blivet:DiskLabel.parted_device returning None
WARNING:dasbus.server.handler:The call org.fedoraproject.Anaconda.Modules.Storage.DeviceTree.Viewer.GetFormatTypeData has failed with an exception:
Traceback (most recent call last):
  File "/usr/lib/python3.9/site-packages/dasbus/server/handler.py", line 418, in _method_callback
    result = self._handle_call(
  File "/usr/lib/python3.9/site-packages/dasbus/server/handler.py", line 234, in _handle_call
    return handler(*parameters)
  File "/usr/lib64/python3.9/site-packages/pyanaconda/modules/storage/devicetree/viewer_interface.py", line 89, in GetFormatTypeData
    return DeviceFormatData.to_structure(self.implementation.get_format_type_data(name))
  File "/usr/lib64/python3.9/site-packages/pyanaconda/modules/storage/devicetree/viewer.py", line 183, in get_format_type_data
    return self._get_format_data(fmt)
  File "/usr/lib64/python3.9/site-packages/pyanaconda/modules/storage/devicetree/viewer.py", line 195, in _get_format_data
    data.description = fmt.name or ""
  File "/usr/lib/python3.9/site-packages/blivet/threads.py", line 53, in run_with_lock
    return m(*args, **kwargs)
  File "/usr/lib/python3.9/site-packages/blivet/formats/disklabel.py", line 322, in name
    return _str % {"name": _(self._name), "type": self.label_type.upper()}
AttributeError: 'NoneType' object has no attribute 'upper'

It seems to be a duplicate of the bug 1945914. Reassigning to blivet.
Comment 16 Vojtech Trefny 2021-04-12 11:59:01 UTC 
Chris: I wasn't able to reproduce the issue with the storage configuration you described, but I agree with Vendy, this looks like a duplicate of 1945914, can you try with the updates image from this bug? https://vtrefny.fedorapeople.org/img/rhbz1945914.img
Comment 17 František Zatloukal 2021-04-12 16:42:17 UTC 
Discussed during the 2021-04-12 blocker review meeting: [1]

The decision to classify this bug was postponed:

"We agreed to delay this while we get more detail on exactly what the failure case is, and if it's a dupe of 1945914 (or at least fixed by the same change)."

[1] https://meetbot-raw.fedoraproject.org/fedora-blocker-review/2021-04-12/f34-blocker-review.2021-04-12-16.02.log.txt
Comment 18 Chris Murphy 2021-04-12 17:17:45 UTC 
I can trigger the crash (4 for 4 attempts) if the raw backing file is 512 bytes or less. And with the updates.img in c17 it does not crash.
Comment 19 Chris Murphy 2021-04-12 17:18:22 UTC 

*** This bug has been marked as a duplicate of bug 1945914 ***
Note You need to log in before you can comment on or make changes to this bug.