Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 195015 - Review Request: xpa
Summary: Review Request: xpa
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Michael J Knox
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
: 195016 (view as bug list)
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-06-14 13:32 UTC by Sergio Pascual
Modified: 2008-07-17 00:08 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-06-22 11:29:21 UTC
Type: ---
Embargoed:
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Sergio Pascual 2006-06-14 13:32:46 UTC
Spec URL: http://t-rex.fis.ucm.es/~spr/xpa.spec
SRPM URL: http://t-rex.fis.ucm.es/~spr/xpa-2.1.6-2.fc5.src.rpm
Description: 
The XPA messaging system provides seamless communication between many kinds
of Unix programs, including X programs and Tcl/Tk programs.
It also provides an easy way for users to communicate with these
XPA-enabled programs by executing XPA client commands in the shell or by
utilizing such commands in scripts. Because XPA works both at the programming
level and the shell level, it is a powerful tool for unifying any
analysis environment: users and programmers have great flexibility
in choosing the best level or levels at which to access XPA services,
and client access can be extended or modified easily at any time.

Comment 1 Paul Howarth 2006-06-14 13:47:27 UTC
*** Bug 195016 has been marked as a duplicate of this bug. ***

Comment 2 Michael J Knox 2006-06-17 08:24:09 UTC
* RPM name is OK
* Source xpa-2.1.6.tar.gz is the same as upstream
* This is the latest version
* Builds fine in mock
* rpmlint of xpa-devel looks OK
* rpmlint of xpa looks OK
* File list of xpa-devel looks OK
* File list of xpa looks OK

I would recommend you just add some white space between the %package devel and
%description devel. Same again for %install and %clean, just improves the flow
and readability of your spec file. 

If you make those changes, I see no reason why I can't approve this package. 

Comment 3 Sergio Pascual 2006-06-19 09:13:37 UTC
I have made the changes you recommend:

http://t-rex.fis.ucm.es/~spr/xpa.spec
http://t-rex.fis.ucm.es/~spr/xpa-2.1.6-3.fc5.src.rpm

Comment 4 Michael J Knox 2006-06-21 22:34:28 UTC
Thank you. You can consider this APPROVED. 

Please close this bug report with NEXTRELEASE once imported into CVS.

Comment 5 Sergio Pascual 2008-07-16 19:34:47 UTC
Package Change Request
======================
Package Name: foobar
New Branches: EL-5


Comment 6 Kevin Fenzi 2008-07-17 00:08:36 UTC
I take it you meant the Package Name to be xpa here?

cvs done.


Note You need to log in before you can comment on or make changes to this bug.