Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1953541 - python-molten fails to build with Python 3.10: molten.errors.DIError: cannot resolve parameter a_class: 'AClass' of function <function test_apps_can_be_injected_into_singleton_components.<locals>.test at 0x7fc6b9701a20>
Summary: python-molten fails to build with Python 3.10: molten.errors.DIError: cannot ...
Keywords:
Status: CLOSED WORKSFORME
Alias: None
Product: Fedora
Classification: Fedora
Component: python-molten
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Anna Khaitovich
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 1969035 (view as bug list)
Depends On: 1968996
Blocks: PYTHON3.10 F35FTBFS F35FailsToInstall
TreeView+ depends on / blocked
 
Reported: 2021-04-26 10:47 UTC by Tomáš Hrnčiar
Modified: 2023-09-15 01:05 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-06-16 23:57:13 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Tomáš Hrnčiar 2021-04-26 10:47:34 UTC
python-molten fails to build with Python 3.10.0a7.

=================================== FAILURES ===================================
_____________ test_apps_can_be_injected_into_singleton_components ______________

    def test_apps_can_be_injected_into_singleton_components():
        # Given that I have a singleton component that requests the app
        class AClass:  # noqa
            def __init__(self, app):
                self.app = app
    
        class AComponent:
            is_cacheable = True
            is_singleton = True
    
            def can_handle_parameter(self, parameter):
                return parameter.annotation is AClass
    
            def resolve(self, app: BaseApp):
                return AClass(app)
    
        app = App(components=[AComponent()])
    
        # When I resolve that component
        def test(a_class: AClass):
            # Then its app property should be the app instance
            assert a_class.app is app
    
        resolver = app.injector.get_resolver()
>       resolver.resolve(test)()

tests/test_app.py:501: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

params = {}, parameter = <Parameter "a_class: 'AClass'">
component = <molten.components.UploadedFileComponent object at 0x7fc6b9e22f50>

    @functools.wraps(fn)
    def resolved_fn(**params: Any) -> Any:
        for parameter in _get_parameters(fn):
            if parameter.name in params:
                continue
    
            # When Parameter is requested then we assume that the
            # caller actually wants the parameter that resolved the
            # current component that's being resolved.  See QueryParam
            # or Header components for an example.
            if parameter.annotation is Parameter:
                params[parameter.name] = resolving_parameter
                continue
    
            # When a DependencyResolver is requested, then we assume
            # the caller wants this instance.
            if parameter.annotation is DependencyResolver:
                params[parameter.name] = self
                continue
    
            # If our instances contains an exact match for a type,
            # then we return that.  This is used to inject the current
            # Request object among other things.
            try:
                params[parameter.name] = self.instances[parameter.annotation]
                continue
            except KeyError:
                pass
    
            for component in self.components:
                if component.can_handle_parameter(parameter):
                    try:
                        params[parameter.name] = self.instances[component]
                    except KeyError:
                        factory = self.resolve(component.resolve, resolving_parameter=parameter)
                        params[parameter.name] = instance = factory()
    
                        if getattr(component, "is_cacheable", True):
                            self.instances[component] = instance
    
                    break
            else:
>               raise DIError(f"cannot resolve parameter {parameter} of function {fn}")
E               molten.errors.DIError: cannot resolve parameter a_class: 'AClass' of function <function test_apps_can_be_injected_into_singleton_components.<locals>.test at 0x7fc6b9701a20>

molten/dependency_injection.py:189: DIError

---------- coverage: platform linux, python 3.10.0-alpha-7 -----------
Coverage HTML written to dir htmlcov

=========================== short test summary info ============================
FAILED tests/test_app.py::test_apps_can_be_injected_into_singleton_components
======================== 1 failed, 247 passed in 2.62s =========================

For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.10/fedora-rawhide-x86_64/02143294-python-molten/

For all our attempts to build python-molten with Python 3.10, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.10/package/python-molten/

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.10:
https://copr.fedorainfracloud.org/coprs/g/python/python3.10/

Let us know here if you have any questions.

Python 3.10 will be included in Fedora 35. To make that update smoother, we're building Fedora packages with early pre-releases of Python 3.10.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires), so if this package is required a lot, it's important for us to get it fixed soon.
We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Miro Hrončok 2021-06-04 20:14:41 UTC
This is a mass-posted update. Sorry if it is not 100% accurate to this bugzilla.


The Python 3.10 rebuild is in progress in a Koji side tag. If you manage to fix the problem, please commit the fix in the rawhide branch, but don't build the package in regular rawhide.

You can either build the package in the side tag, with:

    $ fedpkg build --target=f35-python

Or you can the build and we will eventually build it for you.

Note that the rebuild is still in progress, so not all (build) dependencies of this package might be available right away.

Thanks.

See also https://fedoraproject.org/wiki/Changes/Python3.10

If you have general questions about the rebuild, please use this mailing list thread: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/G47SGOYIQLRDTWGOSLSWERZSSHXDEDH5/

Comment 2 Miro Hrončok 2021-06-07 22:59:16 UTC
The f35-python side tag has been merged to Rawhide. From now on, build as you would normally build.

Comment 3 Miro Hrončok 2021-06-08 11:28:35 UTC
*** Bug 1969035 has been marked as a duplicate of this bug. ***

Comment 4 Miro Hrončok 2021-06-15 20:27:17 UTC
Hello,

This is the first reminder (step 3 from https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/#_package_removal_for_long_standing_ftbfs_and_fti_bugs).

If you know about this problem and are planning on fixing it, please acknowledge so by setting the bug status to ASSIGNED. If you don't have time to maintain this package, consider orphaning it, so maintainers of dependent packages realize the problem.

Comment 5 Miro Hrončok 2021-06-16 23:57:13 UTC
Hello,

Please note that this comment was generated automatically. If you feel that this output has mistakes, please contact me via email (mhroncok).

All subpackages of a package against which this bug was filled are now installable or removed from Fedora 35.

Thanks for taking care of it!

Comment 6 Red Hat Bugzilla 2023-09-15 01:05:41 UTC
The needinfo request[s] on this closed bug have been removed as they have been unresolved for 500 days


Note You need to log in before you can comment on or make changes to this bug.