Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 196621 - Review Request: perl-IO-Digest - Perl module to calculate digests while reading or writing
Summary: Review Request: perl-IO-Digest - Perl module to calculate digests while readi...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jason Tibbitts
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On: 196623
Blocks: FE-ACCEPT 196629
TreeView+ depends on / blocked
 
Reported: 2006-06-26 01:54 UTC by Ian Burrell
Modified: 2008-06-16 15:58 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-06-29 06:54:42 UTC
Type: ---
Embargoed:
kevin: fedora-cvs+

Attachments (Terms of Use)

Description Ian Burrell 2006-06-26 01:54:41 UTC 
Spec URL: http://znark.com/fedora/perl-IO-Digest.spec
SRPM URL: http://znark.com/fedora/perl-IO-Digest-0.10-2.src.rpm
Description: This module allows you to calculate digests while reading or writing file handles. This avoids the case you need to reread the same content to compute the digests after written a file.

It is required by perl-SVK.
Comment 1 Ian Burrell 2006-06-28 06:22:03 UTC 
Fixed rpmlint warnings.

http://znark.com/fedora/perl-IO-Digest-0.10.spec
http://znark.com/fedora/perl-IO-Digest-0.10-3.src.rpm
Comment 2 Jason Tibbitts 2006-06-29 00:29:42 UTC 
I cannot fetch the spec via that URL.  I can get the srpm fine, however.

You have a duplicated dependency on PerlIO::via::dynamic.  Since you've just
packaged this, I think it safe to say that the necessary version is in Extras
and the dependency can be dropped.  Otherwise you'll need to filter.

Review:
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.  License text not included upstream. 
* source files match upstream:
   0448841e0559c2c19c7e8001ef087e26  IO-Digest-0.10.tar.gz
* latest version is being packaged.
* BuildRequires are proper.
* package builds in mock (development, x86_64).
* rpmlint is silent.
X a duplicated dependency:
   perl(IO::Digest) = 0.10
   perl-IO-Digest = 0.10-3.fc6
  =
   perl >= 0:5.008
   perl(:MODULE_COMPAT_5.8.8)
   perl(Digest)
X  perl(PerlIO::via::dynamic)
X  perl(PerlIO::via::dynamic) >= 0.10
   perl(strict)
   perl(warnings)
* no shared libraries are present.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* %clean is present.
* %check is present and all tests pass:
   All tests successful.
   Files=2, Tests=4,  0 wallclock secs ( 0.04 cusr +  0.04 csys =  0.08 CPU)
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.
Comment 3 Ian Burrell 2006-06-29 00:40:51 UTC 
Fixed duplicated dependency.

Spec: http://znark.com/fedora/perl-IO-Digest.spec
SRPMS: http://znark.com/fedora/perl-IO-Digest-0.10-4.src.rpm
Comment 4 Jason Tibbitts 2006-06-29 01:26:54 UTC 
The duplicated dependency is indeed fixed.

APPROVED
Comment 5 Ian Burrell 2006-06-29 06:54:42 UTC 
Built for devel.
Comment 6 Ian Burrell 2008-06-12 00:27:10 UTC 
Package Change Request
======================
Package Name: perl-IO-Digest
New Branches: EL-4 EL-5
Comment 7 Kevin Fenzi 2008-06-12 15:55:26 UTC 
cvs done.
Comment 8 Ian Burrell 2008-06-13 23:37:09 UTC 
Package Change Request
======================
Package Name: perl-IO-Digest
New Branches: EL-4 EL-5

I don't see the EL-4 and EL-5 branches for perl-IO-Digest and it has been a
whole day.
Comment 9 Kevin Fenzi 2008-06-16 15:58:33 UTC 
sorry about that... try now?
Note You need to log in before you can comment on or make changes to this bug.