Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at
Bug 197048 - Review Request: pam_script
Summary: Review Request: pam_script
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Jason Tibbitts
QA Contact: Fedora Package Reviews List
Depends On:
TreeView+ depends on / blocked
Reported: 2006-06-28 09:46 UTC by Michael J Knox
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2006-06-28 22:07:17 UTC
Type: ---

Attachments (Terms of Use)

Description Michael J Knox 2006-06-28 09:46:30 UTC
Spec URL:

Description: pam_script is a module which allows to execute scripts after opening
and/or closing a session using PAM.

Comment 1 Jason Tibbitts 2006-06-28 15:06:17 UTC
This fails to build in mock:

+ make
gcc -Wall -pedantic -fPIC -shared  -o pam_script.c
pam_script.c:23:34: error: security/_pam_macros.h: No such file or directory
pam_script.c:24:34: error: security/pam_modules.h: No such file or directory
pam_script.c:48: error: expected ')' before '*' token
pam_script.c:83: error: expected ')' before '*' token
pam_script.c:240: error: expected '=', ',', ';', 'asm' or '__attribute__' before
pam_script.c:249: error: expected '=', ',', ';', 'asm' or '__attribute__' before
pam_script.c:259: error: expected '=', ',', ';', 'asm' or '__attribute__' before
pam_script.c:296: error: expected '=', ',', ';', 'asm' or '__attribute__' before
make: *** [] Errror 1

Adding BuildRequires: pam-devel fixes this up; rpmlint is happy with the
resulting package.  I'll assume the BR: is there for the purposes of this review.

The compiler isn't called with the appropriate flags.  You need to pass in
${optflags} somehow.  This also causes the -debuginfo package to be broken.

* package meets naming and packaging guidelines (pam modules use an underscore).
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.  License text not included upstream. 
* source files match upstream:
   9f1031154718b79d6ee79c9c5231b1d4  pam-script-0.1.7.tar.gz
* latest version is being packaged.
X BuildRequires are proper.
* package builds in mock (development, x86_64) (after adding BR: pam-devel)
* rpmlint is silent.
* final provides and requires are sane:
   pam_script = 0.1.7-1.fc6
* shared libraries are present, internal to pam.
* package is not relocatable.
* owns the directories it creates (doesn't own /lib/security, but I think pam is
a requirement for any running system)
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* %clean is present.
* %check is not present; no test suite upstream.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.

Comment 2 Michael J Knox 2006-06-28 19:55:15 UTC
thanks for the review..

updated package ans spec

Spec URL:

Comment 3 Michael J Knox 2006-06-28 19:55:59 UTC
Sorry.. incorrect URLs, trying again. 

Spec URL:

Comment 4 Jason Tibbitts 2006-06-28 21:00:26 UTC
Looks good; the package builds fine, the compiler is called with the proper
flags and the debuginfo package includes the files it's supposed to.


Comment 5 Michael J Knox 2006-06-28 22:07:17 UTC
Cheers for the review, imported into CVS and building on devel. 

Note You need to log in before you can comment on or make changes to this bug.