Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 197302 - Review Request: perl-Math-Round
Summary: Review Request: perl-Math-Round
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jason Tibbitts
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks: FE-ACCEPT 197304
TreeView+ depends on / blocked
 
Reported: 2006-06-30 00:17 UTC by Chris Weyl
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-07-03 23:51:57 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)

Description Chris Weyl 2006-06-30 00:17:55 UTC 
Spec URL: http://home.comcast.net/~ckweyl/perl-Math-Round.spec
SRPM URL: http://home.comcast.net/~ckweyl/perl-Math-Round-0.05-0.fc5.src.rpm

Description:
Math::Round supplies functions that will round numbers in different ways. The
functions round and nearest are exported by default; others are available as
described below. "use ... qw(:all)" exports all functions.
Comment 1 Jason Tibbitts 2006-07-03 20:12:24 UTC 
BR: perl is not necessary (not a blocker).
No need to pass OPTIMIZE for a noarch package (not a blocker).

Review:
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.  License text not included upstream.
* source files match upstream:
   ef35f988b32be4af3b3ccee131ece87f  Math-Round-0.05.tar.gz
* latest version is being packaged.
O BuildRequires are proper.
* package builds in mock (development, x86_64).
* rpmlint is silent.
* final provides and requires are sane:
   perl(Math::Round) = 0.05
   perl-Math-Round = 0.05-0.fc6
  =
   perl(:MODULE_COMPAT_5.8.8)
   perl(Exporter)
   perl(POSIX)
   perl(strict)
   perl(vars)
* no shared libraries are present.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* %clean is present.
* %check is present and all tests pass:
   nhimult..........ok 11
   All tests successful.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.

APPROVED
Comment 2 Chris Weyl 2006-07-03 23:51:57 UTC 
Imported to cvs and built for devel (job 12000!); will build for FC-4,5 after
branching takes place.

Thanks! :)
Note You need to log in before you can comment on or make changes to this bug.