Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 197304 - Review Request: perl-WWW-Myspace
Summary: Review Request: perl-WWW-Myspace
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jason Tibbitts
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On: 197292 197293 197298 197302
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-06-30 00:53 UTC by Chris Weyl
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-07-06 00:10:35 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Chris Weyl 2006-06-30 00:53:07 UTC
Spec URL: http://home.comcast.net/~ckweyl/perl-WWW-Myspace.spec
SRPM URL: http://home.comcast.net/~ckweyl/perl-WWW-Myspace-0.49-0.fc5.src.rpm

Description:
WWW::Myspace.pm provides methods to access your myspace.com account and
functions automatically. It provides a simple interface for scripts to log in,
access lists of friends, scan user's profiles, retreive profile data, send
messages, and post comments.

Comment 1 Jason Tibbitts 2006-07-05 21:54:47 UTC
I added perl-Locale-SubCountry to my local repo to test this.

It looks like RPM bugs strike again; there are no manual dependencies in this
package (save the MODULE_COMPAT thing) but RPM somehow extracts these:

perl(WWW::Myspace)
perl(WWW::Myspace) >= 0.21

which will probably need to be filtered.

Review:
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.  License text not included upstream.
* source files match upstream:
   655665da1b696e4b7d30989d623356e9  WWW-Myspace-0.49.tar.gz
* latest version is being packaged.
O BuildRequires are proper (redundant BR: perl not a blocker)
* package builds in mock (development, x86_64) with one local package.
* rpmlint is silent.
X final provides and requires are sane:
   perl(WWW::Myspace) = 0.49
   perl(WWW::Myspace::Comment) = 0.15
   perl(WWW::Myspace::Data) = 0.05
   perl(WWW::Myspace::FriendAdder) = 0.08
   perl(WWW::Myspace::FriendChanges) = 0.03
   perl(WWW::Myspace::Message) = 0.13
   perl(WWW::Myspace::MyBase) = 0.3
   perl-WWW-Myspace = 0.49-0.fc6
  =
   /usr/bin/perl
   perl(:MODULE_COMPAT_5.8.8)
   perl(Carp)
   perl(Class::DBI)
   perl(Class::DBI::AbstractSearch)
   perl(Class::DBI::Loader)
   perl(Config::General)
   perl(Contextual::Return)
   perl(Data::Dumper)
   perl(DateTime)
   perl(File::Spec::Functions)
   perl(IO::Prompt)
   perl(List::Compare)
   perl(Locale::SubCountry)
   perl(Math::Round)
   perl(Params::Validate)
   perl(Scalar::Util)
   perl(Spiffy)
   perl(WWW::Mechanize)
X  perl(WWW::Myspace)
X  perl(WWW::Myspace) >= 0.21
   perl(WWW::Myspace::Comment)
   perl(WWW::Myspace::Data)
   perl(WWW::Myspace::FriendAdder)
   perl(WWW::Myspace::Message) >= 0.08
   perl(WWW::Myspace::MyBase)
   perl(YAML)
   perl(strict)
   perl(warnings)
* no shared libraries are present.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* %clean is present.
* %check is present but necessarily disabled.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.


Comment 2 Chris Weyl 2006-07-05 23:16:39 UTC
It's interesting to note that while rpmlint issues warnings for errant provides,
it doesn't do the same for requires.

Filter added.

Spec URL: http://home.comcast.net/~ckweyl/perl-WWW-Myspace.spec
SRPM URL: http://home.comcast.net/~ckweyl/perl-WWW-Myspace-0.49-0.1.fc5.src.rpm

Comment 3 Jason Tibbitts 2006-07-05 23:39:25 UTC
Looks good; the requires list is now:
   /usr/bin/perl
   perl(:MODULE_COMPAT_5.8.8)
   perl(Carp)
   perl(Class::DBI)
   perl(Class::DBI::AbstractSearch)
   perl(Class::DBI::Loader)
   perl(Config::General)
   perl(Contextual::Return)
   perl(Data::Dumper)
   perl(DateTime)
   perl(File::Spec::Functions)
   perl(IO::Prompt)
   perl(List::Compare)
   perl(Locale::SubCountry)
   perl(Math::Round)
   perl(Params::Validate)
   perl(Scalar::Util)
   perl(Spiffy)
   perl(WWW::Mechanize)
   perl(WWW::Myspace) >= 0.21
   perl(WWW::Myspace::Comment)
   perl(WWW::Myspace::Data)
   perl(WWW::Myspace::FriendAdder)
   perl(WWW::Myspace::Message) >= 0.08
   perl(WWW::Myspace::MyBase)
   perl(YAML)
   perl(strict)
   perl(warnings)

APPROVED

Comment 4 Chris Weyl 2006-07-06 00:10:35 UTC
+Import to CVS
+Add to owners.list
+Bump release, build for devel
+devel build succeeds
+Request branching 
+Close bug

Thanks for the review!


Note You need to log in before you can comment on or make changes to this bug.