Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 197461 - Review Request: perl-Class-InsideOut
Summary: Review Request: perl-Class-InsideOut
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jochen Schmitt
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-07-02 05:56 UTC by Chris Weyl
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-07-07 03:29:36 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)

Description Chris Weyl 2006-07-02 05:56:31 UTC 
Spec URL: http://home.comcast.net/~ckweyl/perl-Class-InsideOut.spec
SRPM URL: http://home.comcast.net/~ckweyl/perl-Class-InsideOut-1.00-0.fc5.src.rpm

Description: 
This is a simple, safe and streamlined toolkit for building inside-out
objects. Unlike most other inside-out object building modules already on CPAN,
this module aims for minimalism and robustness:

* Does not require derived classes to subclass it
* Uses no source filters, attributes or CHECK blocks
* Supports any underlying object type including foreign
  inheritance
* Does not leak memory on object destruction
* Overloading-safe
* Thread-safe for Perl 5.8 or better
* mod_perl compatible
* Makes no assumption about inheritance or initializer needs
Comment 1 Jochen Schmitt 2006-07-03 19:31:08 UTC 
Good:
+ Tarball match with upstream.
+ rpmlint doesn't complaints source rpm.
+ Local build works fine.
+ Package contains verbatin copy of the license.
+ rpmlint doesn't complaint the binary rpm.

Bad:
- Perl have not to be inclussion in the BR.
Comment 2 Chris Weyl 2006-07-05 18:08:00 UTC 
Is the inclusion of perl a blocker for approval?  The review guidelines say:

"- MUST: All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines; inclusion of
those as BuildRequires is optional. Apply common sense."
Comment 3 Ville Skyttä 2006-07-05 18:26:49 UTC 
(In reply to comment #2)
> Is the inclusion of perl a blocker for approval?

s/of perl a/of perl in BR a/: no.  On the other hand, FWIW, in this case there
are various other perl(Foo::Bar) build dependencies which are unlikely to
suddenly change so that the main perl package would not be pulled in.
Comment 4 Jochen Schmitt 2006-07-06 15:53:07 UTC 
 ihave read the Packaging Guidelines again. The packages in the exception list
may be listed as a BR optional.

So that this is not a blocker.

I will APPROVED your package now.
Comment 5 Chris Weyl 2006-07-07 03:29:36 UTC 
+Import to CVS
+Add to owners.list
+Bump release, build for devel
+devel build succeeds
+Request branching 
+Close bug

Thanks for the review!
Note You need to log in before you can comment on or make changes to this bug.