Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1984192 - Review Request: rust-watchman_client - Client for the Watchman file watching service
Summary: Review Request: rust-watchman_client - Client for the Watchman file watching ...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Michel Lind
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1984191
Blocks: 1965963
TreeView+ depends on / blocked
 
Reported: 2021-07-20 22:45 UTC by Davide Cavalca
Modified: 2021-08-04 17:30 UTC (History)
2 users (show)

Fixed In Version: rust-watchman_client-0.7.1-1.fc35
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-08-04 17:30:56 UTC
Type: ---
Embargoed:
michel: fedora-review+


Attachments (Terms of Use)

Description Davide Cavalca 2021-07-20 22:45:34 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/rust-watchman_client/rust-watchman_client.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-watchman_client/rust-watchman_client-0.7.1-1.fc35.src.rpm

Description:
Client for the Watchman file watching service.

Fedora Account System Username: dcavalca

Comment 1 Michel Lind 2021-07-21 22:12:24 UTC
Taking this review

Comment 2 Michel Lind 2021-07-21 22:40:51 UTC
Looks fine, APPROVED. Note: please file an issue for the missing LICENSE file in the crate, and put a link in the spec

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- Dist tag is present.


===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[-]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated". 9 files have unknown license. Detailed
     output of licensecheck in
     /home/michel/src/fedora/reviews/1984192-rust-
     watchman_client/licensecheck.txt
[-]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[!]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[!]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rust-
     watchman_client-devel , rust-watchman_client+default-devel
     => known Rust packaging bug
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: rust-watchman_client-devel-0.7.1-1.fc35.noarch.rpm
          rust-watchman_client+default-devel-0.7.1-1.fc35.noarch.rpm
          rust-watchman_client-0.7.1-1.fc35.src.rpm
rust-watchman_client-devel.noarch: W: invalid-url URL: https://crates.io/crates/watchman_client HTTP Error 404: Not Found
rust-watchman_client-devel.noarch: W: no-documentation
rust-watchman_client-devel.noarch: W: hidden-file-or-dir /usr/share/cargo/registry/watchman_client-0.7.1/.cargo-checksum.json
rust-watchman_client+default-devel.noarch: W: invalid-url URL: https://crates.io/crates/watchman_client HTTP Error 404: Not Found
rust-watchman_client+default-devel.noarch: W: no-documentation
rust-watchman_client.src: W: invalid-url URL: https://crates.io/crates/watchman_client HTTP Error 404: Not Found
rust-watchman_client.src:76: W: macro-in-%changelog %autochangelog
3 packages and 0 specfiles checked; 0 errors, 7 warnings.




Rpmlint (installed packages)
----------------------------
Cannot parse rpmlint output:


Source checksums
----------------
https://crates.io/api/v1/crates/watchman_client/0.7.1/download#/watchman_client-0.7.1.crate :
  CHECKSUM(SHA256) this package     : 1afbab1186833c9b34f64132b80ed4b373ed4eab6f9efa1f55430835200f0a28
  CHECKSUM(SHA256) upstream package : 1afbab1186833c9b34f64132b80ed4b373ed4eab6f9efa1f55430835200f0a28


Requires
--------
rust-watchman_client-devel (rpmlib, GLIBC filtered):
    (crate(anyhow/default) >= 1.0.0 with crate(anyhow/default) < 2.0.0~)
    (crate(bytes/default) >= 1.0.0 with crate(bytes/default) < 2.0.0~)
    (crate(bytes/serde) >= 1.0.0 with crate(bytes/serde) < 2.0.0~)
    (crate(futures/async-await) >= 0.3.13 with crate(futures/async-await) < 0.4.0~)
    (crate(futures/compat) >= 0.3.13 with crate(futures/compat) < 0.4.0~)
    (crate(futures/default) >= 0.3.13 with crate(futures/default) < 0.4.0~)
    (crate(maplit/default) >= 1.0.0 with crate(maplit/default) < 2.0.0~)
    (crate(serde/default) >= 1.0.102 with crate(serde/default) < 2.0.0~)
    (crate(serde/derive) >= 1.0.102 with crate(serde/derive) < 2.0.0~)
    (crate(serde_bser/default) >= 0.3.0 with crate(serde_bser/default) < 0.4.0~)
    (crate(tokio-util/default) >= 0.6.0 with crate(tokio-util/default) < 0.7.0~)
    (crate(tokio-util/full) >= 0.6.0 with crate(tokio-util/full) < 0.7.0~)
    (crate(tokio/default) >= 1.5.0 with crate(tokio/default) < 2.0.0~)
    (crate(tokio/full) >= 1.5.0 with crate(tokio/full) < 2.0.0~)
    (crate(tokio/test-util) >= 1.5.0 with crate(tokio/test-util) < 2.0.0~)
    cargo
    crate(thiserror/default)

rust-watchman_client+default-devel (rpmlib, GLIBC filtered):
    cargo
    crate(watchman_client)



Provides
--------
rust-watchman_client-devel:
    crate(watchman_client)
    rust-watchman_client-devel

rust-watchman_client+default-devel:
    crate(watchman_client/default)
    rust-watchman_client+default-devel



Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10
Command line :/usr/bin/fedora-review -b 1984192 -L 1984191-rust-serde_bser/results
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api
Disabled plugins: R, Perl, SugarActivity, fonts, Java, Python, C/C++, PHP, Haskell, Ocaml
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH

Built with local dependencies:
    /home/michel/src/fedora/reviews/1984191-rust-serde_bser/results/rust-serde_bser+default-devel-0.3.1-1.fc35.noarch.rpm
    /home/michel/src/fedora/reviews/1984191-rust-serde_bser/results/rust-serde_bser-devel-0.3.1-1.fc35.noarch.rpm
    /home/michel/src/fedora/reviews/1984191-rust-serde_bser/results/rust-serde_bser+debug_bytes-devel-0.3.1-1.fc35.noarch.rpm

Comment 3 Gwyn Ciesla 2021-07-22 16:31:25 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-watchman_client


Note You need to log in before you can comment on or make changes to this bug.