Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1987421 - dlm: FTBFS in Fedora rawhide/f35
Summary: dlm: FTBFS in Fedora rawhide/f35
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: dlm
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: David Teigland
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: F35FTBFS
TreeView+ depends on / blocked
 
Reported: 2021-07-29 14:47 UTC by Fedora Release Engineering
Modified: 2021-08-07 15:36 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-08-02 16:55:42 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
build.log (deleted)
2021-07-29 14:47 UTC, Fedora Release Engineering
no flags Details
root.log (deleted)
2021-07-29 14:47 UTC, Fedora Release Engineering
no flags Details
state.log (deleted)
2021-07-29 14:48 UTC, Fedora Release Engineering
no flags Details

Description Fedora Release Engineering 2021-07-29 14:47:49 UTC
dlm failed to build from source in Fedora rawhide/f35

https://koji.fedoraproject.org/koji/taskinfo?taskID=72337824


For details on the mass rebuild see:

https://fedoraproject.org/wiki/Fedora_35_Mass_Rebuild
Please fix dlm at your earliest convenience and set the bug's status to
ASSIGNED when you start fixing it. If the bug remains in NEW state for 8 weeks,
dlm will be orphaned. Before branching of Fedora 36,
dlm will be retired, if it still fails to build.

For more details on the FTBFS policy, please visit:
https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/

Comment 1 Fedora Release Engineering 2021-07-29 14:47:55 UTC
Created attachment 1807309 [details]
build.log

Comment 2 Fedora Release Engineering 2021-07-29 14:47:59 UTC
Created attachment 1807310 [details]
root.log

file root.log too big, will only attach last 32768 bytes

Comment 3 Fedora Release Engineering 2021-07-29 14:48:02 UTC
Created attachment 1807311 [details]
state.log

Comment 4 Fedora Release Engineering 2021-08-01 04:25:21 UTC
Dear Maintainer,

your package has an open Fails To Build From Source bug for Fedora 35.
Action is required from you.

If you can fix your package to build, perform a build in koji, and either create
an update in bodhi, or close this bug without creating an update, if updating is
not appropriate [1]. If you are working on a fix, set the status to ASSIGNED to
acknowledge this. If you have already fixed this issue, please close this Bugzilla report.

Following the policy for such packages [2], your package will be orphaned if
this bug remains in NEW state more than 8 weeks (not sooner than 2021-09-23).

A week before the mass branching of Fedora 36 according to the schedule [3],
any packages not successfully rebuilt at least on Fedora 34 will be
retired regardless of the status of this bug.

[1] https://docs.fedoraproject.org/en-US/fesco/Updates_Policy/
[2] https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/
[3] https://fedorapeople.org/groups/schedule/f-36/f-36-key-tasks.html

Comment 5 Andrew Price 2021-08-02 13:37:57 UTC
From the logs:

In file included from stonith_helper.c:15:
/usr/include/pacemaker/crm/stonith-ng.h:562:10: fatal error: crm/fencing/compat.h: No such file or directory
  562 | #include <crm/fencing/compat.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~
compilation terminated.


I think this might be an issue in pacemaker-libs-devel. Ken, please could you take a look?

Comment 6 Ken Gaillot 2021-08-02 14:29:11 UTC
(In reply to Andrew Price from comment #5)
> From the logs:
> 
> In file included from stonith_helper.c:15:
> /usr/include/pacemaker/crm/stonith-ng.h:562:10: fatal error:
> crm/fencing/compat.h: No such file or directory
>   562 | #include <crm/fencing/compat.h>
>       |          ^~~~~~~~~~~~~~~~~~~~~~
> compilation terminated.
> 
> 
> I think this might be an issue in pacemaker-libs-devel. Ken, please could
> you take a look?

Sort of. Before the upstream 2.1.0 release, stonith-ng.h did not include any other Pacemaker headers, so it was possible to simply include it directly without adding the Pacemaker include path. In 2.1.0, that header now includes another one, which breaks that approach.

Upstream just released a 2.1.1-rc1 that reverts that change, and Fedora builds are underway, so the problem should go away soon.

However, it would still be worthwhile to fix it on the DLM side as well, by adding the output of "pkg-config --cflags pacemaker-fencing" to CFLAGS (or using PKG_CHECK_MODULES if you're using autotools), for future-proofing.

Comment 7 David Teigland 2021-08-02 16:14:42 UTC
I pushed a fix, but fedora builds fail with:

$ fedpkg build
Could not execute build: Unknown build target: main-candidate

or

$ fedpkg build
No local config file exists.
Create package.cfg to specify build targets to build.
Could not execute build: Unknown build target: rawhide-candidate

Comment 8 Andrew Price 2021-08-02 16:31:30 UTC
Do you have an old version of fedpkg? Apparently fedpkg-1.40-2 fixed an issue of that sort.

Comment 9 David Teigland 2021-08-02 16:55:42 UTC
thanks, that worked

Comment 10 Kevin Fenzi 2021-08-07 15:36:23 UTC
Clearing needinfo


Note You need to log in before you can comment on or make changes to this bug.