Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 198880 - Review Request: perl-POE-Component-Client-DNS
Summary: Review Request: perl-POE-Component-Client-DNS
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jason Tibbitts
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks: FE-ACCEPT 198882 198884
TreeView+ depends on / blocked
 
Reported: 2006-07-14 11:35 UTC by Chris Weyl
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-07-15 19:09:47 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)

Description Chris Weyl 2006-07-14 11:35:37 UTC 
Spec URL: http://home.comcast.net/~ckweyl/perl-POE-Component-Client-DNS.spec
SRPM URL:
http://home.comcast.net/~ckweyl/perl-POE-Component-Client-DNS-0.99-0.fc5.src.rpm

Description: 
POE::Component::Client::DNS provides a facility for non-blocking, concurrent DNS
requests. Using POE, it allows other tasks to run while waiting for name servers
to respond.
Comment 1 Jason Tibbitts 2006-07-15 16:44:22 UTC 
I have to tell you that the "0" release violates the naming guidelines; please
make sure to bump this to "1" before you build.

I enabled the test suite just to try it, but I don't think it works under mock
due to an undefined network configuration.  However, five of the tests did run
properly.

* source files match upstream:
   17d8823b50185e4a2536ca8888d45410  POE-Component-Client-DNS-0.99.tar.gz
O package meets naming and packaging guidelines (0 release should be 1)
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.  License text not included upstream.
* latest version is being packaged.
O BuildRequires are proper (BR: perl is redundant)
O No need to pass any compiler flags.
* %clean is present.
* package builds in mock (development, x86_64).
* rpmlint is silent.
* final provides and requires are sane:
   perl(POE::Component::Client::DNS) = 0.99
   perl-POE-Component-Client-DNS = 0.99-0.fc6
  =
   perl(:MODULE_COMPAT_5.8.8)
   perl(Carp)
   perl(Net::DNS)
   perl(POE)
   perl(Socket)
   perl(constant)
   perl(strict)
   perl(vars)
* noarch package; no debuginfo.
* %check is present but necessarily disabled for mock.
* no shared libraries are present.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.

APPROVED
Comment 2 Chris Weyl 2006-07-15 19:09:47 UTC 
Given the recent thread on the list, I'll start submitting future packages with
an initial release of 1.

+Import to CVS
+Add to owners.list
+Bump release, build for devel
+devel build succeeds
+Request branching (FC-4, FC-5)
+Close bug

Thanks for the review!
Note You need to log in before you can comment on or make changes to this bug.