Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 198884 - Review Request: perl-POE-Component-Client-Keepalive
Summary: Review Request: perl-POE-Component-Client-Keepalive
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jason Tibbitts
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On: 198880
Blocks: FE-ACCEPT 198885
TreeView+ depends on / blocked
 
Reported: 2006-07-14 12:06 UTC by Chris Weyl
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-07-26 15:09:35 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)

Description Chris Weyl 2006-07-14 12:06:47 UTC 
Spec URL: http://home.comcast.net/~ckweyl/perl-POE-Component-Client-Keepalive.spec
SRPM URL:
http://home.comcast.net/~ckweyl/perl-POE-Component-Client-Keepalive-0.0801-0.fc5.src.rpm

Description: 
POE::Component::Client::Keepalive creates and manages connections for other
components. It maintains a cache of kept-alive connections for quick reuse. It
is written specifically for clients that can benefit from kept-alive
connections, such as HTTP clients. Using it for one-shot connections would
probably be silly.
Comment 1 Chris Weyl 2006-07-21 03:05:41 UTC 
Bits snipped.

Spec URL: http://home.comcast.net/~ckweyl/perl-POE-Component-Client-Keepalive.spec
SRPM URL:
http://home.comcast.net/~ckweyl/perl-POE-Component-Client-Keepalive-0.0801-1.fc5.src.rpm
Comment 2 Jason Tibbitts 2006-07-26 04:23:26 UTC 
The only thing I have to say about this is that the build sat around for about
three minutes doing nothing, probably due to the test suite.  Everything passed
in the end so I don't see any problems.

* source files match upstream:
  79ea0242da708c7a8e190c00efdfccaf  POE-Component-Client-Keepalive-0.0801.tar.gz
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.  License text not included upstream.
* latest version is being packaged.
* BuildRequires are proper (BR: perl is unnecessary)
* Compiler flags are appropriate (noarch package so none passed)
* %clean is present.
* package builds in mock (development, x86_64).
* noarch package, so no debuginfo.
* rpmlint is silent.
* final provides and requires are sane:
   perl(POE::Component::Client::Keepalive) = 0.0801
   perl(POE::Component::Connection::Keepalive) = 60
   perl-POE-Component-Client-Keepalive = 0.0801-1.fc6
  =
   perl(:MODULE_COMPAT_5.8.8)
   perl(Carp)
   perl(Errno)
   perl(POE)
   perl(POE::Component::Client::DNS)
   perl(POE::Component::Connection::Keepalive)
   perl(POE::Wheel::ReadWrite)
   perl(POE::Wheel::SocketFactory)
   perl(bytes)
   perl(constant)
   perl(strict)
   perl(vars)
   perl(warnings)
* %check is present and all tests pass:
   All tests successful.
   Files=15, Tests=88, 192 wallclock secs ( 2.58 cusr +  0.70 csys =  3.28 CPU)
* no shared libraries are present.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.

APPROVED
Comment 3 Chris Weyl 2006-07-26 15:09:35 UTC 
+Import to CVS
+Add to owners.list
+Bump release, build for devel
+devel build succeeds
+Request branching (FC-5)
+Close bug

Thanks for the review! :)
Note You need to log in before you can comment on or make changes to this bug.