Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 200565 - Review Request: ksynaptics - KDE configuration for synaptics module
Summary: Review Request: ksynaptics - KDE configuration for synaptics module
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Rex Dieter
QA Contact: Fedora Package Reviews List
URL: http://www.cora.nwra.com/~orion/fedora/
Whiteboard:
Depends On: 200555
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-07-28 17:51 UTC by Orion Poplawski
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-07-31 16:25:54 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)

Description Orion Poplawski 2006-07-28 17:51:46 UTC 
Spec Name or Url: http://www.cora.nwra.com/~orion/fedora/ksynaptics.spec
SRPM Name or Url:
http://www.cora.nwra.com/~orion/fedora/ksynaptics-0.3.1-1.fc5.src.rpm
Description: 

KSynaptics (previously QSynaptics) is a Qt/KDE based configuration
utility for the synaptics touchpad drivers.
Comment 1 Rex Dieter 2006-07-28 18:15:26 UTC 
upstream source checks out.
c9c124ba59bbb898bfc73f2ab00e8006  ksynaptics-0.3.1.tar.bz2

A few initial comments:

1.  Icons need scriptlets (See 
http://www.fedoraproject.org/wiki/ScriptletSnippets), something like:

%post
touch --no-create %{_datadir}/icons/hicolor || :
gtk-update-icon-cache -q %{_datadir}/icons/hicolor 2>/dev/null ||: 

%postun

2.  You don't really need:
export QTLIB=${QTDIR}/lib QTINC=${QTDIR}/include
anymore, the qt bug that this worked around is now fixed.
touch --no-create %{_datadir}/icons/hicolor || :
gtk-update-icon-cache -q %{_datadir}/icons/hicolor 2>/dev/null ||:

Otherwise it looks good!  Now, I'll try building and see how it works... (:
Comment 2 Rex Dieter 2006-07-28 18:18:22 UTC 
oops, left %postun blank, it should have been the same:

%post
touch --no-create %{_datadir}/icons/hicolor || :
gtk-update-icon-cache -q %{_datadir}/icons/hicolor 2>/dev/null ||:
Comment 3 Rex Dieter 2006-07-28 18:40:17 UTC 
I'd suggest replacing:
desktop-file-install --vendor=fedora \
       --add-category=Qt \
       --add-category=KDE \
       --add-category=Utility \
       --add-category=X-Fedora \
       --delete-original --dir %{buildroot}%{_datadir}/applications \
       $RPM_BUILD_ROOT/%{_datadir}/applications/kde/%{name}.desktop


with simply:
desktop-file-install \
  --vendor="" --add-category=X-Fedora \
  --dir $RPM_BUILD_ROOT%{_datadir}/applications/kde \
  $RPM_BUILD_ROOT%{_datadir}/applications/kde/*.desktop

The vendor is clear already here (kde), and this is simply a KControl module, 
so there's no need to add those Categories.
Comment 4 Orion Poplawski 2006-07-28 20:39:22 UTC 
spec and src.rpm updated.  New srpm:
http://www.cora.nwra.com/~orion/fedora/ksynaptics-0.3.1-1.fc5.src.rpm though you
really only need the new spe.

- Add icon post/postun scripts
- Add Requires: hicolor-icon-theme
- Remove old QTDIR hack
- Cleanup desktop file

Not sure if the hicolor-icon-theme requires is necessary, but I would think so
since it installs into %{_datadir}/icons/hicolor/...

Thanks for the reviews Rex!
Comment 5 Rex Dieter 2006-07-28 22:29:26 UTC 
The 
Requires: hicolo-icon-theme
probably isn't absolutely required, but I guess it doesn't hurt either.

approved.
Comment 6 Orion Poplawski 2006-07-31 16:25:54 UTC 
Imported, built on devel, and added to owners.list.
Note You need to log in before you can comment on or make changes to this bug.