Created attachment 1831844 [details]
video: homebank installation confusion

This was already partially mentioned in bug 2010660 comment 7, I just explored some cases more and added a video.

Proposing for a blocker discussion. With the current issues it's very easy to end up with 2 HomeBank installations (Fedora RPM + Flathub), and quite hard to uninstall the Fedora RPM installation. However, please note that I've seen this problem only in the combination of Fedora RPM + Flathub (and also the app not available as a Fedora Flatpak). In cases of Fedora RPM + Fedora Flatpak, which is quite common for pre-installed apps in Fedora Workstation, I couldn't reproduce this.

(In reply to Kamil Páral from comment #0)
> Expected results:
> 1. when I open HomeBank app detail page and I have it installed,
> gnome-software should pre-select the way how I have it currently installed,
> i.e. I should always see Open+Remove buttons, and never Install (again)
> button
> 2. the Source menu shouldn't disappear

Thanks for a bug report. The 2.) from the above quote is nothing new, I saw it in the previous version (40.x) too. The 1.) is supposed to work that way, the installed app should be preselected.

I think this is related to, even it's the opposite there:
https://gitlab.gnome.org/GNOME/gnome-software/-/issues/1465

It's better to fill such things upstream. I filled it for you as:
https://gitlab.gnome.org/GNOME/gnome-software/-/issues/1490

> It's better to fill such things upstream. I filled it for you as:
> https://gitlab.gnome.org/GNOME/gnome-software/-/issues/1490

I know, but I need it downstream for the blocker discussion. I subscribed to the upstream issue. Thanks.

> I know, but I need it downstream for the blocker discussion.

Sure, understood.

For what it's worth, I tried with 3.38.3 and that cannot find the RPM version too, it offers the same set of alternatives as the 41.0 (for me two Flatpak versions), the difference is that when I click the application on the Installed page the 3.38.3 version keeps the RPM variant selected, while the 41.0 removes it due to no match.

The variants are figured from the appstream data. There does not match something with the RPM version.

One part of ghe problem is the homebank.appdata.xml content, it doesn't have expected attributes, thus it's treated as a wildcard match, where the wildcards are removed from the result of the alternative applications. More at: https://gitlab.gnome.org/GNOME/gnome-software/-/issues/1490#note_1287432

As mentioned above, this is not a regression, it had been just discovered by using "a different application". I do not think this worth a blocker state.

Milan, are you saying this problem is very specific to HomeBank (and possibly other applications where their metadata differ in different sources), and so that it's unlikely that this will affect a large number of applications?

Note, if g-s wouldn't display a particular source for an app (e.g. flathub would not be accessible), or if it displayed the same app as two different items in search, I think that would be preferable to this inconsistent where it sometimes displays multiple sources, sometimes it doesn't, and often doesn't even allow you to uninstall the app.

(In reply to Kamil Páral from comment #7)
> Milan, are you saying this problem is very specific to HomeBank (and
> possibly other applications where their metadata differ in different
> sources), and so that it's unlikely that this will affect a large number of
> applications?

Yes, I believe it's related to the HomeBank.

I tried to "introspect" the appstream data in question and it seems the HomeBank is the only app I have installed here which exhibits the problem, out of 152 tested. The full appstream data are all fine, it's only the .appdata.xml file causing trouble for the HomeBank. This surprised me a bit, I expected more affected apps, but maybe I'm not totally dull.

After spending quite some time on this, I think the best will be to move this to the `homebank` package and then to their upstream.
When you try with GNOME Notes, it works as expected.

------------------------------------------------------------------------

Some analyse on the HomeBank:

Looking into the code:

   https://bazaar.launchpad.net/~mdoyen/homebank/trunk/view/head:/data/homebank.appdata.xml.in#L4

there is used:

   <licence>GPL-2.0+</licence>

but this is not known to the appstream project:

   https://www.freedesktop.org/software/appstream/docs/sect-Metadata-Application.html

The appstream uses the <metadata_license/> element, which gnome-software is looking for.

I can workaround this on the gnome-software side, but as it would be only for the HomeBank (from those I have installed), I'd prefer not to do that.

Side note:

   $ appstream-util validate-relax --nonet /usr/share/appdata/homebank.appdata.xml 
   /usr/share/appdata/homebank.appdata.xml: OK

   $ appstream-util validate --nonet /usr/share/appdata/homebank.appdata.xml 
   /usr/share/appdata/homebank.appdata.xml: FAILED:
   • tag-invalid           : <metadata_license> is not valid [GPL-2.0+]
   • tag-missing           : <content_rating> required [use https://odrs.gnome.org/oars]
   • tag-missing           : <release> required
   • tag-missing           : <name> is not present
   • tag-missing           : <summary> is not present
   Validation of files failed

Discussed during the 2021-10-11 blocker review meeting: [0]

The decision to classify this bug as a "RejectedBlocker (Final)" was made as multiple testers found no bugs in basic functionality here, screenshot taking works as intended via shortcuts and in the app launched from the overview.

[0] https://meetbot.fedoraproject.org/fedora-blocker-review/2021-10-11/f35-blocker-review.2021-10-11-16.00.txt

Disregard comment 10.

Discussed during the 2021-10-11 blocker review meeting: [0]

The decision to classify this bug as a "RejectedBlocker (Final)" was made as per discussion in the bug reports downstream and upstream the problems here seem to be triggered by specific qualtiies of Homebank's flatpak metadata, thus they're not really broad enough to count as basic functionality failures (and can be fixed outside of Fedora, in the metadata).

[0] https://meetbot.fedoraproject.org/fedora-blocker-review/2021-10-11/f35-blocker-review.2021-10-11-16.00.txt

hi guys, did you know if this is fixed in recent versions?
I do no use gnome or gnome-software, only Xfce, so I'm not affected by this behavior / bug.
thanks.

You can run gnome-software from a command line and verify yourself, like anybody else.

I tested with gnome-software-43.rc-1.fc37.x86_64 and the problem is still there. Once the RPM version is installed it's lost from the Sources and only the Flatpak version is present to the user.

I suggest you to pass this to the upstream.

When I do the below changes it'll work properly (they simply use an old appstream data format). They should pay attention to the validation of the appdata content. I used appstreamcli 0.15.4 as:

  $ appstreamcli validate --explain --no-net /usr/share/appdata/homebank.appdata.xml

By the way, the file should be installed in /usr/share/metainfo/ these days, not in the ../appdata/.

The changes I made, in the diff format:

@@ -1,7 +1,10 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<application>
-  <id type="desktop">homebank.desktop</id>
-  <licence>GPL-2.0+</licence>
+<component type="desktop">
+  <id>homebank.desktop</id>
+  <metadata_license>CC0-1.0</metadata_license>
+  <project_license>GPL-2.0+</project_license>
+  <name>Homebank</name>
+  <summary>Homebank summary</summary>
   <description>
     <p>HomeBank is a free software (as in "free speech" and also as in "free beer") that will assist you to manage your personal accounting.</p>
     <p xml:lang="ar">برنامج هوم بانك هو برنامج مجاني ويستطيع ان يساعدك في ادارة حساباتك الشخصية والمالية</p>
@@ -133,8 +136,10 @@
     <p xml:lang="zh_TW">如果您正在尋找一個完全免費而簡單的方法來管理您的個人財務，那麼HomeBank會是首選軟體。</p>
   </description>
   <screenshots>
-    <screenshot width="624" type="default" height="351">http://homebank.free.fr/img/homebank-appdata.png</screenshot>
+    <screenshot>
+      <image  width="624" type="default" height="351">http://homebank.free.fr/img/homebank-appdata.png</image>
+    </screenshot>
   </screenshots>
   <url type="homepage">http://homebank.free.fr</url>
   <updatecontact>homebank_at_free.fr</updatecontact>
-</application>
\ No newline at end of file
+</component>

I filed the bug in homebank upstream:
https://bugs.launchpad.net/homebank/+bug/1989171

As far as I can tell, this should be fixed in HomeBank 5.5.7.

FEDORA-2022-b12a5d1d6b has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-b12a5d1d6b

FEDORA-2022-0bdbd94aba has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-0bdbd94aba

FEDORA-2022-b12a5d1d6b has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-b12a5d1d6b`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-b12a5d1d6b

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

(In reply to Fedora Update System from comment #17)
> FEDORA-2022-b12a5d1d6b has been submitted as an update to Fedora 37.
> https://bodhi.fedoraproject.org/updates/FEDORA-2022-b12a5d1d6b

Fixed, thanks.

FEDORA-2022-0bdbd94aba has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-0bdbd94aba`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-0bdbd94aba

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2022-0a35883117 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-0a35883117

FEDORA-2022-1eee1a193b has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-1eee1a193b

FEDORA-2022-0a35883117 has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-0a35883117`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-0a35883117

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2022-1eee1a193b has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-1eee1a193b`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-1eee1a193b

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2022-1eee1a193b has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-2022-0a35883117 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.