Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 201493 - Review Request: perl-Module-Starter-PBP
Summary: Review Request: perl-Module-Starter-PBP
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Patrice Dumas
QA Contact: Fedora Package Reviews List
URL: http://search.cpan.org/dist/Module-St...
Whiteboard:
: 201492 (view as bug list)
Depends On: 201491
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-08-06 07:57 UTC by Chris Weyl
Modified: 2007-11-30 22:11 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-08-08 20:00:33 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Chris Weyl 2006-08-06 07:57:23 UTC
SRPM URL: http://home.comcast.net/~ckweyl/perl-Module-Starter-PBP-0.000003-1.fc5.src.rpm
SPEC URL: http://home.comcast.net/~ckweyl/perl-Module-Starter-PBP.spec

Description:
This module implements a simple approach to creating modules and their support
files, based on the Module::Starter approach.

When used as a Module::Starter plugin, this module allows you to specify a
simple directory of templates which are filled in with module-specific
information, and thereafter form the basis of your new module.

The default templates that this module initially provides are based on the
recommendations in the book "Perl Best Practices".

Comment 1 Chris Weyl 2006-08-06 07:58:48 UTC
*** Bug 201492 has been marked as a duplicate of this bug. ***

Comment 2 Chris Weyl 2006-08-06 08:32:54 UTC
Update to include an explict requires on perl(Module::Starter::Simple); this
requires was blocked from autodep as it was of the form "use base
Module::Starter::Simple;"

SRPM URL:
http://home.comcast.net/~ckweyl/perl-Module-Starter-PBP-0.000003-2.fc5.src.rpm
SPEC URL: http://home.comcast.net/~ckweyl/perl-Module-Starter-PBP.spec

Comment 3 Patrice Dumas 2006-08-08 14:16:47 UTC
Missing BuildRequires for perl(Test::More)

Comment 4 Chris Weyl 2006-08-08 14:55:57 UTC
perl(Test::More) is a core module, but easy enough to include.

SRPM URL:
http://home.comcast.net/~ckweyl/perl-Module-Starter-PBP-0.000003-3.fc5.src.rpm
SPEC URL: http://home.comcast.net/~ckweyl/perl-Module-Starter-PBP.spec

Comment 5 Patrice Dumas 2006-08-08 15:08:19 UTC
* rpmlint is silent
* package named according to guidelines
* free software, licences not included
* meets packaging guidelines
* spec legible
* source match upstream
2e39d69cd77f64721a875d903a632be3  Module-Starter-PBP-v0.0.3.tar.gz
* sane provides
Provides: perl(Module::Starter::PBP)
* %files right

APPROVED 

Comment 6 Chris Weyl 2006-08-08 20:00:33 UTC
+Import to CVS
+Add to owners.list
+Bump release, build for devel
+devel build succeeds
+Request branching (FC-4, FC-5)
+Close bug

Thanks for the review! :)


Note You need to log in before you can comment on or make changes to this bug.