Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at
Bug 201842 - Review Request: plotutils - GNU plotutils graphics libs and utils
Summary: Review Request: plotutils - GNU plotutils graphics libs and utils
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Paul F. Johnson
QA Contact: Fedora Package Reviews List
Depends On:
Blocks: FE-ACCEPT 196510
TreeView+ depends on / blocked
Reported: 2006-08-09 12:27 UTC by Denis Leroy
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2006-08-18 11:40:07 UTC
Type: ---

Attachments (Terms of Use)

Description Denis Leroy 2006-08-09 12:27:32 UTC
Spec URL:

Description: The GNU plotutils package contains software for both programmers and
technical users. Its centerpiece is libplot, a powerful C/C++ function
library for exporting 2-D vector graphics in many file formats, both
vector and raster. It can also do vector graphics animations. Besides
libplot, the package contains command-line programs for plotting
scientific data. Many of them use libplot to export graphics.

Notes to reviewer:
- the cp's in the %prep section replace a symlink used in the source tree to share the same source file across multiple directories. This was breaking the debuginfo package.
- examples moved to /usr/share/doc where they belong.

Comment 1 Paul F. Johnson 2006-08-09 22:28:56 UTC
Looking at the spec file

You need Requires (post) : ldconfig unless you change post to be -p /sbin/ldconfig

mkdir docs-to-include

Where exactly does that get made? Why not just create a directory in the
buildroot and shift from there rather than interfere with the dearchived source?
This is not a complaint, just a suggestion. Other than patches, doing things in
the BUILD I've always considered a bad idea (TM)

Comment 2 Paul F. Johnson 2006-08-10 10:41:20 UTC
rpmlint on the src package is giving the warning that you've mixed spaces with tabs

builds cleaning in mock
installs cleanly using yun localinstall
rpm -qa --requires is not showing anything untoward

I'll need to do the full review when I'm sitting infront of the machine.

Can you address the mixed spaces and tabs and just upload a new spec file?

Comment 3 Denis Leroy 2006-08-10 13:30:29 UTC

> warning that you've mixed spaces with tabs

Somehow I always get that even when I use tabs everywhere! :-) Fixed.

> You need Requires (post) : ldconfig


> mkdir docs-to-include

I think it's a pretty harmless trick to add directories straight into
/usr/share/doc/%{name}. I use that already in the gtkmm packages. Now I'm not
sure it would work the same way if you created it under BUILDROOT, because %doc
works differently if you give it a relative or absolute path, and the relative
path is always from the source dir... I think you'd have to explicitely move
things from %{_datadir} into %{_docdir}/%{name}/ after installation.

Comment 4 Denis Leroy 2006-08-16 11:21:18 UTC
Ping :-) (we're so close!)

Comment 5 Paul F. Johnson 2006-08-16 22:23:23 UTC
Sorry - not been that well recently, I'm usually out of it by about 9.30pm
(British Summer Time). It's 2nd on my list for tomorrow's reviews. Who knows, it
may even be good to go (TM) by this time tomorrow!

Comment 6 Paul F. Johnson 2006-08-17 22:41:03 UTC

Software works (tested against Ortep)
Consistent use of macros
Includes documentation
No static libs/.la files
No dupes from the rpms
spec file in american english
rpmlint clean
mock builds fine
Includes devel file, no .pc file, so no pkgconfig required for devel
Correct use of scriptlets
Dist tag fine
Doesn't leave a mess when deinstalling

I'm happy with this.


Please remember to close the bug and change the tab to NEXT-RELEASE.

Comment 7 Denis Leroy 2006-08-18 11:40:07 UTC
Paul, thanks for your review!

Note You need to log in before you can comment on or make changes to this bug.