Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 202423 - Review Request: trackballs - Steer a marble ball through a labyrinth
Summary: Review Request: trackballs - Steer a marble ball through a labyrinth
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Wart
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks: FE-ACCEPT 202424
TreeView+ depends on / blocked
 
Reported: 2006-08-14 12:05 UTC by Hans de Goede
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-08-15 19:00:15 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)

Description Hans de Goede 2006-08-14 12:05:34 UTC 
Spec URL: http://people.atrpms.net/~hdegoede/trackballs.spec
SRPM URL: http://people.atrpms.net/~hdegoede/trackballs-1.1.2-1.src.rpm
Description:
Trackballs is a game in which you steer a marble ball through tracks of varying
difficulty. The game features 3D graphics, an integerated level editor and high
quality soundeffects and background music.
Comment 1 Wart 2006-08-14 23:22:39 UTC 
This is a fairly easy package:

GOOD
====
* rpmlint output clean
* Package/spec name matches upstream
* GPL license ok, license file included
* Source matches upstream:
  9ea9ca93d87bb0f9ad8abca1b34af594  trackballs-1.1.2.tar.gz
* Builds in mock on FC5-i386, FC5-x86_64, FC6-i386, FC6-x86_64
* No need for a -devel subpackage
* No need for a -doc subpackage
* locale files installed correctly
* .desktop file installed correctly
* icon files installed and updated in %post/%postun correctly
* No duplicate %files
* Owns all directories that it creates; does not own directories that it
  should not.
* Runs on FC5-x86_64.

MUSTFIX
=======
* BR: libGL-devel is redundant.  This is already required by libGLU-devel.
* BR: gcc-c++ is already part of the minimal buildroot, so it can be removed.
Comment 2 Hans de Goede 2006-08-15 17:55:03 UTC 
(In reply to comment #1)
> 
> MUSTFIX
> =======
> * BR: libGL-devel is redundant.  This is already required by libGLU-devel.
> * BR: gcc-c++ is already part of the minimal buildroot, so it can be removed.

New version with this fixed here:
Spec URL: http://people.atrpms.net/~hdegoede/trackballs.spec
SRPM URL: http://people.atrpms.net/~hdegoede/trackballs-1.1.2-2.src.rpm
Comment 3 Wart 2006-08-15 18:01:11 UTC 
All MUSTFIX items fixed.

APPROVED.
Comment 4 Hans de Goede 2006-08-15 19:00:15 UTC 
Thanks!

Imported and build, closing.
Note You need to log in before you can comment on or make changes to this bug.