Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 2049382 - Review Request: aws-c-auth - C99 library implementation of AWS client-side authentication: standard credentials providers and signing.
Summary: Review Request: aws-c-auth - C99 library implementation of AWS client-side au...
Keywords:
Status: CLOSED DUPLICATE of bug 2279012
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 2279003 2049379 2049397 2049400 2049644 2049656
Blocks: 2049792
TreeView+ depends on / blocked
 
Reported: 2022-02-02 05:31 UTC by David Duncan
Modified: 2024-05-03 22:41 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2024-05-03 22:41:40 UTC
Type: ---
Embargoed:
ngompa13: fedora-review?

Attachments (Terms of Use)

Description David Duncan 2022-02-02 05:31:55 UTC 
Spec URL: https://davdunc.fedorapeople.org/awscli-2-rpms/aws-c-auth.spec
SRPM URL: https://davdunc.fedorapeople.org/awscli-2-rpms/aws-c-auth-0.6.5-1.fc35.src.rpm
Description: C99 library implementation of AWS client-side authentication: standard credentials providers and signing.
Fedora Account System Username: davdunc
Comment 1 David Duncan 2022-02-02 06:08:04 UTC 
SRPM URL: https://davdunc.fedorapeople.org/awscli-2-rpms/aws-c-auth-0.6.5-2.fc35.src.rpm
Comment 2 Neal Gompa 2022-02-02 11:09:00 UTC 
Taking this review.
Comment 3 Neal Gompa 2022-02-02 11:11:08 UTC 
> %files
> %license LICENSE
> %doc README.md
>
> %files libs
> %{_libdir}/libaws-c-auth.so
> %{_libdir}/libaws-c-auth.so.1.0.0

These two files sections can be collapsed into a single "%files libs" section.

And "%{_libdir}/libaws-c-auth.so" needs to be in the devel subpackage.

Finally, with these changes, the libs subpackage shouldn't depend on an empty main package that isn't going to be made, so:

> Requires:       %{name}%{?_isa} = %{version}-%{release}

should be dropped.
Comment 4 Neal Gompa 2022-02-02 11:34:30 UTC 
> %{_libdir}/aws-c-auth/cmake/aws-c-auth-config.cmake
> %{_libdir}/aws-c-auth/cmake/shared/aws-c-auth-targets-noconfig.cmake
> %{_libdir}/aws-c-auth/cmake/shared/aws-c-auth-targets.cmake

The directory structure is wrong here. This needs to be "%{_libdir}/cmake/aws-c-auth" instead of "%{_libdir}/aws-c-auth/cmake". The CMake dependency generator isn't picking up anything and CMake can't use the modules unless it's in the right directory structure.
Comment 5 David Duncan 2022-02-03 02:45:36 UTC 
Updated for all of these issues. Bumped spec
SPEC: https://davdunc.fedorapeople.org/awscli-2-rpms/aws-c-auth.spec
SRPM: https://davdunc.fedorapeople.org/awscli-2-rpms/aws-c-auth-0.6.5-3.fc35.src.rpm
Comment 6 David Duncan 2022-02-24 14:11:21 UTC 
SRPM URL: https://davdunc.fedorapeople.org/awscli-2-rpms/aws-c-auth-0.6.5-6.fc35.src.rpm
Spec URL: https://davdunc.fedorapeople.org/awscli-2-rpms/aws-c-auth.spec
Comment 7 Neal Gompa 2022-02-26 02:17:56 UTC 
This can't proceed until its build dependencies are cleared.
Comment 8 Package Review 2023-02-27 00:45:26 UTC 
This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time, but it seems
that the review is still being working out by you. If this is right, please
respond to this comment clearing the NEEDINFO flag and try to reach out the
submitter to proceed with the review.

If you're not interested in reviewing this ticket anymore, please clear the
fedora-review flag and reset the assignee, so that a new reviewer can take
this ticket.

Without any reply, this request will shortly be resetted.
Comment 9 Dominik Wombacher 2024-05-03 22:41:40 UTC 

*** This bug has been marked as a duplicate of bug 2279012 ***
Note You need to log in before you can comment on or make changes to this bug.