Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 2051055 - Review Request: kpublictransport - Library to assist with accessing public transport timetables and other data
Summary: Review Request: kpublictransport - Library to assist with accessing public tr...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Mark E. Fuller
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-02-06 03:11 UTC by Justin Zobel
Modified: 2022-03-26 15:06 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-03-11 14:15:01 UTC
Type: Bug
Embargoed:
mark.e.fuller: fedora-review+

Attachments (Terms of Use)

Description Justin Zobel 2022-02-06 03:11:12 UTC 
Spec URL: https://pagure.io/kpublictransport_rpm/raw/master/f/kpublictransport.spec
SRPM URL: https://pagure.io/kpublictransport_rpm/raw/master/f/kpublictransport-21.12.0-1.fc35.src.rpm

Description:
Fedora Account System Username: justinz

Pagure URL: https://pagure.io/kpublictransport_rpm
Comment 1 Mark E. Fuller 2022-02-07 08:38:31 UTC 
On initial review, there are two  issues that get flagged:

- If your application is a C or C++ application you must list a
  BuildRequires against gcc, gcc-c++ or clang.
  Note: No gcc, gcc-c++ or clang found in BuildRequires
  See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/

- Development (unversioned) .so files in -devel subpackage, if present.
  Note: Unversioned so-files directly in %_libdir.
  See: https://docs.fedoraproject.org/en-US/packaging-
  guidelines/#_devel_packages


Some additional things:

-the devel package should have "Requires: %{name}%{?_isa} = %{version}-%{release}"

-are tests being run? I see no %check section in the spec file, but a "tests" directory in the source code: please add this section and run tests if applicable
Comment 2 Justin Zobel 2022-02-09 01:31:22 UTC 
Spec URL: https://pagure.io/kpublictransport_rpm/raw/master/f/kpublictransport.spec
SRPM URL: https://pagure.io/kpublictransport_rpm/raw/master/f/kpublictransport-21.12.2-1.fc35.src.rpm

Updated all requested items, updated version to latest as well.
Comment 3 Mark E. Fuller 2022-02-10 07:47:50 UTC 
Looks like all the requested changes have been made and that the package is compliant - approved
Comment 4 Vitaly 2022-02-10 11:33:41 UTC 
> %{_kf5_libdir}/*.so.*

Please add soversion number here to avoid accidental bumps:
%{_kf5_libdir}/*.so.0*

> %{_kf5_libdir}/cmake/*

Must be moved to -devel subpackage.
Comment 5 Vitaly 2022-02-10 11:35:09 UTC 
> License: BSD and CC0-1.0 and LGPLv2+ and MIT and ODbL-1.0

Please remove a separate License field from the -devel subpackage.
Comment 6 Mark E. Fuller 2022-02-10 11:39:14 UTC 
Thanks for the additional review, Vitaly and catching the missed items - I will make a note of these items for my future reviews
Comment 7 Vitaly 2022-02-10 11:49:39 UTC 
I will sponsor you to the packagers group.
Comment 8 Justin Zobel 2022-02-10 12:07:19 UTC 
Have made the requested changes, URLs remain the same.
Comment 9 Gwyn Ciesla 2022-02-10 14:49:14 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/kpublictransport
Comment 10 Justin Zobel 2022-02-11 01:11:19 UTC 
Thank you all for your help, repository created and builds happening.
Comment 11 Fedora Update System 2022-03-02 00:37:50 UTC 
FEDORA-2022-7f42d9f3fc has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2022-7f42d9f3fc
Comment 12 Fedora Update System 2022-03-02 00:37:51 UTC 
FEDORA-2022-89d565f1ef has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-89d565f1ef
Comment 13 Fedora Update System 2022-03-02 00:37:52 UTC 
FEDORA-2022-28beac300c has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-28beac300c
Comment 14 Fedora Update System 2022-03-02 15:56:31 UTC 
FEDORA-2022-7f42d9f3fc has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2022-7f42d9f3fc`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-7f42d9f3fc

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
Comment 15 Fedora Update System 2022-03-02 16:15:47 UTC 
FEDORA-2022-28beac300c has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2022-28beac300c`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-28beac300c

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
Comment 16 Fedora Update System 2022-03-02 19:43:10 UTC 
FEDORA-2022-89d565f1ef has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2022-89d565f1ef`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-89d565f1ef

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
Comment 17 Fedora Update System 2022-03-11 14:15:01 UTC 
FEDORA-2022-7f42d9f3fc has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.
Comment 18 Fedora Update System 2022-03-11 14:43:43 UTC 
FEDORA-2022-28beac300c has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.
Comment 19 Fedora Update System 2022-03-26 15:06:26 UTC 
FEDORA-2022-89d565f1ef has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.
Note You need to log in before you can comment on or make changes to this bug.