Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 205537 - Review Request: perl-Test-Object - Thoroughly testing objects via registered handlers
Summary: Review Request: perl-Test-Object - Thoroughly testing objects via registered...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Ralf Corsepius
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-09-06 23:27 UTC by Jose Pedro Oliveira
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-09-16 18:20:08 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)

Description Jose Pedro Oliveira 2006-09-06 23:27:05 UTC 
Spec URL:
ftp://perl.di.uminho.pt/pub/fedora/perl-Test-Object.spec

SRPM URL:
ftp://perl.di.uminho.pt/pub/fedora/perl-Test-Object-0.06-1.src.rpm

Description:
Test::Object is a testing package designed to allow you to easily test
what you believe is a valid object against the expected behaviour of
all of the classes in its inheritance tree in one single call.
Comment 1 Jose Pedro Oliveira 2006-09-06 23:32:12 UTC 
Notes to reviewer(s):

* The requirement  'Test::Builder' => '0.62'  is wrong.
  I believe the author wanted the version to be 0.32
  (the module version included in perl 5.8.8).

  - This doesn't abort the built (=> no patch)
  - This issue has already been raised in CPAN's RT system
    (http://rt.cpan.org/Public/Bug/Display.html?id=21278)

* This module is a new requirement of PPI 1.117.
Comment 2 Ralf Corsepius 2006-09-07 11:50:27 UTC 
(In reply to comment #1)
> Notes to reviewer(s):
> 
> * The requirement  'Test::Builder' => '0.62'  is wrong.
>   I believe the author wanted the version to be 0.32
>   (the module version included in perl 5.8.8).
I am inclined to agree, but I'd patch Makefile.PL and
BR: perl(Test::Builder) >= 0.32, to make this discrepancy apparent.

Anyway, decision left to you ...

APPROVED
Comment 3 Jose Pedro Oliveira 2006-09-07 13:31:38 UTC 
(In reply to comment #2)
> (In reply to comment #1)
> > Notes to reviewer(s):
> > 
> > * The requirement  'Test::Builder' => '0.62'  is wrong.
> >   I believe the author wanted the version to be 0.32
> >   (the module version included in perl 5.8.8).
> I am inclined to agree, but I'd patch Makefile.PL and
> BR: perl(Test::Builder) >= 0.32, to make this discrepancy apparent.
> 
> Anyway, decision left to you ...

I will patch the Makefile.PL.

> APPROVED

Thanks.
Comment 4 Jose Pedro Oliveira 2006-09-07 13:51:30 UTC 
The author has released version 0.07 a few hours ago with 
   perl(Test::Builder) >= 0.33
as the build requirement.

I will open a new RT ticket about it (trying to have the version changed to 0.32).
Meanwhile I import and patch Test::Object 0.07 (I will delay branching until a
hear from upstream). 

References:
* Diff from Test-Object-0.06 to Test-Object-0.07
  http://search.cpan.org/diff?from=Test-Object-0.06&to=Test-Object-0.07
Comment 5 Jose Pedro Oliveira 2006-09-16 17:10:34 UTC 
Still no news from upstream.

I have just requested the FC-5 branch creation as it built correctly in devel
(with a Nakefile.PL patch) and the PPI update also passed all its tests.
Comment 6 Jose Pedro Oliveira 2006-09-16 18:20:08 UTC 
Built for FC-5 and devel (perl-PPI-1.117-1 also built correctly for FC-5 and devel).
Note You need to log in before you can comment on or make changes to this bug.