Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at
Bug 207082 - Review Request: perl-Feed-Find - Syndication feed auto-discovery
Summary: Review Request: perl-Feed-Find - Syndication feed auto-discovery
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Jason Tibbitts
QA Contact: Fedora Package Reviews List
Depends On:
TreeView+ depends on / blocked
Reported: 2006-09-19 08:01 UTC by Patrice Dumas
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2006-09-24 11:22:44 UTC
Type: ---

Attachments (Terms of Use)

Description Patrice Dumas 2006-09-19 08:01:29 UTC
Spec URL:
Feed::Find implements feed auto-discovery for finding syndication feeds, 
given a URI. It (currently) passes all of the auto-discovery tests at

Feed::Find will discover the following feed formats:

    * RSS 0.91
    * RSS 1.0
    * RSS 2.0
    * Atom

Comment 1 Jason Tibbitts 2006-09-23 01:30:03 UTC
This fails to build for me:

#   Failed test in t/01-find.t at line 13.
#          got: '0'
#     expected: '1'

#   Failed test in t/01-find.t at line 14.
#          got: undef
#     expected: ''

#   Failed test in t/01-find.t at line 20.
#          got: '0'
#     expected: '1'

#   Failed test in t/01-find.t at line 21.
#          got: undef
#     expected: ''
# Looks like you failed 4 tests of 4.
        Test returned status 4 (wstat 1024, 0x400)
DIED. FAILED tests 1-4
        Failed 4/4 tests, 0.00% okay
Failed Test Stat Wstat Total Fail  Failed  List of Failed
t/01-find.t    4  1024     4    4 100.00%  1-4
Failed 1/2 test scripts, 50.00% okay. 4/5 subtests failed, 20.00% okay.

I doubt this test will ever work in mock.  I think you need "rm t/01-find.t" in
%check (or in %prep if you want to avoid a complaint about a missing test) with
suitable comments to indicate why it's being disabled.

That done, things build OK.

I'll assume that change is done for the purposes of this review.
* source files match upstream:
   be4537f652d41243cbf98f5e937d16f3  Feed-Find-0.06.tar.gz
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.  License text not included upstream.
* latest version is being packaged.
O BuildRequires are proper (BR: perl is unnecessary, and perl(LWP::UserAgent) is
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* rpmlint is silent.
* final provides and requires are sane:
   perl(Feed::Find) = 0.06
   perl-Feed-Find = 0.06-1.fc6
* %check is present and all tests pass:
   All tests successful.
   Files=1, Tests=1,  0 wallclock secs ( 0.04 cusr +  0.01 csys =  0.05 CPU)
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED, provided the non-runnable test is removed so that things build in mock.

Comment 2 Patrice Dumas 2006-09-24 11:22:44 UTC
Thanks for the review. I imported in cvs after removing the test
in %prep. It built in devel.

Note You need to log in before you can comment on or make changes to this bug.